From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yosry Ahmed <yosry@kernel.org>, pratmal@google.com
Cc: akpm@linux-foundation.org, shuah@kernel.org,
yosryahmed@google.com, ljs@kernel.org, Liam.Howlett@oracle.com,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/mm: use pattern matching in .gitignore
Date: Fri, 8 May 2026 21:32:25 +0200 [thread overview]
Message-ID: <b6717dee-486b-4c61-8ec8-0e4269959469@kernel.org> (raw)
In-Reply-To: <CAO9r8zMWmk3HdJOW=DbtCoZrTjjFJ-ErAwOvG=8qG9bL00Xwyw@mail.gmail.com>
On 5/8/26 20:34, Yosry Ahmed wrote:
> On Tue, May 5, 2026 at 8:22 AM <pratmal@google.com> wrote:
>>
>> From: Pratyush Mallick <pratmal@google.com>
>>
>> The current .gitignore hardcodes each generated test binary by name,
>> requiring updates every time a new test is added.
>>
>> Switch to the patten-matching approach similar to KVM:selftests.
>> Ignore everything by default and then allow source extensions (.c, .h, .sh)
>> and tracked non-source files.
>>
>> To avoid un-ignoring the generated headers, rename local_config.h to
>> local_config.h_gen.
>>
>> Acked-by: Lorenzo Stoakes <ljs@kernel.org>
>> Reviewed-by: Yosry Ahmed <yosryahmed@google.com>
>> Reviewed-by: David Hildenbrand <david@kernel.org>
>
> I think these need to be sorted out (as I mentioned privately).
>
> Also, we probably need to split this into two patches: one renaming
> local_config.h and one updating .gitignore.
Yeah we could, but no strong opinion from my side.
--
Cheers,
David
prev parent reply other threads:[~2026-05-08 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 15:22 [PATCH v2] selftests/mm: use pattern matching in .gitignore pratmal
2026-05-08 18:29 ` Mike Rapoport
2026-05-08 18:34 ` Yosry Ahmed
2026-05-08 19:32 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6717dee-486b-4c61-8ec8-0e4269959469@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pratmal@google.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=yosry@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox