From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dave Hansen <dave.hansen@intel.com>, Uros Bizjak <ubizjak@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
x86@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-arch@vger.kernel.org, netdev@vger.kernel.org,
Nadav Amit <nadav.amit@gmail.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers]
Date: Sat, 07 Jun 2025 10:31:05 -0400 [thread overview]
Message-ID: <b67d720104bf97cfeb5c34132f75edc9bf97cb3a.camel@HansenPartnership.com> (raw)
In-Reply-To: <34a2bfa5-30e1-4ba0-ac36-bf07a0d60d97@intel.com>
On Sat, 2025-06-07 at 07:12 -0700, Dave Hansen wrote:
[...]
> James, by partial revert, did you mean to revert in stable but not
> mainline? I assumed you meant to just revert patch 6/6 of the series
> (stable and mainline) but leave 1-5 in place so turning it back on
> later was easier.
No, we had to put the revert through mainline because too many people
who build their own kernels use the firmware service.
We definitely didn't revert the entire series. I constructed a new
patch which was effectively a partial revert only of the behaviour that
was tickling the bug.
For the record, this was the series containing the problem:
https://lore.kernel.org/all/20250119151214.23562-1-James.Bottomley@HansenPartnership.com/
And this is the revert we eventually came up with:
https://lore.kernel.org/all/63837c36eceaf8cf2af7933dccca54ff4dd9f30d.camel@HansenPartnership.com/
So it was specifically not a general revert but a narrowly crafted one
to get firmware services working again.
The mechanism we did was to queue the revert as an -rc fix so it went
in immediately and got backported to stable and then queue the revert
of the revert for the next merge window (and check before sending to
Linus that the user space update had spread far enough otherwise we'd
have skipped to the merge window after).
Regards,
James
prev parent reply other threads:[~2025-06-07 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 16:05 [PATCH v4 0/6] Enable strict percpu address space checks Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 1/6] x86/kgdb: Use IS_ERR_PCPU() macro Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 2/6] compiler.h: Introduce TYPEOF_UNQUAL() macro Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 3/6] percpu: Use TYPEOF_UNQUAL() in variable declarations Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 4/6] percpu: Use TYPEOF_UNQUAL() in *_cpu_ptr() accessors Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 5/6] percpu: Repurpose __percpu tag as a named address space qualifier Uros Bizjak
2025-01-27 16:05 ` [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers Uros Bizjak
2025-04-09 11:07 ` Jiri Slaby
2025-04-09 11:43 ` Uros Bizjak
2025-04-09 15:09 ` H. Peter Anvin
2025-04-09 15:15 ` Uros Bizjak
2025-06-05 14:27 ` Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] Jiri Slaby
2025-06-05 14:32 ` Jiri Slaby
2025-06-05 16:17 ` Alexei Starovoitov
2025-06-05 14:39 ` Dr. David Alan Gilbert
2025-06-05 17:15 ` Dave Hansen
2025-06-05 17:31 ` Uros Bizjak
2025-06-06 9:17 ` Jiri Slaby
2025-06-06 9:27 ` Uros Bizjak
2025-06-06 13:56 ` James Bottomley
2025-06-06 16:39 ` Alexei Starovoitov
2025-06-06 18:48 ` Uros Bizjak
2025-06-06 15:43 ` Dave Hansen
2025-06-07 8:52 ` Uros Bizjak
2025-06-07 14:12 ` Dave Hansen
2025-06-07 14:31 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67d720104bf97cfeb5c34132f75edc9bf97cb3a.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=cl@linux.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dennis@kernel.org \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shung-hsi.yu@suse.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).