From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A83C83F1B for ; Thu, 17 Jul 2025 11:57:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 172036B0095; Thu, 17 Jul 2025 07:57:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FC1C6B0096; Thu, 17 Jul 2025 07:57:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F05B46B0098; Thu, 17 Jul 2025 07:56:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DCB0C6B0095 for ; Thu, 17 Jul 2025 07:56:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B35D6BAF59 for ; Thu, 17 Jul 2025 11:56:59 +0000 (UTC) X-FDA: 83673605358.06.7B387AF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 472D4180013 for ; Thu, 17 Jul 2025 11:56:57 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SIdB3iC0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752753417; a=rsa-sha256; cv=none; b=Ex+KV09z7q6EdUx+kd6haWnasolXfCtRm1Hwah750nRGRBdVeIsE3wLZjNardQOA/dm1aT 3/QijvjupsejasVZgimC4MZbDVUCbcngNUCbgQxhKQzQLq0plhMLQHpsdB50ku2+tProhh CsVvkHy07WBo+Flh0/JcaNdM9ymHOdc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SIdB3iC0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752753417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q713kcTrVcU55478GZKOwac+Tj8dXDvZNDRg6hJ9+Ck=; b=1Q2u9pEMjEerw1FSSrebxtizZf69WwynAkdvoywOWQNz/Lk1ULyT9LGmHP7xEsJnmDyeup AcVPqsmmV/jPA6h2ZjWDA+5yJboAIflYFPylcmsKfolGlbdCPyIID9XodolZZMtqUuUL+N 6+XSOUYbHkZXsLlAAYfqIPuTOKluRp0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752753416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q713kcTrVcU55478GZKOwac+Tj8dXDvZNDRg6hJ9+Ck=; b=SIdB3iC0152nYkwNnnKdNNbhRhMqBgF5FMrpmb1nQaNjKzGDI5S0joy0WEkJuAdNt6OfrY j/vxXBKzJEa1JAMm6f14vD75mqwV3YQQbEdJ8B/Hq5t0InXx1xhFr8MHQXufhp3IFMLEIX JEA8v8YjESqe0vQXJ2/2CX3+QzTUChU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-gxeSVSXmOu-Q2uXGpHH9Eg-1; Thu, 17 Jul 2025 07:56:55 -0400 X-MC-Unique: gxeSVSXmOu-Q2uXGpHH9Eg-1 X-Mimecast-MFC-AGG-ID: gxeSVSXmOu-Q2uXGpHH9Eg_1752753414 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-455f7b86aeeso3998695e9.0 for ; Thu, 17 Jul 2025 04:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752753414; x=1753358214; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Q713kcTrVcU55478GZKOwac+Tj8dXDvZNDRg6hJ9+Ck=; b=VvoXdaluA04TueOGyrP1ARnUsnI9O+EMXCReyWU/lp4x/zuBNZADcLqoAmtrO2rM2F LLsp9F4jRqcxAAZcchqxG4lqKT9B03APPNfgv7FzHbWPYbsOAPPnFgSgxm7l9GkcIUum OGho3QyhwqmBED2UAhiqHmBQiIrn5GkY2RXMRZj5DSwI0QXSK4DlHjteXyqgeL3P8Hco efXkRdQJID2h1wBcaJiVWLqh0HwKqr8JhQQjAnD4rfdpNEGOZy0sKEMOUwov3kIvuhyl Bd2Kc3fyFHH15L1MEwdy9lid64dBCiB6/hbkkHcNilgMsC4NlEy3akraWmR/UOBdjdC6 3Z/g== X-Forwarded-Encrypted: i=1; AJvYcCX1RXVusJE9wOxBkn6vwlf/erStL0P8jNiNSb8JYBTIGtWYX3bzEXIK312PCOhwFkbWXbqw0HpicA==@kvack.org X-Gm-Message-State: AOJu0YzWe2/LwyvIU/pyHkpLHS6440d6Yt4itv9D1e0F8DavhK/vYGbL vZeQC3pBsu8PcFCXbR29zfnyHqbyyoS15PYcYuu69DWpeVhPVe3exjHS7XMyqycHP5HTSwzX67o r5hZ6dVnLfqq4y+qMEdqglI8R+y/UavD46Axg7mc1Kfopm7oJku+IIuq4R4Sq4h0= X-Gm-Gg: ASbGncvGFB+a1WV8ucJ74CdCCAEmpisWzdA+6EOpZKff+SM+JcMd4H2Un5g4e4WAAwC louikrXal+hCXbDRAbgcPuJK+z04BEjWWyBlr8ES27YEptCcDwex+2wa1Qqkel6NF8/yLJV0tcH nysOa+npHXttILNHrnShfgrj66B7FMONPpeEa/+q+H6b+MOW2ibkR5xQG2+9OtmzFD4/E18WJrZ 2iLtQ6qddChLAgXwYu0gCSirHjpJlAZkl3MtXSlRgRNb8BxWZYQGp3bwoqpiJU1rO9TsQinqzBU 1Dfus0iiHZKP03BdDqFz548gL9jL/uAvUY1eLOEAT5ZODL/GVScoWQCLARFSTRIlI6OgUPd7ZmK SO1rwHCSBtg0anteil3mW8S8UCUs5Oyq67w+0bevaUR6EcKfgc2wG4t7It1m1EeeW X-Received: by 2002:a05:600c:3e0e:b0:456:2ce8:b341 with SMTP id 5b1f17b1804b1-4562f88ae8fmr62858445e9.17.1752753414211; Thu, 17 Jul 2025 04:56:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGSpcNMOT/yMMIncsv1OPpXAi1SYa8RH+5FMu5CBuUN9a/nWylAzky5ICEfGDEOIiImFgCTg== X-Received: by 2002:a05:600c:3e0e:b0:456:2ce8:b341 with SMTP id 5b1f17b1804b1-4562f88ae8fmr62858145e9.17.1752753413794; Thu, 17 Jul 2025 04:56:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e803cb3sm48380665e9.14.2025.07.17.04.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 04:56:53 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 13:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] selftests/mm: put general ksm operation into vm_util To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-3-richard.weiyang@gmail.com> <5cadce02-cd80-4aa2-a078-6335beeb8a92@redhat.com> <20250717024504.3b4q3i6uuzd4nr2w@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250717024504.3b4q3i6uuzd4nr2w@master> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: htTYeEYc1_hs5Q6OZpaA7vJeq4tupHj58LPk1qYTX5w_1752753414 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 472D4180013 X-Stat-Signature: w51u8xaohnbnwa9y1eih6t8i9uwcw3qa X-Rspam-User: X-HE-Tag: 1752753417-706976 X-HE-Meta: U2FsdGVkX1/CpTawBbw33uAlG0iR0IOMb2FKvdIZcDqXevEqvcMoKe5NyJciYTy9YG5mbPb1sATjA35cVnPmm/VXHhgMEQRXn+aZCfFe+ShsstClUo3d3etBvx+3q2bX5YGpB3n0f7EqqTUDNJfo+41PFRN0F95PAu3QrawfognzFbeEhYYhtYbRdJ4ckI34x7VWcseWuc4yrBaIZkIyv8EKWuIeX2bsu/b9A1qAGeVyLzAascCpUvlBSQjJg9gqEtq3auXTfdMiyg5cQvmO841hcLoLpRzYG/yU2Wd4zhTFdflpFWH3uhEfC/L6KydafOktwI9G/IbuhjxtvG9/o5L+OJDH/Mb446iRugvO5Zt5u9nMRVNbag9T4qAyjnYn8H3Kcc1wncOmo9ghSmJ3UdJFUBbrCPPDKe9no0pmSsUfUkR7x7OgF9aeSKh9cXOx3Lempz6wrNUy4YZIOcobS1WAjn4HbReXvTHTDChHgDcUmzL1cQL1GF5Iw1i3IxAEaS3wFJxRsM/dQ9m+jR8zSHX2gc66fGfgmc5NjMMLZFhjnqagUbuO29sXeJQE4pQ/sJ1ITVaosDo9OVqBCZ9YNqBAP/SKldOtOiQZ/X630YNZ8JHRW6OZAwZPLl0A8nwnNFrh9beG/Kf1U+eocJvzTKizxpnAZB7KJ/jArsUKuZ0za2NFYyDppqPQtZBBeImB42YU2tKhG43QnTQDtF+dyr/qgqh+JkNjRK/O24OgNVUVci7Zto0JJPf1+xiv295Uq416mygt0MZgQ+Ak5MbApPlA1Z3eIj3qa+kJ/kn+9os8UX4y08dFrFTKJZGG+Du/Yx6qX7mPyYCZ+1AgBq5O/y2gBSfCdtgioQu1liSDZo7CahGM9ysdQvAbpfLECI+fz4JTnVOYj9BfdbxCLHbz89GWu9XSgRm68L/KciTDRYpOF/EfbTgd0OQ5thKMuq0To4dXOBsxLKOY97NbSwx C0EoiNAV k9csnzVhtJHfTW+CbwUP18TUYnOUUsmSuFvsIF5fBQsnnwKJ9u9+hSgqagTZ+CKg2y2WXSvyB4to9NuFB4hfaoZao2oXzyRmWaxD1eR3nQD9kXXeCBsXvkfw4VJ1aksVZ2rT4Bhz9t4QOXWibS830mrd/bA9CPK0UFfiH7pnjlh3GAG2txVs2PwY333aMsF1vzQEybV3htn4UeJ06VmIhznyCVTvWt1Y0y8NqTpBJisLLh8fttbs9/fC9TXWh9UEIxz8/HHsIsUKIQW/onLlbEDGF3Hrp5AoC/nSmT+7jXt21+Wn739nfef5b/jyIJ7zb0mWz4GEwg4bCDHryXUYFxgbC6iZYLK/M/1mx6fx6oqS3O7cYAxCiw+Y45q0COzUkJWKaxwkhGmqBU+WSzAyQts38ng+jrG+I5eMG+HkeszrI19E8o2E50dMs+z3meF7ax5iut1DURLxkg37yVbI+FL7SHBRdgbSdHvWBzHhsMzAnUvy4Hu7HKdEPb1tFq5ZXf7kr7eiQJyBNAw621EiORtz2jZzr6/KOfJleLXhmPGfEwmwVC3MwXtU/WzPldsmlys7Q6ayE3MGW2+o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > My plan is there are two pairs of helper: > > ksm_merge() <-> ksm_unmerge() > ksm_start_and_merge() <-> ksm_stop_and_unmerge() > >> Probably we should just use ksm_stop_and_unmerge() and remove ksm_unmerge(). >> > > Looks reasonable, will remove it. > > So how about leave three helpers: > > ksm_merge() > ksm_start() > ksm_stop_and_unmerge() > > Would this be better? Is there utility for separating ksm_start() and ksm_merge() in current code and with what you are intending to do? >>> + >>> +int ksm_stop_and_unmerge() >>> +{ >>> + int ksm_fd; >>> + ssize_t ret; >>> + >>> + ksm_fd = open("/sys/kernel/mm/ksm/run", O_RDWR); >>> + if (ksm_fd < 0) >>> + return -1; >>> + >>> + ret = write(ksm_fd, "2", 1); >>> + close(ksm_fd); >>> + return ret == 1 ? 0 : ret; >> >> double space >> > > Shame on me :-( Not the end of the world ;) -- Cheers, David / dhildenb