linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: [PATCH v3 03/10] Add additional isolation mode
Date: Tue,  7 Jun 2011 23:38:16 +0900	[thread overview]
Message-ID: <b72a86ed33c693aeccac0dba3fba8c13145106ab.1307455422.git.minchan.kim@gmail.com> (raw)
In-Reply-To: <cover.1307455422.git.minchan.kim@gmail.com>
In-Reply-To: <cover.1307455422.git.minchan.kim@gmail.com>

There are some places to isolate lru page and I believe
users of isolate_lru_page will be growing.
The purpose of them is each different so part of isolated pages
should put back to LRU, again.

The problem is when we put back the page into LRU,
we lose LRU ordering and the page is inserted at head of LRU list.
It makes unnecessary LRU churning so that vm can evict working set pages
rather than idle pages.

This patch adds new modes when we isolate page in LRU so we don't isolate pages
if we can't handle it. It could reduce LRU churning.

This patch doesn't change old behavior. It's just used by next patches.

Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 include/linux/swap.h |    2 ++
 mm/vmscan.c          |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/include/linux/swap.h b/include/linux/swap.h
index 48d50e6..731f5dd 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -248,6 +248,8 @@ enum ISOLATE_MODE {
 	ISOLATE_NONE,
 	ISOLATE_INACTIVE = 1,	/* Isolate inactive pages */
 	ISOLATE_ACTIVE = 2,	/* Isolate active pages */
+	ISOLATE_CLEAN = 8,      /* Isolate clean file */
+	ISOLATE_UNMAPPED = 16,  /* Isolate unmapped file */
 };
 
 /* linux/mm/vmscan.c */
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 4cbe114..26aa627 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -990,6 +990,12 @@ int __isolate_lru_page(struct page *page, enum ISOLATE_MODE mode, int file)
 
 	ret = -EBUSY;
 
+	if (mode & ISOLATE_CLEAN && (PageDirty(page) || PageWriteback(page)))
+		return ret;
+
+	if (mode & ISOLATE_UNMAPPED && page_mapped(page))
+		return ret;
+
 	if (likely(get_page_unless_zero(page))) {
 		/*
 		 * Be careful not to clear PageLRU until after we're
-- 
1.7.0.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-06-07 14:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 14:38 [PATCH v3 00/10] Prevent LRU churning Minchan Kim
2011-06-07 14:38 ` [PATCH v3 01/10] compaction: trivial clean up acct_isolated Minchan Kim
2011-06-09 13:33   ` Mel Gorman
2011-06-09 14:41     ` Minchan Kim
2011-06-09 14:47       ` Mel Gorman
2011-06-10  8:19   ` KOSAKI Motohiro
2011-06-12 14:24   ` Michal Hocko
2011-06-13 14:48     ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 02/10] Change isolate mode from int type to enum type Minchan Kim
2011-06-09 13:51   ` Mel Gorman
2011-06-09 14:56     ` Minchan Kim
2011-06-07 14:38 ` Minchan Kim [this message]
2011-06-09 13:59   ` [PATCH v3 03/10] Add additional isolation mode Mel Gorman
2011-06-09 15:00     ` Minchan Kim
2011-06-12 14:45   ` Michal Hocko
2011-06-13 14:54     ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 04/10] compaction: make isolate_lru_page with filter aware Minchan Kim
2011-06-09 14:03   ` Mel Gorman
2011-06-12 14:49   ` Michal Hocko
2011-06-07 14:38 ` [PATCH v3 05/10] vmscan: " Minchan Kim
2011-06-09 14:04   ` Mel Gorman
2011-06-09 15:02     ` Minchan Kim
2011-06-12 14:55   ` Michal Hocko
2011-06-13  1:04   ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 06/10] In order putback lru core Minchan Kim
2011-06-09 14:27   ` Mel Gorman
2011-06-09 15:15     ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 07/10] migration: clean up unmap_and_move Minchan Kim
2011-06-13  1:34   ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 08/10] migration: make in-order-putback aware Minchan Kim
2011-06-07 14:38 ` [PATCH v3 09/10] compaction: make compaction use in-order putback Minchan Kim
2011-06-07 14:38 ` [PATCH v3 10/10] add inorder-lru tracepoints for just measurement Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72a86ed33c693aeccac0dba3fba8c13145106ab.1307455422.git.minchan.kim@gmail.com \
    --to=minchan.kim@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).