From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A75C52D7C for ; Fri, 9 Aug 2024 16:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9BC66B00AC; Fri, 9 Aug 2024 12:35:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4B5F6B00AE; Fri, 9 Aug 2024 12:35:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C4CC6B00AF; Fri, 9 Aug 2024 12:35:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7C9EA6B00AC for ; Fri, 9 Aug 2024 12:35:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1FD28140FA7 for ; Fri, 9 Aug 2024 16:35:09 +0000 (UTC) X-FDA: 82433256738.28.FAAF89F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 4EC4B1C000B for ; Fri, 9 Aug 2024 16:35:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WAA3IBXR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723221251; a=rsa-sha256; cv=none; b=uvzyQOzPG+Bt6ZiYEHvcXO8FEoKX5xs7b08a24j+qBMHeDcZdKnz1g3G0kTO0RzX+n48ar y5Z8g5o+gdinAC2l6hle+o7ucKcDW4BbY1oG6pFhDT9Y4NN6glddGCCGsGpNudlH5XD/sF abK00XoGq3wnmaBHq5bCVPHRsjxp+N4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WAA3IBXR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723221251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FYhELWK2NszWgjvOtZarLiZNjUr2Rqg7Aan/+nzPXhQ=; b=6YOAR1GhLAupHs/Zl0NF4Iw0OpeEves0CrwucWktTHFvKiVL9B1P3nYnMMtm4bb9pAdrmJ IkGqinWIKCNzbS8MczuefYhFQ84tjbx7saxg24TXMdcuEFQcygNeIZqUMO1yjW4AozCJH5 xGHpqP0tFmkociMdeTa6OOraII8a7Tw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723221304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FYhELWK2NszWgjvOtZarLiZNjUr2Rqg7Aan/+nzPXhQ=; b=WAA3IBXR12xQTFULpvHwjuzISlvDifADCJYG/gWy/za4IgoQdTd35NCsTvhK891WxJXOTI GYs/t64BKWwNhM/8Wlc+qwQa9YzyHK/TqcryPqshS3eZue468K53ppnhuL/9ilHDa1pzSG kGAradiRna9D9Ro0r9thBz0KJOs9mjc= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-QGJdZPoJOLGsNI5oMq_LmA-1; Fri, 09 Aug 2024 12:34:59 -0400 X-MC-Unique: QGJdZPoJOLGsNI5oMq_LmA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ef2018bb2dso23398841fa.0 for ; Fri, 09 Aug 2024 09:34:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723221298; x=1723826098; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FYhELWK2NszWgjvOtZarLiZNjUr2Rqg7Aan/+nzPXhQ=; b=fLxDJHliR6aNtZCTRb0tXNg4aGlBQwHReNTKf4AxZTdB4LeTUAJlldHGcQDh0hUwNT wRPUNsjpL6yhaUO6KZXFMwQQR3DyLm8QEZpBboWDUuS5Er5uqLIFHUaQ4PQzr8j82iSj 04zIkf2LtUD94Snuh25QVwQIKEzI00IzLypffubEG1YLnhQobj0ZtsEJ7T/+C1ApBtsT NQnC70LlbcIaGUk/HEex5Mv7vRYfV/UMvC2lSuUN/LMwloYeb2m3NQ7G2YC4sLkLbhV9 wNYJF+HA1qfgfrnXmVOPTJ3/ptKD3CxvR+lRY898oTnbxd6L0R3+160AVv+Q7LVSzOHr D2kw== X-Forwarded-Encrypted: i=1; AJvYcCUoaUIdMocw9NNcGz+fHeJLRMEFXGomcf08ciTkf9L0JxmCYKXf8N/tLsecJLzIwXZ30A5Jvr+tFoxmEtNEezexGx8= X-Gm-Message-State: AOJu0YzEx6cKNXz6kBdfMOEgte6hGtv4F91tSDPmjQdRridCdfm/S3fc 6ZGu5M9jARl4RuELC/LsJb2OjADnbXrv1wGc5km6LYUvl6kR9CKmujx1gX06TtMptw6TSEgPnxT CTqcw3rZopkCD1Vuv6g0PNWXRKpz2BRb9yKLFdbf0kV9zSpoo X-Received: by 2002:a05:651c:543:b0:2ef:22ef:a24e with SMTP id 38308e7fff4ca-2f1a6d021acmr19154221fa.10.1723221298370; Fri, 09 Aug 2024 09:34:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXWH42bCHjyK57IZI2qpxoxwMfVNosteypxQpvfsXkae1B7hvkEnyUY+Oo/OAtp5Bz9ZbtBg== X-Received: by 2002:a05:651c:543:b0:2ef:22ef:a24e with SMTP id 38308e7fff4ca-2f1a6d021acmr19154031fa.10.1723221297806; Fri, 09 Aug 2024 09:34:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d2716caadsm5733049f8f.39.2024.08.09.09.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 09:34:56 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 18:34:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/19] mm: Drop is_huge_zero_pud() To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Axel Rasmussen , linux-arm-kernel@lists.infradead.org, x86@kernel.org, Will Deacon , Gavin Shan , Paolo Bonzini , Zi Yan , Andrew Morton , Catalin Marinas , Ingo Molnar , Alistair Popple , Borislav Petkov , Thomas Gleixner , kvm@vger.kernel.org, Dave Hansen , Alex Williamson , Yan Zhao , Matthew Wilcox , "Aneesh Kumar K . V" References: <20240809160909.1023470-1-peterx@redhat.com> <20240809160909.1023470-3-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240809160909.1023470-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4EC4B1C000B X-Stat-Signature: 593ki4w4c6fqyho7xiz8qazuiajw7jtn X-Rspam-User: X-HE-Tag: 1723221305-228990 X-HE-Meta: U2FsdGVkX1/yQ/39MkaX4zIIOOwNiz7AHfIue6Mdgzvd+Xsk7TaQQrS8XyqsMqaKRxZ+SktOryXYsimW9AfGZ6s2vWPIFL3stiIqT6lCfXZnq9N+kfoadtNZltme3mXHl9iRTk4TY0RfRVoTHCePPwx1WZVw/BENptBr/+st3VRbB3dzfzMuLt+R45xmdfVKh0VhzExYPpahkskzHrkKA66k6swrzFXd2TwDCpNhMm3Dn00sge3X7qAnDuJ1jRCk58fziHQMItD4H7Vkhc9rK0cGGtrEHfQUW/McBCuS6wzqvU6o7XC0ollsGmVZ0Nh9YwNNdb7Q24Sw1O+Qf7GT9MKRlN3lC+tOq2G6oC5299cEpVEtEIHpp1ArmByEXev+WnG8ASkxhDve/qT4l1nU4lVm+Cks0UgkgvMHvwIPBOaWTAWQ2ru6NApjQhSqBTWTN8MODC8KlDblYiK6AVgcMEDzbRO54NR6JldUdg6hbJuls+3KaQqG4wUNMjQ/N0qLLTHGoNL4xEGb4kH8OeVNkR8fyMyQuXN6DBuMfG0pfDzCtWnoWAhgan0MShE8J34TEwtVhZu046LtDpDkFR4hIgya9UdmxbnxoWqbMbm+o1ijmEmTG1tdmBl9yrlFERURyu3qx4yEbenl98gqWyuNPMR9Kt8Tgfa8StaQzfGRHSSxYWbV73B7j0JZNyZIkx2LZWE/sMx3qYVw5+xwYW1EgONRe8C7rRWwPGvyl0Q1ex+KPyI8kYHUUsVulCupiPJwEbeUkrLNsmYglabkOHdwn3UJntTVaL0dxLmN2Yic7FLj5FUjOssRGFe23fv7Yky+cf9nrnn6Itu+bcvTPMHwMkS1zU5JjHhEGw75W84lKb+u75Z35DyFDKgjSBlLB9VDhOVdnfhvlWH35FDPqKKz/uk0dAC8nIMoD1QWK1kUegIJY/J2XktRJEatxfriA4WWUHww3NhfYAUWIrSTolo uhD+/NVn YYdhXoqL+CcOOmj1hnuRU8rUNIwJKsj8biWlpc/gOmP6SmABm83aa0XH1+4eZwk1IhFLMmlvpjk9vR4qaylIOskUZdYAJ8pvHeFosXeHU/wgGdaz7icuf7i9szK34K/f210MIZQp+SBrrADuEUIJt90q/8HAadw1g7RV8DomXQKDxvGqlzMh/Jgg2tEFTf7mFg7KRn4o7JeQnLUJ3nkbA3TXOxJQdhowE/Wt+DtbbBdaBXU40/XkhptvK0mbHEBZni2yCGJVf0THbBWjGjl1dZyykNxUctN7kq3RQODz/0We3fLORIV/mCXiRw1jTJcOzBXAUBh/X6RNI0jNWQlY/bG0eUQ0kFH3aiX6QcHF0hrMHMLM82P8M8jvH4S989/ThwOtKLpx+4mss4q08Txxc6crPmHTTHvRqitakieqyANyIh4JOItEo2Hs0PaqYwmJ0OOtN/dhpsqycOmfxgbpxFkPbcaiAiEcA1d5e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 18:08, Peter Xu wrote: > It constantly returns false since 2017. One assertion is added in 2019 but > it should never have triggered, IOW it means what is checked should be > asserted instead. > > If it didn't exist for 7 years maybe it's good idea to remove it and only > add it when it comes. > > Cc: Matthew Wilcox > Cc: Aneesh Kumar K.V > Signed-off-by: Peter Xu > --- Out with it Acked-by: David Hildenbrand -- Cheers, David / dhildenb