From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711BBC54E58 for ; Mon, 18 Mar 2024 10:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 077946B008A; Mon, 18 Mar 2024 06:02:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0279C6B008C; Mon, 18 Mar 2024 06:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0A386B0092; Mon, 18 Mar 2024 06:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D0E566B008A for ; Mon, 18 Mar 2024 06:02:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA523C0DD1 for ; Mon, 18 Mar 2024 10:02:47 +0000 (UTC) X-FDA: 81909720774.19.6323A10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id F2C8F1C002B for ; Mon, 18 Mar 2024 10:02:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGJnAtkI; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710756165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+31X8Ytz3OwzmlxhlwOLx4ZRoR3tqXflabXQ06eudU=; b=Ia8vZGLP1IPGe4ArgDDisEh3bxYNptGHbOYm7HFls07X80r/9G19AZLWFP+zJ3+k3INS2j /sr0sFOK98e156eCSlVAuQte8GJmo4LC8oxoBBQRchV3b251frcCSulDSlhkpzuN1UG7fy iLIG3oGwwfp+wMELe4bcZyyNXoYJvFo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGJnAtkI; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710756165; a=rsa-sha256; cv=none; b=C82fOm9pcf6z290oqtrgM66B+sh6K4a/KApVWDS/8qVKRybMGy8tYiuC8B2P61YvvKVHUL CzcrVZLfqibwQf+p0g/bCASRTNAM7cTe88T+qbK0q4L2bckja26fEGDRzm4ZWWDM0JoQ5B uJSwQ5cOi1Fpe9D8vhPferFSgq04AwQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710756164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+31X8Ytz3OwzmlxhlwOLx4ZRoR3tqXflabXQ06eudU=; b=iGJnAtkIMJS1Dc3kK5YyNBci9WzfiYL7lsSvQhi0br3B4d5DFW6Njdu3glhBst7g1f7WaZ oNhkkvGgRCty/MecZrtCtkuH/pELoWj5Q3mWavff2o3gtIsQ1d9eP5/Gg8syy8UCRRWl0M 6mJAU68sK4xh3CtaC89dUg90cos3g64= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-JzNMP2-BOumeggSq5cN-PA-1; Mon, 18 Mar 2024 06:02:43 -0400 X-MC-Unique: JzNMP2-BOumeggSq5cN-PA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-414042da713so10641155e9.0 for ; Mon, 18 Mar 2024 03:02:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710756162; x=1711360962; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i+31X8Ytz3OwzmlxhlwOLx4ZRoR3tqXflabXQ06eudU=; b=Pm8gphSj6hzwMYlPso3p6vtrOXztcUyo803PqMtUNTevnNYr7pT6md6KwIj6xcce5O fGwxbjU5DRT+yQ4WTXa02pucLXTwgFEADY9bcacGp6W6BKQvw3D0ZGLXxHKm6wPp6wi3 q4feL0RDhrNtkODjCZoYuofHAiR2nHsUmtJQAoO6Yy5S9LS9FIi2+w0jbv3h/thHNLlP CQLAdumhd50YiHvDFw8IQk+JzCZQRwMN5Qh6b7rZpF1JZPyeYEDtp+44pjYXEcCrN8WQ fqPUWsc+0U5pn231Gju2C4TAc6Sou7sWujvl6ISm6xC0TDdbSTPCGisUCJPRVYL/goU7 w6Og== X-Forwarded-Encrypted: i=1; AJvYcCX5rWAqXOqdg5v/6j6weZgyibHW5C/Gu8ElmaRFpjGJrHNZ1nVfF0zXZvgUjM1ut/I0PdKd0Rs3iIQVdPsaNbKf7qk= X-Gm-Message-State: AOJu0Yz8kj3dkdmvfllZAj9HchxKkwIoGMbjn2qjbAOTH+7wIzglDQkw d5CRHyehD595MqUxdw/8r5zecrnGAUwqa+ksq34t3uW2WgVcZsobzNNJFRqHBvtJt63v85/8CuD aHZvB9b/Z1NVAQvisBVj4fodI7X2d++WIwoxhFz/yL/3VRpn1 X-Received: by 2002:a05:600c:444c:b0:414:12ef:83a9 with SMTP id v12-20020a05600c444c00b0041412ef83a9mr940086wmn.20.1710756161920; Mon, 18 Mar 2024 03:02:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQYOGxJB/CV+mFNG8uE93IvPkEoL7pVcQIg3RAdxLAWY2djf+MU0C9QMvFDPCb15losXY+xg== X-Received: by 2002:a05:600c:444c:b0:414:12ef:83a9 with SMTP id v12-20020a05600c444c00b0041412ef83a9mr940057wmn.20.1710756161466; Mon, 18 Mar 2024 03:02:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1f00:94ff:246b:30d0:686b? (p200300cbc7371f0094ff246b30d0686b.dip0.t-ipconnect.de. [2003:cb:c737:1f00:94ff:246b:30d0:686b]) by smtp.gmail.com with ESMTPSA id dw11-20020a0560000dcb00b0033b66c2d61esm9375131wrb.48.2024.03.18.03.02.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 03:02:41 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 11:02:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix build with _FORTIFY_SOURCE To: Vitaly Chikunov , Andrew Morton , Keith Busch , Yang Shi , Zi Yan , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrea Arcangeli , Nadav Amit , Shuah Khan References: <20240318023445.3192922-1-vt@altlinux.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240318023445.3192922-1-vt@altlinux.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F2C8F1C002B X-Rspam-User: X-Stat-Signature: o1p11ociotte6hf9de898ckt5nbn3isr X-Rspamd-Server: rspam01 X-HE-Tag: 1710756164-289022 X-HE-Meta: U2FsdGVkX18SInHtzVPAkFr5jCduRn77AJ1OlWtQWCAN0jFhoyx7n8ft9J/U3NE00+jNZX33L0qkXjOaoMFgsHos4JQ7n3OHjobsIbGvFR6EMUqT2tBQSnC0ahW8/pXEJZoXYuZlgdn+1UX8CIneC9P7RXet+xtPB7O8FBeNDoyK/3eVF8b1t8mUB4T/xc30uDKLbBs4QWDBCJiQtHnpoxEzWVIYDaeH+WXSSh3/Yvcl43b5eGhJI1IDY84GkZxQf0Wor0zy4yBL9u+JTIk6v1qWqEw16dT2yEogIOzZEwzartLuv9UbXStwZHY/UqB8LKFjgcPFudMvGjCa9FgAj18cgxiIG9UYEKhkMPTbkgn3A+M0I6NE3D/NddmOMwHfsedOpxpTGpFHkMNHjBu+pV3UI8G8ECloU5VH8HFH5ZXiHVYOnV4db9eI1/zzEwHXgJLg1C0CT81Xu16oY2asCa1P7RM+U8FP062SpTlbz14shFQmFQXfSBO/Oh6hXvKNz+1esnxhrpJSfCdNMl2UM5Uq/swmVhyilWHzmAyS10eC75U81y1Bnicp+8da6naZIyYiDknruv62uCceTN1KuFCS1xrF0u2WvbvPZfSrv69LfrBlWV/yluZ/2aFro+QFyS3V57u+IxmA5Z8DyVSeSySln4TB2ni94O69LgtCeUu83vYhNXfNR3XC3wC4f2h0h3MZU2DcLcNtkBRSnXbOFcuwdCU0kUafTWpqzmbJ0B2u6k/m9LjvL2sijWgHyrdrec2+WialsGlhLCiD+JkhPB55/NwIRtYQtEagUlFaTFyRIOxCRuzmfgAPN7sPvQF0au0HunuzxSTxwWXRyjZuHXUjEJuC37b04SNBBJdQrFCFxrqvGVsoYx0IrpzIZpAsXBszMUPD5znMiEQlpSSY5Sb3oU+AylLloAVOrx3Ghqs9RxzVgx/U6bz0sCLHJvcf51JTSEyDNSENL7tuSbK DchtB8JI NoTsQQhotI3vbskNZuEK9pRIOTp9tCV1XytBrxfO73xHrHIumQ2kXw4s7oO6cl745YvwFFb4406PxTVII3k+AWWQm57ZzQ7OmGZIsJIXTWE9zT0yUOeUpy/w2qhEHfFvqp3KhQxU8ZnwrZlLsPnBn/aiQuDHbukPBq2MXsXEC0Q+ITcBYpmoR/EXwR3Rc+WWqbjL4jsDY1uJ+4GmFjBVlF7UvJN/hrNUUufZBdB+z7yXyiqDLfp2JDMh8VvWo1S9Wz5BPZoSlbo+jXq6jOnso0c9UUCVhW6JpLH8tFALabH4eaByiJq0pjDKK7kT93yRtQAMNS4Z0mrmj/A09GJBBpQTKUg1Za3rVlPD9C/9ii1dzqX0mHWOTHPH/mCXh7XyNJZLubC1EXFxCHlnX5w5GaFMgZxpg3Wnb3TeLEoVrXgUFAJs6h5itJbdO0R+5iA5tM24eNDEEiDaSgDudtji2VEeE01Lw2Rij87bwh3mS/q9f8ddMKsdAkFMOFnhfPSbefDWGDFSY27uCHoYg0/npg7vnZKSydZQSTQqVTbDCVGyM3QUynEjoJI6aehV0PZDRp4eaAEKMIJHs8zODSZoFW7+E70hjmTMstjZOngD306NPf+T80mCkfvqdkvbsO65pL0F/XnQpdjifgkXNzI1O/Cg0ZltpM9G4HFPl+BBjqrFF7idgqA+XUd31vLYBUDnoMvj4PEYLE4yuAzJxA/DrwsjVXY0TVhcm5b+Xj876VnxKFlVHCjfWNqbZGxQtQl1OiLatjWSt6B2lFU0sfQoEEiowpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.03.24 03:34, Vitaly Chikunov wrote: > Add missing flags argument to open(2) call with O_CREAT. > > Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid > value) (together with -O), resulting in similar error messages such as: > > In file included from /usr/include/fcntl.h:342, > from gup_test.c:1: > In function 'open', > inlined from 'main' at gup_test.c:206:10: > /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments > 50 | __open_missing_mode (); > | ^~~~~~~~~~~~~~~~~~~~~~ > > _FORTIFY_SOURCE is enabled by default in some distributions, so the > tests are not built by default and are skipped. > > open(2) man-page warns about missing flags argument: "if it is not > supplied, some arbitrary bytes from the stack will be applied as the > file mode." > > Fixes: aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file") > Fixes: fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split") > Fixes: c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect") > Cc: Keith Busch > Cc: Zi Yan > Cc: Peter Xu > Cc: Yang Shi > Cc: Andrea Arcangeli > Cc: Nadav Amit > Cc: David Hildenbrand > Cc: Andrew Morton > Signed-off-by: Vitaly Chikunov > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb