From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C3BCCFA13 for ; Thu, 26 Sep 2024 08:47:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B5036B00AB; Thu, 26 Sep 2024 04:47:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 464EA6B00AD; Thu, 26 Sep 2024 04:47:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE986B00B1; Thu, 26 Sep 2024 04:47:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 09E0D6B00AB for ; Thu, 26 Sep 2024 04:47:03 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A7414ABE28 for ; Thu, 26 Sep 2024 08:47:02 +0000 (UTC) X-FDA: 82606259484.24.B918FF5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 44556C000B for ; Thu, 26 Sep 2024 08:47:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li3Yxfk3; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727340300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dcdT+Y+JTqgEdFx8AuCpVRjLlJoZMsxN/9BPx+44vCo=; b=3zS2IMDDekD5oPrC7x25wxQJQrGu5jkGKIpc+lhoOUplrm84VWWIQKFgDV5thcZkOmV6aZ tOvRwm2gayaVI7fscx9+OE43lj6TWf8ozYSTZnx2q6LRp2ot1A0bDnDguJH2nMC65ACnju rqfwIP36XP0laXbXjmpv0aFV8L1ChQQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727340300; a=rsa-sha256; cv=none; b=N89TDVZihFLuKztezMKEKVb6wlJr85gNP3ik1s9yHkBXx8/nQ+k2aBX9RdBYcyDniyaxqj Ax6FVW1duCE4f1MVwN1IdYQ/7liroeoeh7UpjWnofc5jrwwEuvsrA7yq6xW48bB9PIaJ7y HiOGsiiqMZIPdYph9iwpInURcO4KoPw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li3Yxfk3; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727340419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dcdT+Y+JTqgEdFx8AuCpVRjLlJoZMsxN/9BPx+44vCo=; b=Li3Yxfk3MA/E/e1BMcBZBXZyzjik/5TMFM8wEY/BkDbWA7RpIGQrvcYMYnbW6aKBxU5bpI QcEaHco1EKoLyF2AXjyeRx2Ysk/TGC6iI6EyUq0B2GBn8ZnBKT/aR+18aaS/SmCSeJ9WtQ V1C5sKQsoXAhZzWnBBi0G95l8Lshj/s= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-fiFeTvKfNReGp7SKZ3cl8A-1; Thu, 26 Sep 2024 04:46:56 -0400 X-MC-Unique: fiFeTvKfNReGp7SKZ3cl8A-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37ccd7c3080so285781f8f.3 for ; Thu, 26 Sep 2024 01:46:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727340415; x=1727945215; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dcdT+Y+JTqgEdFx8AuCpVRjLlJoZMsxN/9BPx+44vCo=; b=r9+wKtInL6rDiF2Gd6+ilkZU84yxVRsXkcdSr7QgB13m2gFxO8zvcYtdX65p4R4ny5 YLvKWjx22PJzzjuEs6sq9on0FJlOXTUTSMhX09HdulWcO+bZxqPUbOPbT0hJ8hUdwe19 q3j71kBynocxbfK9ldy7ydlXUXFzfaN6yP2rA++1VY3ga+QKI9IwIE+EMXuCnPKHZDmy OxGzVxB2tXWYIk23BHd2tapBn050rxKocwTkiEMoPgfjCj5luwBO765PO0YD81bp5LLU 4sA8VwwIqR2J4605kRKoRr0FCrxDeLX1g8rFNQZlc9wG9zv7q5+luMYEgLs6NHhdCqjb /ulg== X-Forwarded-Encrypted: i=1; AJvYcCVUWO1AD+m4lsLgNzubVITx6rdcjup4+pT2GWgX25LAp+nNnul8E89TV36TcVtqaY1GqK/yE6wH8Q==@kvack.org X-Gm-Message-State: AOJu0Yz09/Ict77K1wDTxyfBpkEJa+Q5sJ+IGmpso1NqaS3WEalllowx TqtMphaACcHMgaV8cEgON7qiJqBXbaw3PoaQnLfWGIrORQ4Es0Wu+N1Aqwe4myS1Oh4fRBP8rUi Q3HxoFWkOx7kYzDwzxiUnSsWNdnhOMXy3dENjFBJUTzD1j/XP X-Received: by 2002:a5d:4642:0:b0:374:c07c:a49 with SMTP id ffacd0b85a97d-37cc248b745mr3395761f8f.28.1727340414659; Thu, 26 Sep 2024 01:46:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8YDSVOdNq1/t7E3SyZWe5lFPiCsLTZcolGEYAEKQa215yfM+Vw1+QC4KOFxSiwJu3877rJg== X-Received: by 2002:a5d:4642:0:b0:374:c07c:a49 with SMTP id ffacd0b85a97d-37cc248b745mr3395735f8f.28.1727340414264; Thu, 26 Sep 2024 01:46:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c744:ac00:ef5c:b66d:1075:254a? (p200300cbc744ac00ef5cb66d1075254a.dip0.t-ipconnect.de. [2003:cb:c744:ac00:ef5c:b66d:1075:254a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969ffa22sm40374455e9.25.2024.09.26.01.46.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 01:46:53 -0700 (PDT) Message-ID: Date: Thu, 26 Sep 2024 10:46:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] [RFC] mm: Remove MAP_UNINITIALIZED support To: Arnd Bergmann , linux-mm@kvack.org Cc: Arnd Bergmann , "Jason A. Donenfeld" , Alexander Viro , Alexandre Torgue , Andreas Larsson , Andrew Morton , Ard Biesheuvel , Christian Brauner , Christoph Hellwig , Christophe Leroy , Damien Le Moal , Greg Ungerer , Helge Deller , Kees Cook , "Liam R . Howlett" , Lorenzo Stoakes , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Nicholas Piggin , Richard Henderson , Thomas Bogendoerfer , Vladimir Murzin , Vlastimil Babka , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org References: <20240925210615.2572360-1-arnd@kernel.org> <20240925210615.2572360-6-arnd@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240925210615.2572360-6-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 44556C000B X-Stat-Signature: kypin158qpd8jtq3jtfp35ojskhsr31u X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727340420-180107 X-HE-Meta: U2FsdGVkX1/FjrNetIOenEU31cKmJoXNeGuUl+BPbO3pQsOpyS5BOQXLijlCB+AJQ36TPM3MCAgsqLqzv5jcztDAuGcSbiquGc+Blzjg9tFt9adYBX7rrc89OxSfOdcqrXr7wWasjPsS2sK76TGvd2uJelEMXaJhNQ5QAr2Hmy+aKLfGVl+D6z+K2X9XMvL6BXfr+z8aOqQrLHGKDRx5E55ueFnv2FpdWDiv7HslgK23cZNqbXClwmVW2tfMEzEgWgFf1XL3FoTynC7U+WeBEyPj+BluwgfcVFOpBPYdhtcrVkv+Mo6KUwPp6ZX+ogBW2Cy9lH4spHsBZSk9ijpFFSOaepzCkXXZ7d2s0KIinzZu6H31HEo4I2S8YFr+tD6vgRyzf0lZYX4kJi2oNG+fZ/LHvdg6ZETcQDovDKpqmhct+/i3CMsfv2tfoV+P8JAObEPujOlw0rGZnV56fd7u+v34ydLkHqaWfKhNTr6uTFtXGCMHl5I7iJNoHslQ2d4pL59Whm8aA8xcRKiXzU2micjwM4fo+xQisQkHnRjPE+Pq2lRswEIxm91RDwXsQYe4JjD9R7U142MH5JKqRTMItrDxOMqm6wd3Jhyv+cBqOgqskSY87EcclNRnq6sa9Jh4DwEF50+kB9MPt2dgI6nNDjg/JObTzXwNdsM7n3jYowwdyRuagTiFkmbuAsmjXmjJX5AVEahsbNnl/CwdxJpc2F+eFkyNRdFH344NhLoEqKCiWIgvsbizR0jj9zPSwGMdkBCgCNaR77d4QM4ZrjzMSO+8fFXhUMnMnz5kvIXbcwXv2LbW2Zbap0WrwemRZ8Z4GoyDYAw9/pMt+aWjwvYXkkufNZPNU8V/HBSoVkNb3b8iBjHiTlQDjjBpBfKn0GajhtIQ6yXfYw+4wD5S1rrlSYdb0atQRlxsvUYDy8TRh9NeLohJCBbvJG8ybW1ZWfcpT2KG9Mh2ufaTMnU4Emy bVKK9uIy HvErqGpTnvTKDbbY1ov0SR5XfULbvBPgh66Z4IDvPBYKUvouHJkMxb2szSVgW8FHRYi7XzFk1CA+tNsMHgmrS5t+5hoesB3gmap8XDo4oswd2vKHgmi63l+sarOdu+LINaEyDb2OZEuedM2UXKgK9utaSHc9hOYraNKHvWKGK5gXjdyNnMFOErBf5+nXHJUXwEtWkw+YsN7kOWY7kbmkdWO6I+oKsctYMQ046i40yteEt6G6SEsZIWuwpXtj9rP6JI2SZZJ8sx6vmrEul2k703Tva9BazKXMIHE1kotwq1R7ErqWfnYjg9fz8F4JgyC2y4BnnURpEp0YDx122nFmgNnVA4YcArOTPVBJDePCokE95xb5d8faIIFp1DL6oNzApSNUy1ltnAqzfsfGaknfpwK/e8lZ7ifUhh7ZtcoVPi85yMSRB2lRhQOL3IcDRvAupt11e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.09.24 23:06, Arnd Bergmann wrote: > From: Arnd Bergmann > > MAP_UNINITIALIZED was added back in 2009 for NOMMU kernels, specifically > for blackfin, which is long gone. MAP_HUGE_SHIFT/MAP_HUGE_MASK were > added in 2012 for architectures supporting hugepages, which at the time > did not overlap with the ones supporting NOMMU. > > Adding the macro under an #ifdef was obviously a mistake, which > Christoph Hellwig tried to address by making it unconditionally defined > to 0x4000000 as part of the series to support RISC-V NOMMU kernels. At > this point linux/mman.h contained two conflicting definitions for bit 26, > though the two are still mutually exclusive at runtime in all supported > configurations. > > According to the commit 854e9ed09ded ("mm: support madvise(MADV_FREE)") > description, it was previously used internally by facebook, which > would have resulted in MAP_HUGE_1MB turning into MAP_HUGE_2MB > with MAP_UNINITIALIZED enabled, and every other page size implying > MAP_UNINITIALIZED. I assume there are no remaining out of tree users > on MMU-enabled kernels today. > > I do not see any sensible way to redefine the macros for the ABI in > a way avoids breaking something. The only ideas so far are: > > - do nothing, try to document the bug, hope for the best > > - remove the kernel implementation and redefine MAP_UNINITIALIZED to > zero in the header to silently turn it off for everyone. There are > few NOMMU users left, and the ones that do use NOMMU usually turn > off MMAP_ALLOW_UNINITIALIZED, as it still has the potential to cause > bugs and even security issues on systems with a memory protection > unit. > > - remove both the implementation and the macro to force a build > failure for anyone trying to use the feature. This way we can > see who complains and whether we need to put it back in some > form or change the userspace sources to no longer pass the flag. > The first, uncontroversial step could indeed be to make MAP_UNINITIALIZED a nop, but still leave the definitions in mman.h etc around. This is the same we did with MAP_DENYWRITE. There might be some weird user out there, and carelessly reusing the bit could result in trouble. (people might argue that they are not using it with MAP_HUGETLB, so it would work) Going forward and removing MAP_UNINITIALIZED is a bit more controversial, but maybe there really isn't any other user around. Software that is not getting recompiled cannot be really identified by letting it rest in -next only. My take would be to leave MAP_UNINITIALIZED in the headers in some form for documentation purposes. -- Cheers, David / dhildenb