From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F7CC001DC for ; Thu, 27 Jul 2023 09:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E9298D0001; Thu, 27 Jul 2023 05:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 871E76B0074; Thu, 27 Jul 2023 05:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C3D68D0001; Thu, 27 Jul 2023 05:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 597D06B0072 for ; Thu, 27 Jul 2023 05:32:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0FB50140425 for ; Thu, 27 Jul 2023 09:32:30 +0000 (UTC) X-FDA: 81056876460.24.C2463E1 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf12.hostedemail.com (Postfix) with ESMTP id B27584001F for ; Thu, 27 Jul 2023 09:32:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EWO8BEGu; spf=pass (imf12.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690450347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DjTokeIRr5Zr8YctEQ0ezEcbh9foSdA76GVK4ttK+7k=; b=M3h8xQp6p2+nj+EeOfH4GyutMZVvoK2dQg/BTkoFR/iQUdHQpDrrgiiInL7WWIw5631Szf hjN88q8BgCjN/krRDWfFIMCWkrMI052w1X7Ygl9Ph3RP6NVPpVwqCgq5L2DlyRtmL8l7vR 2Ltr6vRPmQkvtKkEsCaUSaMXyM2+S7c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EWO8BEGu; spf=pass (imf12.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690450347; a=rsa-sha256; cv=none; b=oBL1XIt4FWheIlT/zfFlmZ0rrIIJsLxvLXWvOpLZbiII2lZzusvFcpLTlgZzTtn5+1X7jO UztMksCXp6+SzGLhYUKdK/ifUTQ8sghUYnGo6Mh1VH2xzxW/TK70Nb3fNXiflf2x/yHGF0 fPiPz5jlnOgGGm8l2cgV9Djyqri+HDs= Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36R9DsDc013580; Thu, 27 Jul 2023 09:32:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=DjTokeIRr5Zr8YctEQ0ezEcbh9foSdA76GVK4ttK+7k=; b=EWO8BEGugv/jBO5l4WSeGlqsJ45C+QkQjpmdMlzSo7cMIPaqMH9WNpmU4yPBsG4OAdHA +/TL3jZO7efOxKsV+JUkFl6ssQya/8gFfNHXrmiMNWrc+eVO9qeObeRAIMvMcRc2DX/l 69vB5FzkljbHF7zVjPo7NRMJoUJ4tENRFBfkfflKPdVAddZW7oxJLY2/Wp+Hih7nrYrw N3NdhmhhxxAyy9LtwQNAu4/gLaElQphVZ+Ak3Wd1lWmlZ/SETrkS/pyk+f0GtPoyFQWc KquR/YPBa4zw7yT2bNCaRYQ9yDXK+kzCgGsEsbzW4gnGCj67Mk+YzPUJsq6g3BAOibO0 sw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s3nrvge1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:32:18 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36R9UI5H004440; Thu, 27 Jul 2023 09:32:18 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s3nrvge13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:32:18 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36R7IW26026200; Thu, 27 Jul 2023 09:32:17 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3s0sesctxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 09:32:17 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36R9WF1a62128530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jul 2023 09:32:15 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1F74120043; Thu, 27 Jul 2023 09:32:15 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 05A9920040; Thu, 27 Jul 2023 09:32:13 +0000 (GMT) Received: from [9.109.212.144] (unknown [9.109.212.144]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Jul 2023 09:32:12 +0000 (GMT) Message-ID: Date: Thu, 27 Jul 2023 15:02:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Content-Language: en-US To: Michal Hocko Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> From: Aneesh Kumar K V In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5hgY73Y9pLJvLSEUAeMqqKIJvs5h6T4V X-Proofpoint-GUID: EEuUSfVWop7y4i3TO-yHBuMi6XhEFU8g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 mlxlogscore=830 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307270080 X-Rspamd-Queue-Id: B27584001F X-Rspam-User: X-Stat-Signature: ync75b76h657tmdagjifu4xhkq61yxfm X-Rspamd-Server: rspam01 X-HE-Tag: 1690450347-972142 X-HE-Meta: U2FsdGVkX19w+3lzhOptlnpFsGXskLVDADd9KwcRnj1xmuHQIGkVQ41r9MNY+nMv5RRId0OJIiPQe9IBvRCaGR6Y8QzxyouZ7UvMIAyRpLQMV/+NCPEl6MuG1o6NYbgBaLqSVgmcd2/sPy7aTbNihsn/p/X8AXIHe3V77d2+M9Pr3OCwyyTXcukT4c1X1majbxqyvc/uKKiwsDcgQ9/R/gk1cdK3hntMGlD3qIz/TQbwgfaLg8EKV8P7rbSTPtcUJgPkGC8mfcrpiKC/ld4RrBsxhQ20lP6lo7OqMnJJ31Ec6jiQjsa4XmNgqUQvnwASo6edHTdN07tr3s0wdxKZ3IHAJ+b34kiEHkGSxCRJeuFenBAOs2dWFP/hPfrMs3EmrxCP1gO19RQLbOyk8LU9CtwIfpH3t3PeNe5YEBtc2gHlUuSO3ESA5mpSjutHWTQ35Rb9WyknT7VbUUAq4XITo16ZhNKzcnMc1nKym7GjfUEGZx8V3DQVlcbMtxoc11B5oEQKGaxGXlGIEkeBVS/S8zTmSd+sVHoYo6330fqDUSMPExR6vXuTiCq3zy94+8Z73qWGFpnhtSU07qFKt2byx5ad9P4U8WoCZzo5+tfp2rWjGbvLl3Y0DM95bDnDknvWV9NKmZykVwRcf2w51h2jc56st21tfrUxOsFEtMoclaUjSSxgkZqq5xMu9xbavyViOhzmhGkiNZuHhQPqg49EZ2sbxxrS9LuHl9oXf2Z0jJCB4FXjlOzmC7eJ5kCOu2STpI+4IyTeLxQg02m3wnoK+thCs285Rvqw6LSmr6TlJ5dX5tQCRInsCHjlZsWsBR5w7tsGMF4pu0ZvRUNcL1TH1/wT/WP0VtF5OjwwEh8NVwA0tsrSq8r/TsVXjTNAnT2SwbAdm72f6UrydI9ikruDyINt+QmknTCvFft6jhACS5Cg8owKZYrpfQ6ltzqnLAjw7qsE/VJBsLb+mxwl9nS aHUtNGyL TM0yF1MHqnjRpXtcjNmrKceOaBN/gXUsVs4oV9U0eNA4iOnduzMfkN5VTzO7MEht1ekJQZbc8iLxyTpd0h7Zn2d7rSgiGMCgpv6roDPaNWehlBsWoXd1y5FNmLhMOt/8gnyM1kYf/rhyI+Q0iQBBBwZu3FEDwK8dB+FmQppX/V/4W2DwmuAKGAMu3/uZ2gk3Vro4c83pmJxSPFZxJC/qjXixi2hwgSYnn2kOV3+LV/n8zLEewC883gxmjYse8t8GNaocel8NJHbZvORV1rtB/BDavH3fvbmoZzt48+UpBs6iCN2+NzTBAnaTnmORVh598eS0k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/27/23 2:55 PM, Michal Hocko wrote: > On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: >> With memmap on memory, some architecture needs more details w.r.t altmap >> such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of >> computing them again when we remove a memory block, embed vmem_altmap >> details in struct memory_block if we are using memmap on memory block >> feature. >> >> No functional change in this patch >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> drivers/base/memory.c | 25 +++++++++++------- >> include/linux/memory.h | 8 ++---- >> mm/memory_hotplug.c | 58 +++++++++++++++++++++++++++--------------- >> 3 files changed, 55 insertions(+), 36 deletions(-) >> >> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >> index b456ac213610..57ed61212277 100644 >> --- a/drivers/base/memory.c >> +++ b/drivers/base/memory.c >> @@ -106,6 +106,7 @@ static void memory_block_release(struct device *dev) >> { >> struct memory_block *mem = to_memory_block(dev); >> >> + WARN_ON(mem->altmap); > > What is this supposed to catch? A comment would be handy so that we know > what to look at should it ever trigger. > I did add a comment where we clear the altmap in try_remove_memory(). I will also add more details here. + * Mark altmap NULL so that we can add a debug + * check on memblock free. */ WARN_ON is an indication of memory leak because if we have mem->altmap != NULL then the allocated altmap is not freed . It also indicate that memblock got freed without going through the try_remove_memory(). >> kfree(mem); >> } =aneesh