From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D536CC6FD1C for ; Sun, 26 Mar 2023 07:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10FB4900003; Sun, 26 Mar 2023 03:40:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09902900002; Sun, 26 Mar 2023 03:40:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E53E2900003; Sun, 26 Mar 2023 03:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D142F900002 for ; Sun, 26 Mar 2023 03:40:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 924184037A for ; Sun, 26 Mar 2023 07:40:19 +0000 (UTC) X-FDA: 80610251358.28.A1E11D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id B5B351C0010 for ; Sun, 26 Mar 2023 07:40:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YEEHwWvh; spf=pass (imf18.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679816417; a=rsa-sha256; cv=none; b=Wr4YbRBPgbO+Eou+JPNhr9mrE3zqDkGod2q0LCjCAAa9CXiHQB4JZKwz3A5H/jBoEdUtkn hp4XpY0GZAaqEj4JJOptoq5ciWIfyo+rRZOvxoZTXSzaruHdQ1fC1s5OX+zm2EQrLZKeYF zkbcIwpoTc5VAozDWS9mx+6wm9NcuZM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YEEHwWvh; spf=pass (imf18.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679816417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=51I4tYLSmoNnjzd854BdOPa0P0UjuvWyL9QlaGHcgJs=; b=3hUk9NJbAtZK70FDk90dxDssafpka5fjGIc7E8B+eK5Lbd91wJTZtK2XBmtbo/3nSLJIfN lVHwC/UUCrvj23F5UeCxrJO2X3wV7menLTRcnSc7G9S0dup4c6tj/XTUMnj8PHrSR3eKxK PJ0Q3r9JzVn4/aGMaYeM1OI61zZNTfs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679816416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51I4tYLSmoNnjzd854BdOPa0P0UjuvWyL9QlaGHcgJs=; b=YEEHwWvhFr0jbv7bM+XmlUhqwyST7gR9gFzAr0nn2vFQ9HyFbNWdBJkMWpL3AafZ1p9JO4 957rQP4USQOFyPal4SYtXkX2yW0YTD+KFk5Ptm5C9CoJgtsljeMhmkfisjVZ5FEtJ/bvj3 WwKn2lCpdF+a/ihVcRp9RXE+aMf/kpw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-6Toz8aLYN2ejPYjNAlk5AA-1; Sun, 26 Mar 2023 03:40:14 -0400 X-MC-Unique: 6Toz8aLYN2ejPYjNAlk5AA-1 Received: by mail-qt1-f197.google.com with SMTP id c11-20020ac85a8b000000b003bfdd43ac76so3872669qtc.5 for ; Sun, 26 Mar 2023 00:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679816413; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=51I4tYLSmoNnjzd854BdOPa0P0UjuvWyL9QlaGHcgJs=; b=iNTJzy7RZulErfCDCJEJ2uzlc9ZuVFE2VF9J7cp7SUZoWBPXIFDaA9k3KduZuuv9i/ AKPvs2+3XIp+HQb0eYpUO9nyyG/YnnfI3e3jBXMLWjo002EFLhc29HK1pdmGb8TQaW2Y w8/y9vS+ZJ8/RcZmvz88iPGZc7TP93K+vWEWg+b+Co9jIniC2GttjkK7PvgvlVwWrRNf bMRYEymu1doqQJXyHpniNy+3sEsGXXyoOdbuuYgqZj+5BXzGwId9xKnEymTXkb6YT+7l cq4UpeRr8pMJDWzb4Pi5bYcxnOQYbDNya8tNsY0i42Bebk3UQVZo9F5C1TLldnAxM3lj kE9Q== X-Gm-Message-State: AO0yUKUi9MTlCEAPEWKXKLmiuU9GCouVkfJoFKKooi7KbBa1gXTOA5ws zd9ebcEJsnymUhxihIJj3IDgpiBNAaBcrBTPqu9JLcldCr1eGFDWRat2uoe5Q1ys5LBwQL+XEOv IBESRr+hsuTw= X-Received: by 2002:ac8:5702:0:b0:3e0:8c58:1dd with SMTP id 2-20020ac85702000000b003e08c5801ddmr14893677qtw.55.1679816413598; Sun, 26 Mar 2023 00:40:13 -0700 (PDT) X-Google-Smtp-Source: AK7set/Tp4HbzbNknw4GmE88t4aB2nhlJ6hhgfENJoY/McVDZZctF2I+8vP2b95SwLcpq5wNnBRwcQ== X-Received: by 2002:ac8:5702:0:b0:3e0:8c58:1dd with SMTP id 2-20020ac85702000000b003e08c5801ddmr14893667qtw.55.1679816413373; Sun, 26 Mar 2023 00:40:13 -0700 (PDT) Received: from ypodemsk.tlv.csb (IGLD-84-229-251-248.inter.net.il. [84.229.251.248]) by smtp.gmail.com with ESMTPSA id u17-20020ac87511000000b003e38f8d564fsm581391qtq.66.2023.03.26.00.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 00:40:12 -0700 (PDT) Message-ID: Subject: Re: [PATCH] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs From: ypodemsk@redhat.com To: Will Deacon Cc: Peter Zijlstra , aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, ppandit@redhat.com, alougovs@redhat.com, David Hildenbrand Date: Sun, 26 Mar 2023 10:40:08 +0300 In-Reply-To: <20230324151259.GC27199@willie-the-truck> References: <20230312080945.14171-1-ypodemsk@redhat.com> <20230320084902.GE2194297@hirez.programming.kicks-ass.net> <20230324151259.GC27199@willie-the-truck> X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B5B351C0010 X-Rspamd-Server: rspam01 X-Stat-Signature: c7qs3uycp7a9xwwowc6kg11h5qzmnayb X-HE-Tag: 1679816416-401142 X-HE-Meta: U2FsdGVkX1/toaUZsRVFntAXNpFOKUze23cm4+q4qv5RcKbY8t5A+rdds9PyLy1qKAmv8dhHu8+8aXW2x5Nkq9e/78VuJt93F/4dHuxWzNQuYDLm2Q8WjDJQuAfn5T3IPOOmNHbTl0krd1BVCZf8NXQybaj1bfet1i3LrwlEVg7Q3n8K9Mz/mXNKJmqGTZ0S69+W/AN6JOoU1cL2AVTz+s/X5WELb0zkqUQgwljkpvYhIMeFaQUHbgLei0uBlQD5LqM+d5gQhSwTsslpZTI3K1VsSfYCRyW9H4Yxro6ZYxTtVV8y75/RRpbyz3P4Lb8z9Mw0sGPoHn7n3yf0t53dnzJqh99IZ73fnqwG4tIxn827yC+1oLy6jMPb7z9G53lC2CAiCr12yOsF5qKo/wLNhHbiWYh9Tkp5XrFwLk+6nR8B4d9Hig/HEnwNSmSyBv5wZbNg4kwT9h6Aswcxsw2tY6mlSN0qripQ1DGSmAN26QpyeC2QehuZURx52LLOfCB6Qb4ngVrVojQzJWASk377pCFpoeeSBGoOHUfax9gI0uClJQzHOzIEWLopYxvk4w9KHNpbhmT4Ay3hkEEBog/gItj4pJPzZI7rmZZu4UkHitpx5WvnqrpfGc9hIxaHYVcuEP9gH98+N2nH2JbhO1mmeZM7Wc7l9QfFBUxAmsCBE6uCiAoZ2UcFQPcLMlO9gY98WzJeGlBkK58388iNOs5uMLUHF4GIro+/koLL6mySYdzicnCLgk3msSA6cwpF+r9S4JJDMY/6gCtuzBC6FXTwVEQ6DhSR2GhjZTSbiNC/Mo3ju6UC3u+G8BkU6W8lz0yOVrloWFDBnGStNQ8xaXzmerqMuuUW4pFpFi9bVZczsw7ncW78MXHdkOu8yuuYW3e4zelW9j229jA2rNG3lrjC7ZkF876oFKiIkBSS9hoxQvSsPmlWFO+of6adhRu8L4q/4xho19nrdPY2OBXbMmM zJi1Y5hF MdKv3Wcvq1ZXuZjgfO/j9ooEWP/d3j1XzvSS59t4DMxUdRKAbTdhUL0c6i58PQYddQoEZwJ9v/NHZLdv2eAJk+GtHgW5UrcGX3a6iM9da4CvaSktozMbnHZkHFXHcR9TTcktayUx8Y8z+RmRJ8XzczIGHlc7cZgeGw7QQXozYmEhRtYAdUYcxxtwBrL4vTvC3DG100ch7ZK+rFoa8woPkg43bIVxJenHZLPMwnMSF7i+KdWg7W8XndaCdlmHcNRQ7z7jGrjAEovYVNPjP3fg6GVOTf6ollj8wkeqzx7K/Tff7IIaWPa+DgkCaOBbWS2PBRqVlcRwTB33PSMIy1OUG3E0MVRyj8bnHxeeG1gx+HwiFOZsXghXF15KBpplwGoyoDbXTYdANpbwI5q6cbVcF0XTwmvak6MEBlTeRNO6RJMgP1xN6gVzwtfud2sNWF7yv4OUghkuaQPAPykzm3YzXzp4l/hy6iMWmaChA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-03-24 at 15:13 +0000, Will Deacon wrote: > On Wed, Mar 22, 2023 at 04:11:44PM +0200, ypodemsk@redhat.com wrote: > > On Mon, 2023-03-20 at 09:49 +0100, Peter Zijlstra wrote: > > > On Sun, Mar 12, 2023 at 10:09:45AM +0200, Yair Podemsky wrote: > > > > Currently the tlb_remove_table_smp_sync IPI is sent to all CPUs > > > > indiscriminately, this causes unnecessary work and delays > > > > notable > > > > in > > > > real-time use-cases and isolated cpus, this patch will limit > > > > this > > > > IPI to > > > > only be sent to cpus referencing the effected mm and are > > > > currently > > > > in > > > > kernel space. > > > > > > Did you validate that all architectures for which this is > > > relevant > > > actually set bits in mm_cpumask() ? > > > > > Hi Peter, > > Thank you for bringing this to my attention. > > I reviewed the architectures using the MMU_GATHER_RCU_TABLE_FREE: > > arm, powerpc, s390, sparc and x86 set the bit when switching > > process > > in. > > for arm64 removed set/clear bit in 38d96287504a ("arm64: mm: kill > > mm_cpumask usage") > > The reason given was that mm_cpumask was not used. > > Given that we now have a use for it, I will add a patch to revert. > > Maintaining the mask is also not free, so I'm not keen on adding it > back > unless there's a net win. > > Will > How about adding a Kconfig to mark which architectures set/use the mm_cpumask? This will allow us to use the mm_cpumask on architectures that support it, and use acpu_online_mask on those that don't. Also make it clear which architectures set the bit for the future. Yair