From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AFAC67861 for ; Mon, 8 Apr 2024 22:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C50836B0083; Mon, 8 Apr 2024 18:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C003E6B0087; Mon, 8 Apr 2024 18:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7A046B0088; Mon, 8 Apr 2024 18:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 89B9C6B0083 for ; Mon, 8 Apr 2024 18:54:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1E532C01F3 for ; Mon, 8 Apr 2024 22:54:24 +0000 (UTC) X-FDA: 81987870048.22.3201EEF Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id B3D51C000D for ; Mon, 8 Apr 2024 22:54:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=h74VLVe9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=y9jN1jOF; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712616861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=onnDd3FQ/MpMGtPAwYTRbnQHdoPYHiRPCHyrzQjSB7E=; b=0kwQv5Rn12pBUSqpiTswLOMTdBMHiVy9f1N4MNDCs0SEEjl/MKDqHj7u3dQdIbvXvn5+/h hHMN/xP0f9VSaj5ASFQR1Ibv9H631Xlm37zXkWQyMjxHkEe4YbJe38pAIvKBuBR80ILhDj UHvnmAhOc9u0rgGQcJNHGJOuc/aec5E= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=h74VLVe9; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=y9jN1jOF; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712616861; a=rsa-sha256; cv=pass; b=5nGXmbKhWCSzUoJBPiEgfdEHg/cs6ReNsIMDiSOJZKBrCqsCGUcSrXh7nMKTnFNS1W0SUQ +aCd/hzZLGXJ0fyw0KwIEzK9b1H0vezTlum7356D5bzVejV68S5KempPmDedn6CENGSneb /OT8Xp/1IQjPfz8oxborf0bmhfxRMsI= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 438LnQlx018216; Mon, 8 Apr 2024 22:54:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=onnDd3FQ/MpMGtPAwYTRbnQHdoPYHiRPCHyrzQjSB7E=; b=h74VLVe96cUaz6lGHV5fFz/okMr5bR/Cc6wRFOJ6swfCp1m2p6PoG1OrFv7wzBajETK0 VRWo/U6HBWUCmdvUH+mFPX6YXfOEVlGMhUZ87fMN+fnkHlFJ0w3TaN+w2/qs0edxPz21 0y6lG8QKIlD/8I0KkSkN1qvtKYzakLXbIfooZeYJcmJWh7ZW59kV2WUPjEqQyQYwZNUz wSncsUGAxwMJ/FxQ9OwrwC3z1KQ7jhEj6kXS6T1amHnvc/s2klLgr9J6q70ZX0qUb1OV Xnu8x5cpAZpdrOw28qT3HoLbrHUu7WggltknQGEaQpK4O8C4WV6nxoWvwKD5KSLSDxf4 cg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xawackw09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2024 22:54:01 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 438MnVkE040186; Mon, 8 Apr 2024 22:54:00 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xavucc923-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Apr 2024 22:54:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQMy+FLPJ5D7MZmQ4tnRpHoJ3UsC9IN7cMDpbkOvgNp6ePcbT4hTfeW2o3PgBNmXc2zd/M/Kw20/+nTkyZhv2y59OQQXm05IQHoAfeXODn4U19XEd8uUr78vt9ChQ17g+DOXMhjAvcKvRUsSIxmgNo0AR6K+LCjgcuoc9xah7/BeYvSvXOhl3uRoOtgaBTzPMI1wZ+E8Sr+SEjBQrSDYvnVJnWnegModMlan6BJSeLAD5s8jDk4eve06KQYtYW+VUA/ELfcMOAOOQ3ODocaQenyfJbuAPJTivkuKecRzIDXBDlGag9c8mfyhOB7rgZOELzGC1qvCsuuE6imEl98pjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=onnDd3FQ/MpMGtPAwYTRbnQHdoPYHiRPCHyrzQjSB7E=; b=lv72s3bDFwyJBS5TC3lFyvCDZ/AYu70rHia3B/Oo5/xNRbvjgvuBifYRBS8pcyKoOpCHaq9uKsx9HO4VnWSEub1KucQlkheA9/ZwTI1Ze3szTmTxQySOnWkCv3nT/I1U8QPN2e4Gcs7sNaepP6wstZF3QLwJok6dpFLOs8mGN3WWJl8LfP5xhQ+d021/UWbBf192ZLpBr6WNSHmWm7ZhEOKopuUig2GENW694L/rOnOc/Hh3rXmxokyee+cjBz1w3fwk1FYFGjTE8MB0QWReAx6nI9DS6GmSSRDeqANGi+oJDE1Huq7Cgcx1yxEKZgO4aVsQ25hvVHID9QeQZexQhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=onnDd3FQ/MpMGtPAwYTRbnQHdoPYHiRPCHyrzQjSB7E=; b=y9jN1jOFGlJ0ISwJMZLBINvOCCYPES/uktidAaZgztAgHIgSO5h7iR6zxNaRLH6QWFe4Jpva0Z2dYx79dxBmK4AVmzTTBwPlPhe+CrfcX3e/g6Zt3OdKm2DkWXSZpmhduFaWLcj0xeQFxIXd6kCI1mIM0rqSFzbgiFL1BcYfgXE= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by PH7PR10MB6602.namprd10.prod.outlook.com (2603:10b6:510:206::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Mon, 8 Apr 2024 22:53:58 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7409.042; Mon, 8 Apr 2024 22:53:57 +0000 Message-ID: Date: Mon, 8 Apr 2024 15:53:55 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/11] mm/memory-failure: Convert shake_page() to shake_folio() To: "Matthew Wilcox (Oracle)" , Miaohe Lin Cc: linux-mm@kvack.org References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-6-willy@infradead.org> Content-Language: en-US From: Jane Chu In-Reply-To: <20240408194232.118537-6-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR03CA0091.namprd03.prod.outlook.com (2603:10b6:a03:333::6) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|PH7PR10MB6602:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h4q3mwpKmJEXnqiWcViYp65AlSxMMZMuovmBMWWJ3c9qUOb/Kemv8Ek6zfWcVWhSxRGE1j3l9JFSeqAmcTAmHNxreovdlmTcY0N780+EfkJKdArkVn9jJdQ8aLsj/b9paezD0ddEcUfq170RQCmuKmAhZ0VU4PxgiDg7G32CDUfkTta4LKr98qplEqRKgPZGSyjjO4qdXWTz4w1/umBcswvY6yzU5gsKX9znTBPSM+iupxja43YVRIdYayZ+i6D88Feig1SZhHXoO6F+6FP5+ruB++TMg1c/rJGxl5HbC9xAf1GbgdkXR8rBl5nBML5jkID089qnOmBjgarC3b2QHJn1m8j808KwZN/ZlTZMx/MNG7mfUduz9RmBh/IS5NUWGY26UddVlcOc7/Cgde3hq3G172nIdRiicL0eofqSwz9VJvZPEVbNfJ+sn/6Ug+QWeuStt6RobGG5yFI7I+2plo7j2IF1z2s0HKm7GPFJQqQACNeJy/QpB1CrJs3xcVz8/5hccwAJOl0ZZkryeo2hr75wTWRzLF0D5VBzlhhacgYjT9JTJQ8wTc1EIGyMhJ9F5RWAdc+tgIX57zybgc3e6C4VYmPCsLVHMOSvZsXUq97L0XFEVO5iZalKAYpxCEd+qSeFMH+/CqqlVw7CM3gocqbd0slPWJO+rvXPOuKicCs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVQ2dXpjMHJZY05aN3M0OTRWVGRTMW54ZTR1TlBabGRjcDFOUW0rUy9Ba3N3?= =?utf-8?B?MkdsVjRZc2hndDBPa1ZHblo0M0sxZWwxTCtVZHdpcjFsTUtOYzdwbHp4ZEl4?= =?utf-8?B?VkdEaW8rRTNIR0ZsNUkxL0tzaVFab2VGd3lPRi9CWCtEWlpGMExMeFRuWHZJ?= =?utf-8?B?LytpZms3ZkdrUWkvQkxwc0lEUnJjOGE2Uk0rZ3ZDNFYrRE5JZFFKZTN3Yllr?= =?utf-8?B?N2N5NHVBZ2JIWHlKZTJVTm1UeWcrVDBmbDRVeENuaE9zc1NNVndxOFhYTUU0?= =?utf-8?B?dFIxTzVLTkx4a09IbHBzend1dUQ5Ull2ZElHdVpFV2VSb2tTb04vaXBWaWdE?= =?utf-8?B?NFNTRjNBUjh3MmwzZlFIYnFaNi9TaFFQZXJWbmlNSVFkUVg1TTgzZzkya2ZL?= =?utf-8?B?UjAyMS9iZDdUbWlzZXYvem4rS2dVc3lwY3B5cmcrY3dQMDJTWHg1SG9TYXRj?= =?utf-8?B?c0VodHlrb3kzR2dOZ1pqTHNCTFErQkVLRjBhaW8zeHViekQzU0g4cUxzYzl4?= =?utf-8?B?NjlwcG5tb0k1YytMYkFJa1NFMGpOTVh5YjdSYWVJR25tVFRndkVMc3J2bHdZ?= =?utf-8?B?ekptSWowb2pvTk91NjVYclNvZFJ5aVBUd1phamxYMG01a3BFaUpmZzI1dVdk?= =?utf-8?B?bHZDdzZERVkyS29SRGoxVENNdURyVlJKbDdmQTQvMjVpN2lpWFF4UGRvY3po?= =?utf-8?B?ZWRNRjdieXRUQzg1VlpRL3JqNVBiQk0zYnBHNy9FdFQrdDJEN2gzWFhTMW5P?= =?utf-8?B?NXhPejFOZndxTHJkQ3hqNVc2d1pMTkhMSlo2UDI1TXVwR2Mrb0tJMTAxS1da?= =?utf-8?B?UkFnU3puRjBFM0c2QlJWTno0SzRkWjVUSEFIY2dlcVg5NVNaVjVEeGVGSkJz?= =?utf-8?B?ZmZiSmo3NzJtaVdLa0ExQTVyWEIrSCtNQUsyaHdMQTNXL2ZKaFJiRHFVOExm?= =?utf-8?B?cHZlZE1XMzhVUWtNb0g3bTBQT3kvYWFpdXU4VGkrVlpWY0RjOWFRck9mdGhq?= =?utf-8?B?QzBZOTJIVzFvVEdhbGtzVzFqRm12UHFub2dVQTNZSTRKdHJLakFjNW1Iamkv?= =?utf-8?B?N1F6L3ZXVXVqQmRydXlIc3NtRzlYMFpjdVhPbWtkT0JnS1RjQ0k5QmRtWFIx?= =?utf-8?B?Mi85Mzg0UGUwQUY3dDhyYnE1V1YwUGpwUWt4bmFlRy84cDdOcGJYRE5ONGw3?= =?utf-8?B?WkdyTWVydjJaMXFING1JaitDZkpNWG9aWlFuSWh2cldVeUdMZDBuZ25oa2pv?= =?utf-8?B?Q1lTNCsydjVYQ0tKYklaRVdjLzBSbExLekNrSWZ1a1V3TzlqaFFqdGtHTjFa?= =?utf-8?B?Tlg0M0lSdWxJUldJUUZSVmNLU29iTEtveHlVSitFVzYxa1NGOW9kMUI1RmlC?= =?utf-8?B?MUMrWGh1WXBua3pMRXg0enRyclZxV2E1TXB5ZDhZdnU0aGhrR2lmb2N1YTU3?= =?utf-8?B?aDJGZEpYaitRbEtsT1gvZ1hWcVZzYVNCU0hUK0hOSGFKU2FIUDVQemhiQlhM?= =?utf-8?B?MzhZUnozaTVQQmtxclZpZFJsMVNJWFpEZmxOZkxIM05waDZIbVlGbXpYMC9T?= =?utf-8?B?NGR4M2pRbmk1VElyRFJiTmx2aDI3U2h4RzRmRUJoQlFLb0FWeWI0R05oSVZx?= =?utf-8?B?UTI2UmlCM2pCRzhYNE54WmR2UG9UUXE0SmJhYnlGa2dXa21xYnhGQm84YWRu?= =?utf-8?B?bGIzcUl3cHg1ZDl4N2VqRHUwTkZ2T0tHYmp0S21XdHJVd2laRjV3WjJWK1Jy?= =?utf-8?B?YkorVE5sTGZWVldwTFcxVmhzdnNQOE9LUE9TYU0xZGcvclJ3clpmaVZrS3Ny?= =?utf-8?B?aUZWeThvMnZlQVI0K1BQYWEyNWxtQ0dBWW1qaHdnOThIbUlEQXhmMkdxTDc5?= =?utf-8?B?QXBaZUorNmpQdHlha1EzZ2hxUFA5SWVmMnZ3ajVZZGtFdk1kVWFzVE5JeEJ2?= =?utf-8?B?ck4xME41OW1PUUpuWUZocnlGTitVWHl0NmZWSktkbS9NRVgxYk1xR3dIRVNQ?= =?utf-8?B?SXZ0WFcwZWRLS0s0cm5QdjFMWHN5ZE9aNUZOUlYzbnpKL1E4NjRKL2xmNTVo?= =?utf-8?B?YUUyMHF2QUdkYmFvS3dhRzVLVjB1RWc3eWp4dlNyYU5WL2lFMGdMMUtPYStG?= =?utf-8?Q?3Cpzbiu6A+OTGiUENcEUKhW0R?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Bk7cbqe3M0QPrvdmTMWvTvn4AVuSHuNz1zCFAgeyKtSiijINnREzJPI7kBnO/KPcnxjPo0IUHIPrkimCyDnspfadZkBDEWjE/MCZ9+Faa47UBUF4Sp4b1HE2kS/lKj4QhrLmWrddR7FjxM2NqStqdjh4tsC2Z8w0yUyATuswHrDSsYM2tHxPESaD8tM/EVnoKCKoKmAmIvvxyYQcU5cIfVYqEEq5HaubRzxVJ7sxY0zVHbyLq9AXEH/5rBuUYNPFUOM8O+D/2I+yNrH0OUfnppsClOShZ5og4usmO1SRQHFPFTJYiGiU74FDHN48KW38ZNbaSWFKWHdvoZrDmDpi1LlJZgqCTCvyZe0rIzW7nyffvefyv1yPrhOiMEY32TAY5lqCDymlzIdR2eRgrTBV+UUiWKWf4+KKyLivzH2pbKefHVc4qKzfr+JRs9Kt9dXiVpLEwTgrfsDD/M/VlE176HqSWyzHjnhkolKXO+sUJDohC4a66CccDa7yz3NiAD7xVoaltbAGNCHPlfBOcAm2BbiWyfh2VEhqZeZFweAuBW/mQXzyrxfSLjvLO0/b6WbdNVnVzvF0xaRVW9Pu2ySgcwjEdM1cWDsX5zw3ZKzdY0Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96381527-63d4-4e0f-47e5-08dc581ec63d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 22:53:57.9070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yQdbqHtmaSAEqkHNI/gzI7nca8qic/v9SmbmQuKj9w3GC2QzX9VFmXD41K7HK/eSda6dN2XLJvUniBYB5DFxpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6602 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-08_17,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404080172 X-Proofpoint-GUID: OhBpgvYgd2VE_WUcsfdU_gIqzg-MjelQ X-Proofpoint-ORIG-GUID: OhBpgvYgd2VE_WUcsfdU_gIqzg-MjelQ X-Rspamd-Queue-Id: B3D51C000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: orzo5udf3zodhjheq1bsui6tfo4f91sb X-HE-Tag: 1712616860-136947 X-HE-Meta: U2FsdGVkX18dGyc96+PLogVFLn7WcPTtQ+VeCiEl2VSowlYcnuyrT1Yahj2EjtLUSLv0yf4COBSkND8O8EkU6zgoDuk4TwxK683oY9px8uOUaDaAVzlBJ0DwmXU78nrKdnL7cax7X6dUVlwKogPucdk5iJZyuwimvapHaKKYTmKEtCnlHNKwmAObmUpHdEpizZN+V51AXFsSqwiXETQph6e2imIgftevK6TbEJHk7Fp0Gip6WD1g4YmOYNaEavUbiIv/IiAi9JkEd751yom2tLKJejMXQnZXD4fzCG9cCphcPLuwPlrtBWpP537DquJvTHEQlCEB753NaWqUTD5C1X2amUcH30AMWaETHJ42tnHxRcmqekcJfr40YuXKH8qvXlCmGlfD/SiwG3rcawNFDHCg5VTpae/w5et/c5/AzEt5UiDCVcTaeGjO8omi0j6wZjpHLeskUuopU783YujSi11YEN3KiaPTumX3lrb0ZPR5HGXVEldzcirl9lJ0J2wsOHkKpIbXorVo3/78zmqMde6nxhFliBwfayuBVr4O//qfeaxN7Ueu0Ut8wWSzynzAxAaWD53UPmS3GvAj8SDgKDpu6o031m6hO1xyrt2qXGrECISnQTz+cIY/GXUiXfAemHYkCzbIp3niJVHJx/E8NhQVksrvpmChE6kmcb5mTQyYTmwntzzwh3NXrtDcJDYbOGf3dMQp+Len5gQH9PMvS2lW12RAMweLj0jtP+VLTDKFqDq4IXl9siM6Z3FTZIym2DFbtuv6xNLcoaWhitXT/rKsu6XD55UVlndsXf51mOFTvzTgcg2xaY/WoPFTc1qTCJZH8ijd6sgRan+qBs+Y58QDo0v8pfh3keLvwdmOvaLJDJCX5W4o80CjnoiUSi5nyYgUGuv38sxoiF5DvoftUvYb61tVzF3qYyh1H0ZXo/GeK5LfAWXHEOAuZMcAL24inCCezVflwjbRaBPe0iN we7O9SqZ Vwti0aiaqHuVTA8GjSrGAwD4URlVhwdnvTBzqjTKfeJr8jLv91XKCocp/gW7N7+LbMHaQstIl0aV/p89Qh5krABP4o1+M1lB10hicMGcmyTvQjLW+AkujpXpzCNjUpAVnFPkjN9iVlGqspOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote: > Removes two calls to compound_head(). Move the prototype to > internal.h; we definitely don't want code outside mm using it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 1 - > mm/hwpoison-inject.c | 11 ++++++----- > mm/internal.h | 1 + > mm/memory-failure.c | 15 ++++++++++----- > 4 files changed, 17 insertions(+), 11 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b9173e230804..19a67f45907b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4011,7 +4011,6 @@ int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, > extern int memory_failure(unsigned long pfn, int flags); > extern void memory_failure_queue_kick(int cpu); > extern int unpoison_memory(unsigned long pfn); > -extern void shake_page(struct page *p); > extern atomic_long_t num_poisoned_pages __read_mostly; > extern int soft_offline_page(unsigned long pfn, int flags); > #ifdef CONFIG_MEMORY_FAILURE > diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c > index d0548e382b6b..c9d653f51e45 100644 > --- a/mm/hwpoison-inject.c > +++ b/mm/hwpoison-inject.c > @@ -15,7 +15,7 @@ static int hwpoison_inject(void *data, u64 val) > { > unsigned long pfn = val; > struct page *p; > - struct page *hpage; > + struct folio *folio; > int err; > > if (!capable(CAP_SYS_ADMIN)) > @@ -25,16 +25,17 @@ static int hwpoison_inject(void *data, u64 val) > return -ENXIO; > > p = pfn_to_page(pfn); > - hpage = compound_head(p); > + folio = page_folio(p); > > if (!hwpoison_filter_enable) > goto inject; > > - shake_page(hpage); > + shake_folio(folio); > /* > * This implies unable to support non-LRU pages except free page. > */ > - if (!PageLRU(hpage) && !PageHuge(p) && !is_free_buddy_page(p)) > + if (!folio_test_lru(folio) && !folio_test_hugetlb(folio) && > + !is_free_buddy_page(p)) > return 0; > > /* > @@ -42,7 +43,7 @@ static int hwpoison_inject(void *data, u64 val) > * the targeted owner (or on a free page). > * memory_failure() will redo the check reliably inside page lock. > */ > - err = hwpoison_filter(hpage); > + err = hwpoison_filter(&folio->page); > if (err) > return 0; > > diff --git a/mm/internal.h b/mm/internal.h > index 57c1055d5568..14cdc9ccb582 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1010,6 +1010,7 @@ static inline int find_next_best_node(int node, nodemask_t *used_node_mask) > /* > * mm/memory-failure.c > */ > +void shake_folio(struct folio *folio); > extern int hwpoison_filter(struct page *p); > > extern u32 hwpoison_filter_dev_major; > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index f94d85075ec1..2e64e132bba1 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -357,20 +357,25 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags) > * Unknown page type encountered. Try to check whether it can turn PageLRU by > * lru_add_drain_all. > */ > -void shake_page(struct page *p) > +void shake_folio(struct folio *folio) > { > - if (PageHuge(p)) > + if (folio_test_hugetlb(folio)) > return; > /* > * TODO: Could shrink slab caches here if a lightweight range-based > * shrinker will be available. > */ > - if (PageSlab(p)) > + if (folio_test_slab(folio)) > return; > > lru_add_drain_all(); > } > -EXPORT_SYMBOL_GPL(shake_page); > +EXPORT_SYMBOL_GPL(shake_folio); > + > +static void shake_page(struct page *page) > +{ > + shake_folio(page_folio(page)); > +} > > static unsigned long dev_pagemap_mapping_shift(struct vm_area_struct *vma, > unsigned long address) > @@ -1623,7 +1628,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn, > * shake_page() again to ensure that it's flushed. > */ > if (mlocked) > - shake_page(hpage); > + shake_folio(folio); > > /* > * Now that the dirty bit has been propagated to the Looks good.  Reviewed-by: Jane Chu -jane