From: David Hildenbrand <david@redhat.com>
To: Zhao Gongyi <zhaogongyi@huawei.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de,
shuah@kernel.org
Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit
Date: Fri, 30 Sep 2022 10:33:57 +0200 [thread overview]
Message-ID: <b90f1f32-eac5-a1cd-436a-3486b704c9c9@redhat.com> (raw)
In-Reply-To: <20220930063527.108389-3-zhaogongyi@huawei.com>
On 30.09.22 08:35, Zhao Gongyi wrote:
> Some momory will be left in offline state when calling
> offline_memory_expect_fail() failed. Restore it before exit.
>
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> .../memory-hotplug/mem-on-off-test.sh | 21 ++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 1d87611a7d52..91a7457616bb 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -134,6 +134,16 @@ offline_memory_expect_fail()
> return 0
> }
>
> +online_all_offline_memory()
> +{
> + for memory in `hotpluggable_offline_memory`; do
> + if ! online_memory_expect_success $memory; then
> + echo "$FUNCNAME $memory: unexpected fail" >&2
Do we need that output?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-30 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 6:35 [PATCH -next v5 0/4] Optimize and bugfix for memory-hotplug Zhao Gongyi
2022-09-30 6:35 ` [PATCH -next v5 1/4] selftests/memory-hotplug: Add checking after online or offline Zhao Gongyi
2022-09-30 8:32 ` David Hildenbrand
2022-09-30 6:35 ` [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit Zhao Gongyi
2022-09-30 8:33 ` David Hildenbrand [this message]
2022-09-30 6:35 ` [PATCH -next v5 3/4] selftests/memory-hotplug: Adjust log info for maintainability Zhao Gongyi
2022-09-30 8:35 ` David Hildenbrand
2022-09-30 6:35 ` [PATCH -next v5 4/4] docs: notifier-error-inject: Correct test's name Zhao Gongyi
-- strict thread matches above, loose matches on Subject: below --
2022-09-30 8:52 [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit zhaogongyi
2022-09-30 8:56 ` David Hildenbrand
2022-10-08 1:40 zhaogongyi
2022-10-10 6:54 ` David Hildenbrand
2022-10-10 17:02 ` Shuah Khan
2022-10-11 1:48 zhaogongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90f1f32-eac5-a1cd-436a-3486b704c9c9@redhat.com \
--to=david@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).