From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499E2C433FE for ; Fri, 30 Sep 2022 08:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDD518D0002; Fri, 30 Sep 2022 04:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8C048D0001; Fri, 30 Sep 2022 04:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C338D0002; Fri, 30 Sep 2022 04:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B8ECF8D0001 for ; Fri, 30 Sep 2022 04:34:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 90B2F140143 for ; Fri, 30 Sep 2022 08:34:04 +0000 (UTC) X-FDA: 79968089208.28.5EE5465 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 2C87140011 for ; Fri, 30 Sep 2022 08:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664526843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qO+BdsidXtPxlgGBkdeG85IbyU5cabWapFdrZ2axzLg=; b=Mb3DuqfawwLIuyPJEZzOoOq1wNql1k3/7Oy0168dFeZRuX47UxlUPANqfNORBzmxliciJ/ j4GC/w0qpzlabQPGbmdLmK6MOB0dsOi4l2trrd8AlYp0ycJVdCFGCVwQlt7ctLWv0gWdwc dYoKCqscuQc4x2yzMLc9QeGHHqKWPos= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-361-Dw6rThCjOlabL00dmY19WA-1; Fri, 30 Sep 2022 04:34:00 -0400 X-MC-Unique: Dw6rThCjOlabL00dmY19WA-1 Received: by mail-wm1-f69.google.com with SMTP id y15-20020a1c4b0f000000b003b47578405aso1079956wma.5 for ; Fri, 30 Sep 2022 01:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=qO+BdsidXtPxlgGBkdeG85IbyU5cabWapFdrZ2axzLg=; b=w1f2RY9oSubPdA2w5Vcs8iokvfNS/v255SrazfTywt2p1Rku4KNUpyC19CTtbI4/M5 9mrZQFq31kR8/3t6dDneq0wIuRbf3uTeoveWs4qH8K5pWD54IyqutlMqWvSwlu88eYN0 K+tmO2Qk2yIHJOI8N6WaZM/upxlbJ0qQprhkCG9+bnbVYpl8KEKtmOk/ZkKf1LnATOb/ aKeQ41JeJKUtVHiRwtOdW/TzTPDUCBCruElwfwPKQ9WXf9v8ymeREt1PZZMPeZvo5tgC t0lcrcs0IU3oVIU6c/wVSnPJB4aGl0412ak6ASRC0RaDEKGt9DocDh9v5Zd5CFa6RjoD Sy8A== X-Gm-Message-State: ACrzQf1t5Va2bw9drP1IE7EjivEtWrJIjXqBvhGEgf5EwTCAoJ0x38tU L3wwUbUyFKKF4/1noOZRn34TtQOdwN++wcBCL/2hiBnS669CpBXT27s3BWhBmJD2x38Zv7J5X55 Sb5S+nYvVrEg= X-Received: by 2002:a05:6000:384:b0:22a:5d05:c562 with SMTP id u4-20020a056000038400b0022a5d05c562mr4999338wrf.701.1664526838893; Fri, 30 Sep 2022 01:33:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6NRmhoyd+3R2o1xuvY/2jTk5yngLV7dYKGrw8U3pNLD5NdDevDCS6YN3KRzA4TJTUkM4dd2g== X-Received: by 2002:a05:6000:384:b0:22a:5d05:c562 with SMTP id u4-20020a056000038400b0022a5d05c562mr4999314wrf.701.1664526838661; Fri, 30 Sep 2022 01:33:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:c00:48b:b68a:f9e0:ebce? (p200300cbc70c0c00048bb68af9e0ebce.dip0.t-ipconnect.de. [2003:cb:c70c:c00:48b:b68a:f9e0:ebce]) by smtp.gmail.com with ESMTPSA id e16-20020a05600c2dd000b003b47e8a5d22sm6534230wmh.23.2022.09.30.01.33.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:33:58 -0700 (PDT) Message-ID: Date: Fri, 30 Sep 2022 10:33:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit To: Zhao Gongyi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org References: <20220930063527.108389-1-zhaogongyi@huawei.com> <20220930063527.108389-3-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220930063527.108389-3-zhaogongyi@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mb3Duqfa; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664526844; a=rsa-sha256; cv=none; b=2yo5M7QUIdLaTWTigO9J/+anKCld1aPxFgasLOPA5jzgjngzLtEXfEEMY1/RyeQktrFpQl xW5wkaGltZFYO1YaN5pAnY7rsi6AgmqtQC565S4TxeRApwOAVR93CYwQoSl3T6cecUKjIO m/wCoRZAaZJMHoDN4ag6tpW++7wb2XA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664526844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qO+BdsidXtPxlgGBkdeG85IbyU5cabWapFdrZ2axzLg=; b=TwDk6GkDrl2cTnBHT+KU/6QmU+1lY81yu301ifK0NWC/aOtJtitmIwXHwGTtnYsueYrlf6 +HV6k5e0hLlTlZYvwB+fWhwTVucCYigLm0JiouZgLRwwML5C/1cr9GlrNtY9EC8Wsm9Xbx xvaVL2WKO93G7QbhdZAI2cZkFRUd62I= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mb3Duqfa; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: aw3qw5nxbayqu4nwy59f48gaxdmr9o47 X-Rspamd-Queue-Id: 2C87140011 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1664526843-637995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.09.22 08:35, Zhao Gongyi wrote: > Some momory will be left in offline state when calling > offline_memory_expect_fail() failed. Restore it before exit. > > Signed-off-by: Zhao Gongyi > --- > .../memory-hotplug/mem-on-off-test.sh | 21 ++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index 1d87611a7d52..91a7457616bb 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -134,6 +134,16 @@ offline_memory_expect_fail() > return 0 > } > > +online_all_offline_memory() > +{ > + for memory in `hotpluggable_offline_memory`; do > + if ! online_memory_expect_success $memory; then > + echo "$FUNCNAME $memory: unexpected fail" >&2 Do we need that output? -- Thanks, David / dhildenb