From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFA2C19F29 for ; Thu, 4 Aug 2022 03:21:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94A9A8E0002; Wed, 3 Aug 2022 23:21:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA048E0001; Wed, 3 Aug 2022 23:21:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74B998E0002; Wed, 3 Aug 2022 23:21:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61A408E0001 for ; Wed, 3 Aug 2022 23:21:53 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 308C9141618 for ; Thu, 4 Aug 2022 03:21:53 +0000 (UTC) X-FDA: 79760460906.18.5A14DE2 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf14.hostedemail.com (Postfix) with ESMTP id 27A6A100130 for ; Thu, 4 Aug 2022 03:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659583311; x=1691119311; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=x66Sbn9V9+yjgmkHqt79USIhW0auntN5xcQ1Nb+idok=; b=jGo06ctf1JchoH4dvQLj0sh/rdVxqTNgnE8Wl3z750YdEIHm0TymHs8x aLeH0JIDfY44cj9cJ97UfoE3XzEereV2ezFywYMF1YOt5wTNtnh+nRpMZ Fj8SWiQounj/UIH/VAh4dTjvszH5uIe8ZokklP2jyN9fYG8HeojH7NVvK h8WnPWoIoQEaQf6dmuW67tOkGT6DxeBbP1EePs+tptNZD8PFD+NNdz7zf 2sRuf30k/BTXafiq/1Z8DBaYsTadlfuQtwcNU4cK92Fdeq0sUyZzdUEz6 WzLhrQPdg1k/RiMuufx6cOQ7Y5aUqEEhcpqT2A5UHrpSUtI0wpSRaiX/S A==; X-IronPort-AV: E=McAfee;i="6400,9594,10428"; a="291046126" X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="291046126" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2022 20:21:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,214,1654585200"; d="scan'208";a="729432446" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 03 Aug 2022 20:21:39 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 3 Aug 2022 20:21:33 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 3 Aug 2022 20:21:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 3 Aug 2022 20:21:32 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 3 Aug 2022 20:21:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzyuSWXlzK1PQo8DPsEiXZxa7+XtFLNav5GfmQGC2IDiT/bbnVNTDps4Qeiz9c4MXx5BqUDsPSlSKcdnFYUjwEvLKSaDUA+ZfWj3dKdjz/+ntOz0hJGFFts8XBNGZhbKSgwAnqjC178LFfaTnTzgVLDjVYqGDUttUAJj82dGBaUNjGOIQ0d8p4kHgw/i1wfoOOwIk2vT4/aVXou0B2/Jr/4gpdzPuHUaAe00us7L7kXOs8griXaKgxXNN/nx/feFG7OthgPykhHx94scpnK4rfaC92TBqRxnYqAhd6cNGU6YQxgUDGqDagePJ0oJSlTgt4m/12RaZLs7tHc0v7E6Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cBqaGMcS27pp7i4IT17ewPFI0IMnjnTMbZtkZODZI/A=; b=gDuXdb0ydmIIT6C5usQsw5BI7TSRFMvHNe79hjMXM03xIblPIQYzkx87KURQfHGCCsNFh9hQpWYsU9TghHPHsz8JWNygBKj+LJC+0Z+3DQ20fZC3M5RdyRKn6PGqTDELQ5m+gRUN2L3kAfNyZZW22pFtu61rCrft/cFJQbTaqsZEz7AlU6yxDbfuWEUP7Qp96RbGkgomBujZIVHTSzXHhp1t3RZdLcOjLqeKdmbOE/RxfhLNMt88YrLwrGI+I1vmdkyxBwJZWeyIelbsWRmDDcAmh1ZyEkJkMyXsGXuN9MjzLhuDV8Br8cxyi/z1gpq8AqB64VoU3J6ZPlYtBrJJ6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB5613.namprd11.prod.outlook.com (2603:10b6:a03:3ab::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 4 Aug 2022 03:21:30 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32%3]) with mapi id 15.20.5504.014; Thu, 4 Aug 2022 03:21:30 +0000 Message-ID: Date: Thu, 4 Aug 2022 11:21:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH] mm/memory-failure: release private data before split THP Content-Language: en-US To: Miaohe Lin CC: , , , Linux-MM , HORIGUCHI NAOYA , Matthew Wilcox References: <20220804025121.4001361-1-fengwei.yin@intel.com> <85e14a18-2797-760c-bb45-64ff217007b1@huawei.com> From: "Yin, Fengwei" In-Reply-To: <85e14a18-2797-760c-bb45-64ff217007b1@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0005.apcprd02.prod.outlook.com (2603:1096:3:17::17) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2d72775-a6bc-4929-682e-08da75c86c5a X-MS-TrafficTypeDiagnostic: SJ0PR11MB5613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lZvIjPQVC7R6/4ieFG2XgphNUQ4XjZuoOxhwTlr4XhZwVaQL6rXFSiONwO9jzrg25Y7cqKsoxdPkpdGaVszWZ18rvdAMK9mAwCc9UiTwOgXLsyaW2f/smpoEMDXAYVhkPnndj6LtvZGdGDfFjJpBe/Ur0mfQtKEkEpBFTwufD2dCJDc35JQd6bKFoLjlYP8sabKjvZGj8Fdsso9qlne6MjQIn6VYpfU6ybghWBLWRPcFDUw/LGxdkIgjWdldkI3u/meK7z6zIBraXf+Tqun/cH43iPEsbf3q0n6Mdv2OSk6ZgeIHRNUxn762ELEOdTXd4wa/bDTRoYQ1h0XaT6F5+ezPiZ0d317kzb0Zb3jK+1iQ0yeib9SJWP2XZ+GfPe2IAPPeeyuZZ5WPTcKPC891f42VaQLqQ8XStf5ltEdvA9CWbOsqWoHnemCuGn5Etw1pDPxi8Z/HBAS+h+YD0aSQPgCoFFTWjG2u+bd47vz6pWALSEXO0HDgBxhggTOUhM+J8Tj56I6HCPLKdMPw1htbF1IXfderkdOmLyt5lkT8cpBdCapTe2ypLjVEv1QI6pgqJNjEqhCAPdajZ/Cx+bzWOs+AEgzKVLS6Tb5MpqYyQ/YDUSTHURpYaduBrxFL9Dwf1XPDC1LMzc1X+zrDuWRmEyLAwj7TedU/lwoMtCNt6bqLWRn795ErzloykLDf+nYEOBXMLeB1hSbZQOqWWFfd04IRV6TnIX7qP58q2ThgsOjYYCI1UQkUMzYszN9tCqRScSBX6hFMXTdaUlsv1iHSUyGnbzgaGEgl6KtY1dj3d9gZXiApUPwG+zawTgomRWi0Ud2L8qFnzKXSnrF4Wqyggg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(366004)(396003)(136003)(39860400002)(6486002)(82960400001)(6916009)(86362001)(31696002)(66946007)(66476007)(8676002)(316002)(54906003)(66556008)(186003)(2616005)(53546011)(38100700002)(26005)(6506007)(6666004)(6512007)(4326008)(41300700001)(478600001)(83380400001)(2906002)(31686004)(36756003)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEJ3aGVEMzFaeDNydmtldUJkYitmRmRHVjl1QjYxQ3NsSEYwNUU4RzZHejdI?= =?utf-8?B?Q0lEdkRHZDRaYVpaOVk0TjEyUk1zSXRySVJJUjJ0SlY5U0UrNkxXREMwL0FE?= =?utf-8?B?Mld3NEJ5eCtNSHp5K0Z4dUp4d1hkRGNodlZNTWk0bkZoT2hPVitYQmpGR3BZ?= =?utf-8?B?RmV1eVlxbmxKVzdqMFdrVnFYMFRLNjFMeGFGWlUzT0xhdnB4allXN0V6MXdu?= =?utf-8?B?OXNFbUlmN2FPeVNrZjN3N0ZIR1Bnazg5bndPRHBWaFQ3dUlidVNxNXdwRXA2?= =?utf-8?B?S0tpaC9PemREcnZDWWdBM2o1dElxczFKbU1qS2dJQ0dkSTE0dmR3T2tUNDkx?= =?utf-8?B?bEUwanFtQnVhNDVJRDdzV0tEcGYzaFREaE5BamxFV3VNUGFEbUlUbExLMlNK?= =?utf-8?B?ZkhrWlA5MWVCV0FlUWd4MlJxbkNtSWtEdnYzZWdoczBRWDQ4amtBdzlKYWcz?= =?utf-8?B?bUs1S2Jselg2ZTZlVzRRV1RMS2U4QWdXM2NKSHc5OFd3NkJiZXlqbHphYWJm?= =?utf-8?B?dTZHNDdaOXVnWlFvZmUwajBDeDVBM2RIcXp2WVJDOHFIM0ZuS1Y3RWIxWHd5?= =?utf-8?B?blNNc3g1NUx0SG84L2JFZlRmYW9PM1ZjK2NGRmVvRVVGNmtYc3JVS004cXVj?= =?utf-8?B?VHhsT0hDQVBZM1lxK2R6NFMyMHNVS2U3bEVpUUhsMGdabUhWbHY5WVA5S2Mx?= =?utf-8?B?bVk1aE1sa3EwU3lrVmJOaWhJM1VSNGwrY3krWnNpbVZGOGRMbVBKbmtCVk42?= =?utf-8?B?THRSV3l3RHEyRVZrNjBNWlNOajh1RDRoWGFrU2EzanFoY0pqczhBS1Job1pz?= =?utf-8?B?T0RIaDEwWHZtQzVtN3VOR0tDeFJOZ2xWcDZWUHhtWDBmQ09jZXdwQ2pXdHU1?= =?utf-8?B?WEVrRnFOa1lYQUY0Wm43cHQ1UFh2Z0FJODc3NXB1ZmdWNGpwMmNRYUhHc3or?= =?utf-8?B?RTYzMCtjcFhCVi9KMVpITFE3Z2ZBQ2NGVThDZWtlcFZtUHh6TVpRRzRjWHc1?= =?utf-8?B?cmd6bE5YNjQ2YUQ1eHJxZFNVRzlPc3NPaEVIWmNRS3lJS2haRVo2U3BSVnd1?= =?utf-8?B?ZFd3MmxHNmMzT3FieThXeFZGZGo2SGVneVhFV2psSmZWd0Y1RVZTd05hOW1p?= =?utf-8?B?MGtWZWtVTGpsNGJjbzlhZ0x4RHJoVmhNSEdMa2JyR25pc3RjVTc1aEZQTENz?= =?utf-8?B?TDVjS1pWOWU3K1VGT0cveEovV0ppb3IrOHRYZXFxRHIwZ3JlSGhrUWl3TmZB?= =?utf-8?B?V0pFYlZLMnhwSHFadTFrY3RnbmI5U1hDdFN3ZXgzOUpHMUxEMjlESnpZSkta?= =?utf-8?B?SVZjY2FCSWVFK2YzcmQwbkdJZzRpWE0wMVFCdnp5TmhLdFQ0Wkg5OFdUdENk?= =?utf-8?B?WEhwdnF3MCsxS1RTWVFXT1I5bTZMMG9hZ1g5RFJ6ODVReEdCUlV6ZmJ0T3Q0?= =?utf-8?B?b3F2MElIZW9BZ29QZ0dFdWU5NllXWjhXYlA3RkxZRFlNVUNrUmd3NG5ySnZj?= =?utf-8?B?VE9qMDByd1NsR2RQelJWMFBENElFelFIU3lxRnlJRXROZ0ZtWS9zVnRmZnVN?= =?utf-8?B?d2RIOG95SlpBQ0FYZXVNVzZNT1ltdXEzTGdLNThyVStJcVdTRVM1b3REWFB2?= =?utf-8?B?NHBEcG5pdThHcGN2WWFDekR5YUx6ck1TSGNjWW82Tm1DMmN6eUhFQTYwdGdY?= =?utf-8?B?TkprTVdXUzFqVEc3amF5RzdHZG90YkkreW52OXEyczB6SlVKZjJJbHVpREJk?= =?utf-8?B?R3gxeWd4dklhSEN5dkJueUh6enhXOFNpRjZPcUdHVzFBNnJnTGF1YTdMekZq?= =?utf-8?B?cm9yZWZzMGtDN2tNeXlJMjk2VDh0RXhra2owNENUelZFdTRJZXFPRkZaQVpt?= =?utf-8?B?ZlBBSVd3M25lQm9kWmYrRmVEM09lS2VVQk1tUnlvc2JiUklWRjNHN2FaQy92?= =?utf-8?B?Qms1ZFYyUjU0eDM0eXR2UmFYb1A5eStkTUVUVEFzNk5rODBsd3BMRExTTndR?= =?utf-8?B?ZEJwa2hUcG9USUhrVGFlYXN2UzJaMktrbmZ1bEIyazN6Q0N4Slh5amQrM21x?= =?utf-8?B?QVpwWVEvVC94N3UyL1lsdEhYeDhPZlFIWVM4V2ZaV3pKcUl3Uy94OThaSzkr?= =?utf-8?Q?6e99eZDWE/Jv31SmGnmnzd91Y?= X-MS-Exchange-CrossTenant-Network-Message-Id: b2d72775-a6bc-4929-682e-08da75c86c5a X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 03:21:30.0776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QRQXW/qjK0jF5aq+ul9gts19DnF5Ix+1jtUmrwgzntB9Q5kTiewsyPKVdjcUTUlwm+CBZV05Wy8sC8G9dPqakg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5613 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1659583311; a=rsa-sha256; cv=fail; b=B1srTIYVomWeIJ2o7rDqtOZOK4AzTWSNj2d2khvL1fVaL5Fc5oeIo1d7g/miXEwFEyl9I/ r9ZZqjw0wrC1YuuLTmMr9USVNmMSnpV+cF7PIiOiCZIjyRRYQgWxVKNJXSBMvlycf7JU+6 pFABGAPDYKttY522X2ENuEKlp34yAJc= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=jGo06ctf; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf14.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659583311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cBqaGMcS27pp7i4IT17ewPFI0IMnjnTMbZtkZODZI/A=; b=1cDts9BgVdeECMNxQQEWT7hnRZJsPvfqnqgztk1AuHs1mDZmmZ+H1Xis8ALIQZc3rC8Cdl tTpKWtYTyHiByJXES4QHuCEddf6WWfNk5r+EDOHM5+kYdylM5z6RO4bq+dpSK2Y3jrKJ6K e+elU43yVbzVLzcKeMGYmOS3vCjj+k8= X-Stat-Signature: 3eifua7ryq9qkjqztkt6p4iwz84es1to X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 27A6A100130 Authentication-Results: imf14.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=jGo06ctf; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf14.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com X-Rspam-User: X-HE-Tag: 1659583310-839626 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miaohe, On 8/4/2022 11:19 AM, Miaohe Lin wrote: > On 2022/8/4 10:51, Yin Fengwei wrote: >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Which could >> further cause the meomry failure not recovered. >> >> Release private data attached to THP before split it to >> increase the chance of splitting THP successfully. >> >> The issue was hit during HW error injection testing with >> 5.18 kernel + xfs as rootfs, test got killed and system >> reboot was required to re-run the test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs with >> private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. >> >> Co-developed-by: Qiuxu Zhuo >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Yin Fengwei >> Suggested-by: Matthew Wilcox >> Reviewed-by: Aaron Lu >> --- > > Looks good to me. Thanks. > > Reviewed-by: Miaohe Lin Thanks a lot for reviewing the patch. Regards Yin, Fengwei >