From: David Hildenbrand <david@redhat.com>
To: Stefan Roesch <shr@devkernel.io>, kernel-team@fb.com
Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
akpm@linux-foundation.org, hannes@cmpxchg.org,
willy@infradead.org, Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH v8 1/3] mm: add new api to enable ksm per process
Date: Mon, 17 Apr 2023 17:00:24 +0200 [thread overview]
Message-ID: <b9f1fd7f-e362-8f6c-21db-e84dd82fdd00@redhat.com> (raw)
In-Reply-To: <20230415225913.3206647-2-shr@devkernel.io>
> +static void __ksm_add_vma(struct vm_area_struct *vma)
> +{
> + unsigned long vm_flags = vma->vm_flags;
> +
> + if (vm_flags & VM_MERGEABLE)
> + return;
> +
> + if (vma_ksm_compatible(vma)) {
> + vm_flags |= VM_MERGEABLE;
> + vm_flags_reset(vma, vm_flags);
> + }
> +}
We can do the following simplification on top:
diff --git a/mm/ksm.c b/mm/ksm.c
index 905c8edce5cf..26e7f585d65d 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -2511,15 +2511,11 @@ static int ksm_scan_thread(void *nothing)
static void __ksm_add_vma(struct vm_area_struct *vma)
{
- unsigned long vm_flags = vma->vm_flags;
-
- if (vm_flags & VM_MERGEABLE)
+ if (vma->vm_flags & VM_MERGEABLE)
return;
- if (vma_ksm_compatible(vma)) {
- vm_flags |= VM_MERGEABLE;
- vm_flags_reset(vma, vm_flags);
- }
+ if (vma_ksm_compatible(vma))
+ vm_flags_set(vma, VM_MERGEABLE);
}
/**
--
2.39.2
I have some patches based on your patch set (handling/testing unmerging
whens setting PR_SET_MEMORY_MERGE=0. Will send out once you changes are
queued.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-04-17 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 22:59 [PATCH v8 0/3] mm: process/cgroup ksm support Stefan Roesch
2023-04-15 22:59 ` [PATCH v8 1/3] mm: add new api to enable ksm per process Stefan Roesch
2023-04-17 15:00 ` David Hildenbrand [this message]
2023-04-17 16:36 ` Stefan Roesch
2023-04-15 22:59 ` [PATCH v8 2/3] mm: add new KSM process and sysfs knobs Stefan Roesch
2023-04-15 22:59 ` [PATCH v8 3/3] selftests/mm: add new selftests for KSM Stefan Roesch
2023-04-17 8:07 ` David Hildenbrand
2023-04-17 14:35 ` David Hildenbrand
2023-04-17 14:56 ` David Hildenbrand
2023-04-17 16:42 ` Stefan Roesch
2023-04-17 16:40 ` Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f1fd7f-e362-8f6c-21db-e84dd82fdd00@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=shr@devkernel.io \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).