From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C33DC77B76 for ; Mon, 17 Apr 2023 15:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C33A8E0001; Mon, 17 Apr 2023 11:00:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3732C6B0072; Mon, 17 Apr 2023 11:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C058E0001; Mon, 17 Apr 2023 11:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 16F9F6B0071 for ; Mon, 17 Apr 2023 11:00:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8931712060B for ; Mon, 17 Apr 2023 15:00:33 +0000 (UTC) X-FDA: 80691194346.30.7B86BE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 06B854003C for ; Mon, 17 Apr 2023 15:00:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Se17SZmq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681743630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hLT0rP9zRrFGagsk4no7XW+N43K0c6wa29Y33hfsxZA=; b=qF52VmobLJeCP1XE3Mnwet5Fo3kNNg3y/oGv6e1M+gA5B8lqpXMgc66TT6nMWKKFQYkbdN fqq8FHWsJDO5wpHwvtkhhAQXBafjj5C2/MXcgWfvxpJ/8Pxl8ixBJNrJ1efRW+IPjg2mXW F9azdhyxLf73xXKkfyEyCyeF1kt/1mc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Se17SZmq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681743630; a=rsa-sha256; cv=none; b=4kg7NzliGNbzxPAVMiv5TPzIwH6mZ2PAdzyFHoJOb55sI8MauK1kcgKQrVSXnYW13IGeyX N7Ot+ghAZjpZAw0UrdwUBbFQajAt5l2/LVyPaaAy5UVFNPRnwsZ92yJVVXGUQt73K+Oynz 1SsG8lvCnDLUENECOT40MVXpJozf1g0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681743629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hLT0rP9zRrFGagsk4no7XW+N43K0c6wa29Y33hfsxZA=; b=Se17SZmqN5XuI/wYq38EuCdMWVtaJN3+9L2TLB7YdIuwtsd4NE36BAPhLsa4O0DNaBXLB3 QQVGZ0ER3F+fqiHGOKpmiBqdIJ6XrZF/rwBTgF+kLSuYEF5Rmu0YhxgWMWZojzaN79nA/W nR5XGLr1p7+TpRLFDq0GT/1hFlzhQRQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-RJqU7qIWO8GJNZU2Eraapw-1; Mon, 17 Apr 2023 11:00:27 -0400 X-MC-Unique: RJqU7qIWO8GJNZU2Eraapw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-2f625d521abso894029f8f.3 for ; Mon, 17 Apr 2023 08:00:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681743626; x=1684335626; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hLT0rP9zRrFGagsk4no7XW+N43K0c6wa29Y33hfsxZA=; b=Hd5EnhdAK7iBOmyS914sXIWPcktVXMD4yG56RZETMBQCYyoWK8exXrjmQqYFr7JeZu XwTOsSJ/KWl+DAHVIi/pkjJAvgYUuV0Ehq9Guux9DfU05QgFrdwLyegj9i6ZWtmVSd+I pYid15RpoH99y20boHup+osnDFaW11SNn0sFl8ACluTmeLvh2h8TltXPaOglvq9ssfTm +dajvp6QFnCSNqVnBe8TUvfu9cXvK5Ps/U0hhprqch3HDlJwJRqAGWvLpFHkfWZ39fH+ zC07wLJq3u5pQ3izRNfRIDKeDQMyeZm32icGRIClWciRj9v4+EuQ3/Pj5LbP54YQFAVG JGOQ== X-Gm-Message-State: AAQBX9frX4/ZiHVC3x0ofh67sM76+pP/ZJ8ZVCAuEAZOellwZk3lYVIU ZedYwizog4DNT6TXQi63QwcgcP9BbcPFtajmJXEYf6WJfT4KA0125RG4JgcWpsSz4t1nhSxUXvG ZTRsDOAN4sdk= X-Received: by 2002:adf:ed4c:0:b0:2f5:3dfd:f4d2 with SMTP id u12-20020adfed4c000000b002f53dfdf4d2mr5640102wro.64.1681743626553; Mon, 17 Apr 2023 08:00:26 -0700 (PDT) X-Google-Smtp-Source: AKy350YsKOxwZX6am7dDPrBSxeyriaPLE8HJ1zejtvMwWin7cKY8fooXz/gsbQvRu662UxNAvKAkdA== X-Received: by 2002:adf:ed4c:0:b0:2f5:3dfd:f4d2 with SMTP id u12-20020adfed4c000000b002f53dfdf4d2mr5640088wro.64.1681743626208; Mon, 17 Apr 2023 08:00:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id v9-20020a5d6b09000000b002d97529b3bbsm10671612wrw.96.2023.04.17.08.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 08:00:25 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 17:00:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v8 1/3] mm: add new api to enable ksm per process To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya References: <20230415225913.3206647-1-shr@devkernel.io> <20230415225913.3206647-2-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230415225913.3206647-2-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 06B854003C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ifean9hqia1sb1386sz1igu1twtjc55t X-HE-Tag: 1681743629-588203 X-HE-Meta: U2FsdGVkX19K4TI13cjCsP2Nei4sdtIiRwrX/3mYh7BezLm0RcysFc+XzL2NYccEk+m+70ler0dOr2Xdi5/mOIPqpqqzA1BzwTSh//6ogsFflM1WukglXXR5DvAFIKxEB/HpbvV9EOQNoDr/Q1Rc00HXmFhxDYB9VjFQzkxJhaJZ4ZxPbP5gh8oIr40C4/1HN0POUMpfnhp5WaW7Z+f5FLMrWHqbZ9Scsujo37m7tkQwwiDBMFloDpNoHo8vpofus0718/A+BRK4e5Ju6RnBW6tvXfJjtjoxCqi7Rt9xDGsYK/FBXbXgFI9LgCe0ATkPkGu4KhmnhcsABl5SORF09lLKem6YQ/JJnAS5Hu/+LXVbqaDtgM2B+wSgcZLHoYb4/yikAV4DnNlFiOK94AVlAjedi8vF95Mt+uo3fU3UeM3LGVZBGEYwWYWVdWSMESmKAkqFjW5HCBsUWo4e5H9Z8T3jOkbgfv2li+uPXxsi5x0CMGKtMdhv0CuJuWPhALHuzUNfPi2ggIXldzvJ8w207ByyytFZmjjYmkQDOU3Gk1UxsOdfSd4weY2pC6kGEJbWbXgt22puGTYhB5M0bSi/qmhhwLPti7FDjfkKaAvyo8QN6bfFsQJKCqXd/ejK8wikVgUPMNQ5ieWk0AEmrueplJGJ4TQEd18DUNIYHVZ5qDg90K+NMP2LnkGps4bfbZn0wgJSJhSMSS5jVAeImSImhCNTCY0ZYWUTeS6Eb2rxzZBK58zPQnTlXN2lhs6A+meHcajsVZM20HE+hS7DqEAq/D7yqeVf7FA3Ep1WUFsPmkZ6yYheKRPdwFAuAfUo7gd4Nizaig1ptw6GOOrhJIyzqmRTdK7PE44Wdvfiq7F7qEh/AeJkzqa+pKXzCb8/njtQ4rS7j2eIojlfWyUdfxTn7XdAWCoo327wfccNz8w6Q1iFlx68XA8ll5Aj0SuF99PpBawlB4M3UMgM/xvKLwF RkxnhoOT DapL5Ragu2hh1T9Qzy5xjXgaWDGrLT6KlqKvYrMO11ozQisiEKN6ItC9gjGV28qKr6gcbZm72CoMirEGqHVTFCN06NJyoyN5iTHcuL6HTPBSBpOmSyMYVYsiy6QY7JTO0LGpjf9BkB7g++ZSbV/V4orkxFajPrJuMddBe4CRZm18Aj+nw0Is1fgOdaMod3T45M5MJwQuaPzS1elSf/KXMtyZuXRrBO1+GBXUSQBe2M1/7pwtN0QElMFRjkTd4GMBGsB2gsHYH9kq1pIxmZXZuoa3v6qCXOs3WqiZny/EEW22uVNw4XCN7WwOCcWs1wPAsHrDe3Cob+IbjQ7Z0p2SFfcxhQFZ//WY1mnlYk4TeR5q1LV9SC9CoqSAqPJGlH4H92eICEyuZzh8L9Lgi1cIH/OLSMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000358, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static void __ksm_add_vma(struct vm_area_struct *vma) > +{ > + unsigned long vm_flags = vma->vm_flags; > + > + if (vm_flags & VM_MERGEABLE) > + return; > + > + if (vma_ksm_compatible(vma)) { > + vm_flags |= VM_MERGEABLE; > + vm_flags_reset(vma, vm_flags); > + } > +} We can do the following simplification on top: diff --git a/mm/ksm.c b/mm/ksm.c index 905c8edce5cf..26e7f585d65d 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -2511,15 +2511,11 @@ static int ksm_scan_thread(void *nothing) static void __ksm_add_vma(struct vm_area_struct *vma) { - unsigned long vm_flags = vma->vm_flags; - - if (vm_flags & VM_MERGEABLE) + if (vma->vm_flags & VM_MERGEABLE) return; - if (vma_ksm_compatible(vma)) { - vm_flags |= VM_MERGEABLE; - vm_flags_reset(vma, vm_flags); - } + if (vma_ksm_compatible(vma)) + vm_flags_set(vma, VM_MERGEABLE); } /** -- 2.39.2 I have some patches based on your patch set (handling/testing unmerging whens setting PR_SET_MEMORY_MERGE=0. Will send out once you changes are queued. -- Thanks, David / dhildenb