From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF417C3ABC3 for ; Tue, 13 May 2025 06:34:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A446E6B0085; Tue, 13 May 2025 02:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F5766B0088; Tue, 13 May 2025 02:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90A666B0089; Tue, 13 May 2025 02:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 715966B0085 for ; Tue, 13 May 2025 02:34:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C11F1121823 for ; Tue, 13 May 2025 06:34:30 +0000 (UTC) X-FDA: 83436920700.10.81FE037 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf07.hostedemail.com (Postfix) with ESMTP id 2A5EE40004 for ; Tue, 13 May 2025 06:34:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UGocXwC0; spf=pass (imf07.hostedemail.com: domain of chao@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747118069; a=rsa-sha256; cv=none; b=gilEBKQvu+EybhjyEHmhHIwY+jeVfUdxHRtw67Ic37MY6CzDGFh/19VjkTpcYL5IEfpEBu MGq+EpseTg4HYB7kkLVpwX3dFxJWAf++l4BsLuDakntHrcM/3HQCzOmX+5YWA9SRe14ChP ccttwEaM9DOBJ8AcFDMoMnZNCZa/zcg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UGocXwC0; spf=pass (imf07.hostedemail.com: domain of chao@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747118069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uq3p46liXrbSXGMvdqJBKZVJP5M+WKB5E0d2hRWw5fU=; b=ojRiYr8FXnmZxCrWSHf9qrEDrpNgWe6MDJ1d/Zqk9FPTLWZYYLprdLL6j3A7kyMPWO3xek 6maSjZ/BPa2bltWv6TfLK/RTBWWz4azEovVtGNoyyaEzbxWRIWZewUDogISfewWlrWJWE3 u/gp0UPPOeo09qUK6qwMs132W1fmBtA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A2734614C0; Tue, 13 May 2025 06:34:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4945BC4CEED; Tue, 13 May 2025 06:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747118068; bh=ORgLMITxeIyffJ4kFtLu1h4Mh8Q9hlUWYLleES2f2lE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=UGocXwC0ochsFRNKa9jZYXMnu8vntCsPFMbXh6206Pj8y7En90phD0RdyN/LxzLCE 82J36pPxSCwjacFcvpBRrF8IDjQlEqacV6O1sKl0tlTAl6Y4h0qvL+PMd2QA1CLush BS17XOqXNwKt88vXoWhWhNbEQ52P9B6lVkIlEY8+T3ibDhcFIAWAklZbLT4xLwdnbc TdA//RZn9tf7Vp++nxjG306X7RWiTH447MBVIYyTyxkTfSmCyPWkH4MQs0m8hR0Eco iGb2iSvmWXHbZiDxohPrDrVwgYoxzjS7vye79OWyCtCbxXXesvY/eW1cnjxPxmOZTT 4vDeMLVhzA0kw== Message-ID: Date: Tue, 13 May 2025 14:34:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] f2fs: use vmalloc instead of kvmalloc in .init_{,de}compress_ctx To: Christoph Hellwig References: <20250513055721.2918793-1-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2A5EE40004 X-Stat-Signature: ew7akb14t89mcdu5pdnorzf6apwnc9j9 X-HE-Tag: 1747118068-18091 X-HE-Meta: U2FsdGVkX18uhjD7OgXnZ81Q8sEaRs7hQYmNGe8BTaJPfY6tYjP5FhZmja7eHnNkaZzheqQtly6b2OFifEPrruSlqXy8v9/1qhXwqY1BsqFCd+YwmGmQJjBM2D+Z6YFNECAqVmtm2TZrQeSVC9QDPh7zwVg5cPfYc3uowRVN671xLCwF5A2yzK1XSHfJKgyOp/MDZ+yn/2itcX8/9kS3VGwI+CR2FlhdfHPfHTyladC4F85Ef54oetoNTuB6kSxrDJOYP6GSgDVwubSon4b+N5+w0txdyPOPzrM7d5nY1n8nW5yIBQMOXpAfVY7A5TN89ghdmx4QjAKoutEw0hsNGlDQm3Uraajef5XGHmw73Y0oTgPnfnlOPYVK+2Jf6S/F2IkKtYvTz3J2zCIOqy6tmGh/Hdx8/pWtbpPDvYRqNhLrPv2OTxvmlTatyLDB0vLzdJkAkBO6sSDOD+V9jIkSf6Jgp/GOBrTjC3OKZcnjIi/akQN8wFSsvSRSgBRR2ma2eedVWjq+OJnPGqJOZxUXbbHkB1aaoIVnYE5BxzWoxJqDsZTT4uXkbeZJQ9Ep6ffp6df3p7LC8mkJ9LcnxBdF1nqy793otdiX5ZytkyfIRxfcYPTesOjsWU/5E0yxA380lFA/dbbof+li3i+BX+zG+Pq5mVJQh6NbbOqembYSYqTEh9r0YEsXx2BusakR1pKZOU4rgIRta2tr9LfvPzPSem3zwW2oXeo1M6EfQDFanx97Knmc29BWS9foR4zOUfk4oh7RUNDgXj5B6i6dGlo8uBm28uaQ8nZ0vkCt8CrsvpWDR4FPdxhmMVRA6u0Ld0ZYadU9n+vuVU38XuiSxMbYt7UFhl2puNejE84XYhEgHFr1Ij0Iznds56cQRD69ZWKRM1YRqDWu/VoKv8p0E0m65wWE4E0CgXdN6/Y7EpIJWpsC/a6pAs13ezKdBk0zjGHn6DeKB++3VeoQDuVuCR4 IYyw0YA5 /26tMWn02VBCtNwt8EOlJt+n8s0d1dev0mNdN2sq7GU+FG0IohQ0fjW4m8+jwr/CN55OuWobC2SuJugrej+5tMtLj1H+UpPuGXyR0xs5iI6BFlMlI8u09I5ElU09Y5yR4S7YmM9tIwA8luMgQBaf/hlBw4852VpUW3r+pLh3Jhs/0B6Skfa/qb2HdovcVrzZvbJFH59BfygWIzNlKc/US4ECjAg6sAfrmtcq4E5LksFfyz55ayyLdvR/Pul+nBNu/7Z72u5kcAA9XcWKlEWg7LnLpMpUthMvZAFeoLnbPdM0S0Pc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 14:01, Christoph Hellwig wrote: > On Tue, May 13, 2025 at 01:57:20PM +0800, Chao Yu wrote: >> .init_{,de}compress_ctx uses kvmalloc() to alloc memory, it will try >> to allocate physically continuous page first, it may cause more memory >> allocation pressure, let's use vmalloc instead to mitigate it. > > Shouldn't this be handled in kvmalloc instead of working around it in > callers? kvmalloc() will allocate physically continuous page first, so it may race w/ other physically continuous page allocator who uses kmalloc(), in scenario of there are few physically continuous pages. Thanks,