From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B6FC433F5 for ; Fri, 28 Jan 2022 11:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090AD6B0071; Fri, 28 Jan 2022 06:00:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 040586B0072; Fri, 28 Jan 2022 06:00:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72306B0073; Fri, 28 Jan 2022 06:00:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id DA5726B0071 for ; Fri, 28 Jan 2022 06:00:31 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 96C0F181CB163 for ; Fri, 28 Jan 2022 11:00:31 +0000 (UTC) X-FDA: 79079402262.14.89902BC Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 468AE4003C for ; Fri, 28 Jan 2022 11:00:31 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id z4so11014135lft.3 for ; Fri, 28 Jan 2022 03:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=xLjWT1FA3o7kuuGnw+XH0Uw1AYY+iBBGZTcFTlDUs8E=; b=b9o5s2Sb9lYvLAtqAE2YEuS1OE984ci2qq59gCoeCaHo6yXRkZwjTuVUXHrLyxnvxU CgIqBRtDY2sz6cDtDqYA7s4/7svJy8FOB0L+hkKp80LlWtRyrfAQGh1s4EwNpDUszYaY vrPQeHYDMcp8Z2jVK38Dq6eg1eONtY1XRDBuNNRaGk5cZuN/jft+E9Pc+/pZ85yYTBX7 /AehTue0453A+fJOJ3q6/4pkonv/XYStdP9DeJFSSw59NfO2bFMVczeZwJ+ldihTAexF xgTmtmPIlr35LxH2rClNNW84ylB7hsuvgms+6aVWHgfJkGj7qT1sHe9QyKid/5AJGDJZ ZiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=xLjWT1FA3o7kuuGnw+XH0Uw1AYY+iBBGZTcFTlDUs8E=; b=n/zCSZpfvXiXh5wtld10DeHPjZdTruRa1YzYt3vYfJ4AVJMoej0eYBz0h89g8QOtW7 4vUgtKUHbobSjon6SaZ9jIaXljSwHl/yMJPhb3czP2YdXUawxVoFk7jbTHhk36I4E+ZJ ee4yNDTa58nLVf2RkGYcUAXgBkONx4rIyK4ieKpzKjN5M2ddPFyGm4UuiUTfKh3rPmIg Xc8QM/1jgv4uPYd6PBp134guvI/QEnKntXit8EakrX0d7TbMqBtJRnuhHkyrbHUVKvvQ L5regoK4qxp//qwJFimaVU5OeUODtLk8OXjqGe1DUDIiL+DryAPvQOOpqRrk3IUfG1qQ yC8g== X-Gm-Message-State: AOAM531Uea87tZAhqNXAks18v8xvG310ZJEBbajknoxUsVHq5WpXH/az +Y/aOMdjkDBnZNCdiwPK5x8= X-Google-Smtp-Source: ABdhPJxsMD+DlY8lJCkVd67chisGoLDC5nTave7KXb7zq59YiP0G5vCpGqWTob+c2VRedBvPOqtSeA== X-Received: by 2002:a05:6512:1398:: with SMTP id p24mr5771133lfa.581.1643367629582; Fri, 28 Jan 2022 03:00:29 -0800 (PST) Received: from [192.168.50.104] (staticline-31-183-164-222.toya.net.pl. [31.183.164.222]) by smtp.gmail.com with ESMTPSA id p15sm1134409lfc.233.2022.01.28.03.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 03:00:29 -0800 (PST) Message-ID: Subject: Re: [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib From: Karolina Drobnik To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 28 Jan 2022 12:00:28 +0100 In-Reply-To: References: <777d0cfcf531357cfe39d53987aa964a3a42ce8b.1643206612.git.karolinadrobnik@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 468AE4003C X-Stat-Signature: dswn1o1uy3kb5xw8t6hez44supqmdtsu Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b9o5s2Sb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com X-Rspam-User: nil X-HE-Tag: 1643367631-623303 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.007480, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, Many thanks for your review. On Thu, 2022-01-27 at 13:28 +0000, Matthew Wilcox wrote: > On Thu, Jan 27, 2022 at 02:21:19PM +0100, Karolina Drobnik wrote: > > +#include > > + > > +#define __GFP_ZERO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A00x8000u > > +#define __GFP_DIRECT_RECLAIM=C2=A0=C2=A0=C2=A00x400000u > > + > > +#define __GFP_BITS_SHIFT 26 > > +#define __GFP_BITS_MASK ((gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) > > + > > +#define __GFP_HIGH=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A00x20u > > +#define __GFP_IO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x40u > > +#define __GFP_FS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x80u > > +#define __GFP_NOWARN=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A00x200u > > +#define __GFP_ATOMIC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A00x80000u > > +#define __GFP_ACCOUNT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A00x100000u > > +#define __GFP_KSWAPD_RECLAIM=C2=A0=C2=A0=C2=A00x2000000u >=20 > Why have you reordered the bits here? I probably mixed them up when I tried to merge the stubs I did for memblock and the files that were already there. I'll fix it in v2. > > -#define __GFP_BITS_SHIFT 26 > > -#define __GFP_BITS_MASK ((gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) > > - > > -#define __GFP_HIGH=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A00x20u > > -#define __GFP_IO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x40u > > -#define __GFP_FS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x80u > > -#define __GFP_NOWARN=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A00x200u > > -#define __GFP_ZERO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A00x8000u > > -#define __GFP_ATOMIC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A00x80000u > > -#define __GFP_ACCOUNT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A00x100000u > > -#define __GFP_DIRECT_RECLAIM=C2=A0=C2=A0=C2=A00x400000u > > -#define __GFP_KSWAPD_RECLAIM=C2=A0=C2=A0=C2=A00x2000000u >=20 > The original ordering makes more sense to me (but then it would; I > did > it)