From: Gang Li <gang.li@linux.dev>
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
David Rientjes <rientjes@google.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
ligang.bdlg@bytedance.com, Gang Li <gang.li@linux.dev>
Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages
Date: Tue, 16 Jan 2024 16:09:42 +0800 [thread overview]
Message-ID: <ba5a88d7-0cd3-4f9c-aae9-beeb7d64dbaa@linux.dev> (raw)
In-Reply-To: <2ae5ec3f-4a96-4819-af65-5f04df0c2ebd@linux.dev>
On 2024/1/16 15:02, Muchun Song wrote:
> On 2024/1/2 21:12, Gang Li wrote:
>> hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
>
> The name is so long, how about hugetlb_gigantic_pages_alloc_boot?
>
>> hugetlb_hstate_alloc_pages_non_gigantic(struct hstate *h)
>
> hugetlb_pages_alloc_boot?
LGTM.
> It it unnecessary to reverse the condition. A little sime like following:
>
> if (hstate_is_gigantic(h))
> /* gigantic pages */
> else
> /* normal pages */
Will take it in next version.
next prev parent reply other threads:[~2024-01-16 8:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 13:12 [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot Gang Li
2024-01-02 13:12 ` [PATCH v3 1/7] hugetlb: code clean for hugetlb_hstate_alloc_pages Gang Li
2024-01-10 10:19 ` Muchun Song
2024-01-11 3:30 ` Gang Li
2024-01-10 21:55 ` Tim Chen
2024-01-11 3:34 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages Gang Li
2024-01-10 23:12 ` Tim Chen
2024-01-11 3:44 ` Gang Li
2024-01-16 7:02 ` Muchun Song
2024-01-16 8:09 ` Gang Li [this message]
2024-01-02 13:12 ` [PATCH v3 3/7] padata: dispatch works on different nodes Gang Li
2024-01-11 17:50 ` Tim Chen
2024-01-12 7:09 ` Gang Li
2024-01-12 18:27 ` Tim Chen
2024-01-15 8:57 ` Gang Li
2024-01-17 22:14 ` Tim Chen
2024-01-18 6:15 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc Gang Li
2024-01-03 1:32 ` David Rientjes
2024-01-03 2:22 ` Gang Li
2024-01-03 2:36 ` David Rientjes
2024-01-11 22:21 ` Tim Chen
2024-01-12 8:07 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 5/7] hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA Gang Li
2024-01-11 22:49 ` Tim Chen
2024-01-16 9:26 ` Muchun Song
2024-01-02 13:12 ` [PATCH v3 6/7] hugetlb: parallelize 2M hugetlb allocation and initialization Gang Li
2024-01-02 13:12 ` [PATCH v3 7/7] hugetlb: parallelize 1G hugetlb initialization Gang Li
2024-01-03 1:52 ` [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot David Rientjes
2024-01-03 2:20 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba5a88d7-0cd3-4f9c-aae9-beeb7d64dbaa@linux.dev \
--to=gang.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=rientjes@google.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).