* Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
@ 2025-12-11 8:13 ` Chengming Zhou
2025-12-11 8:32 ` Anshuman Khandual
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chengming Zhou @ 2025-12-11 8:13 UTC (permalink / raw)
To: Johannes Weiner, Andrew Morton
Cc: Yosry Ahmed, Nhat Pham, linux-mm, linux-kernel
On 2025/12/11 10:56, Johannes Weiner wrote:
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
Thanks.
> ---
> mm/zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 5d0f8b13a958..84797ed4d3f5 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -141,7 +141,6 @@ struct crypto_acomp_ctx {
> struct crypto_wait wait;
> u8 *buffer;
> struct mutex mutex;
> - bool is_sleepable;
> };
>
> /*
> @@ -781,7 +780,6 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>
> acomp_ctx->buffer = buffer;
> acomp_ctx->acomp = acomp;
> - acomp_ctx->is_sleepable = acomp_is_async(acomp);
> acomp_ctx->req = req;
> mutex_unlock(&acomp_ctx->mutex);
> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
2025-12-11 8:13 ` Chengming Zhou
@ 2025-12-11 8:32 ` Anshuman Khandual
2025-12-11 17:11 ` Yosry Ahmed
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Anshuman Khandual @ 2025-12-11 8:32 UTC (permalink / raw)
To: Johannes Weiner, Andrew Morton
Cc: Yosry Ahmed, Nhat Pham, Chengming Zhou, linux-mm, linux-kernel
On 11/12/25 8:26 AM, Johannes Weiner wrote:
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> mm/zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 5d0f8b13a958..84797ed4d3f5 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -141,7 +141,6 @@ struct crypto_acomp_ctx {
> struct crypto_wait wait;
> u8 *buffer;
> struct mutex mutex;
> - bool is_sleepable;
> };
>
> /*
> @@ -781,7 +780,6 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>
> acomp_ctx->buffer = buffer;
> acomp_ctx->acomp = acomp;
> - acomp_ctx->is_sleepable = acomp_is_async(acomp);
> acomp_ctx->req = req;
> mutex_unlock(&acomp_ctx->mutex);
> return 0;
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
2025-12-11 8:13 ` Chengming Zhou
2025-12-11 8:32 ` Anshuman Khandual
@ 2025-12-11 17:11 ` Yosry Ahmed
2025-12-11 19:21 ` Yosry Ahmed
2025-12-11 22:37 ` Nhat Pham
4 siblings, 0 replies; 6+ messages in thread
From: Yosry Ahmed @ 2025-12-11 17:11 UTC (permalink / raw)
To: Johannes Weiner, Andrew Morton
Cc: Nhat Pham, Chengming Zhou, linux-mm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
December 10, 2025 at 6:56 PM, "Johannes Weiner" <hannes@cmpxchg.org mailto:hannes@cmpxchg.org?to=%22Johannes%20Weiner%22%20%3Channes%40cmpxchg.org%3E > wrote:
>
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>
Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev mailto:yosry.ahmed@linux.dev >
---
mm/zswap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index 5d0f8b13a958..84797ed4d3f5 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -141,7 +141,6 @@ struct crypto_acomp_ctx {
struct crypto_wait wait;
u8 *buffer;
struct mutex mutex;
- bool is_sleepable;
};
/*
@@ -781,7 +780,6 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
acomp_ctx->buffer = buffer;
acomp_ctx->acomp = acomp;
- acomp_ctx->is_sleepable = acomp_is_async(acomp);
acomp_ctx->req = req;
mutex_unlock(&acomp_ctx->mutex);
return 0;
--
2.52.0
[-- Attachment #2: Type: text/html, Size: 1400 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
` (2 preceding siblings ...)
2025-12-11 17:11 ` Yosry Ahmed
@ 2025-12-11 19:21 ` Yosry Ahmed
2025-12-11 22:37 ` Nhat Pham
4 siblings, 0 replies; 6+ messages in thread
From: Yosry Ahmed @ 2025-12-11 19:21 UTC (permalink / raw)
To: Johannes Weiner
Cc: Andrew Morton, Nhat Pham, Chengming Zhou, linux-mm, linux-kernel
On Wed, Dec 10, 2025 at 09:56:45PM -0500, Johannes Weiner wrote:
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> ---
> mm/zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 5d0f8b13a958..84797ed4d3f5 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -141,7 +141,6 @@ struct crypto_acomp_ctx {
> struct crypto_wait wait;
> u8 *buffer;
> struct mutex mutex;
> - bool is_sleepable;
> };
>
> /*
> @@ -781,7 +780,6 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>
> acomp_ctx->buffer = buffer;
> acomp_ctx->acomp = acomp;
> - acomp_ctx->is_sleepable = acomp_is_async(acomp);
> acomp_ctx->req = req;
> mutex_unlock(&acomp_ctx->mutex);
> return 0;
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
` (3 preceding siblings ...)
2025-12-11 19:21 ` Yosry Ahmed
@ 2025-12-11 22:37 ` Nhat Pham
4 siblings, 0 replies; 6+ messages in thread
From: Nhat Pham @ 2025-12-11 22:37 UTC (permalink / raw)
To: Johannes Weiner
Cc: Andrew Morton, Yosry Ahmed, Chengming Zhou, linux-mm,
linux-kernel
On Thu, Dec 11, 2025 at 11:56 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Nhat Pham <nphamcs@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread