From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F57BC43334 for ; Thu, 23 Jun 2022 23:07:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9421D8E01A0; Thu, 23 Jun 2022 19:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F20D8E0192; Thu, 23 Jun 2022 19:07:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E0D78E01A0; Thu, 23 Jun 2022 19:07:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7033B8E0192 for ; Thu, 23 Jun 2022 19:07:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3DFC2124C for ; Thu, 23 Jun 2022 23:07:30 +0000 (UTC) X-FDA: 79611039060.07.440AF9A Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf30.hostedemail.com (Postfix) with ESMTP id 18BA080023 for ; Thu, 23 Jun 2022 23:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656025646; x=1687561646; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=9dK5AkiFzx6BZn0opH02USW8M+3ZT6QfoFeqIc0A1zU=; b=LTTFfmiqRvXAvoqOM9n0kDaNkscqEcp5iBQ56yp6L826EO9G5gcvOomS 5zZc19WqbEVHDrTp0Y1Lzcs8OEaLVEQSebc/qWQAkCuh5dw/mpl34qb4C Xeb6sHQAa80Tklm+eZ/BDJCEe3m1RBtYneAlR5ZGHVoS0Q02A9y3RYzXH ubQHWmj0HPZC1AH+xDqJ7pRnbKB0DHJJ1QuKAxHBz2efbA26LMoHFZj6F IsxOQu+FEchbmNNYRenT50bH2rq3QSQ+CIEJbX2pweHxo3p7t2rZxCtOE Bo/y/aBSSJNsDifaQGycXFBAil54Jv3tk+5D+u0VuzMd1E55aN1usphkB g==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261293567" X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="261293567" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 16:07:23 -0700 X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="915421573" Received: from schen9-mobl.amr.corp.intel.com ([10.209.125.82]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 16:07:22 -0700 Message-ID: Subject: Re: [RFC PATCH 1/3] mm/memory-tiers Add functions for tier memory usage in a cgroup From: Tim Chen To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Wei Xu , Huang Ying , Greg Thelen , Yang Shi , Davidlohr Bueso , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes , Shakeel Butt Date: Thu, 23 Jun 2022 16:07:21 -0700 In-Reply-To: <875ykuabth.fsf@linux.ibm.com> References: <94a10c772c50d378b81dad654476551bfc50e3d7.1655242024.git.tim.c.chen@linux.intel.com> <875ykuabth.fsf@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LTTFfmiq; spf=none (imf30.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656025649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+sceh007E4mHKxjmK7Qi3nXuglCvdQISqPDGD1Y3yBo=; b=7fnM/RF3BIkeaZL3yRqfDthL095yKy1TOAfY8aqdRM+9Ay9p25UpNNYrYiRutW4IhQv8uI 0uxOe//c4Oah58X6pu5O3UCyD+cCr48D0nU6AWa72FYYegFCoZj3/bTowIpAgduWbyBv0W O3gEJ61YGaDxjs+gyRU3+mIx5kKFlZ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656025649; a=rsa-sha256; cv=none; b=YUV1UKp7wcjQQqE2/oEiEcz1B0ilQJkzfVxODQ062HfqGIpXG7wINADd1RgmYw0K6OkE0u o+iBJVqwMMkWrdgicVECuhCW4H1K2wZIB8aqjX6RZ7xapA0m26KqODaIYLeK+ulJWdacHq qKDOUm/bRdr7ehb4H8ljmMyTvkYfmm0= X-Stat-Signature: 6oxd7uebrat76xosqkpanhgppjycfexg X-Rspamd-Queue-Id: 18BA080023 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LTTFfmiq; spf=none (imf30.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam02 X-HE-Tag: 1656025645-987976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2022-06-21 at 09:48 +0530, Aneesh Kumar K.V wrote: > Tim Chen writes: > > +unsigned long mem_cgroup_toptier_usage(struct mem_cgroup *memcg) > > +{ > > + struct memory_tier *top_tier; > > + > > + top_tier = list_first_entry(&memory_tiers, struct memory_tier, list); > > + if (top_tier) > > + return mem_cgroup_memtier_usage(memcg, top_tier); > > + else > > + return 0; > > +} > > As discussed here, we would want to consider all memory tiers that got > compute as top tier. > > https://lore.kernel.org/linux-mm/11f94e0c50f17f4a6a2f974cb69a1ae72853e2be.camel@intel.com > > V6 patchset actually walk the full memory tier hierarchy reverse and consider any > memory tier with higher or equal rank value than the first memory tier with CPU as top tier. > > https://lore.kernel.org/linux-mm/20220610135229.182859-12-aneesh.kumar@linux.ibm.com > Thanks. Will take that into consideration for future patches. Tim