linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Jiangfeng Xiao' <xiaojiangfeng@huawei.com>,
	"Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"haibo.li@mediatek.com" <haibo.li@mediatek.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"amergnat@baylibre.com" <amergnat@baylibre.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"douzhaolei@huawei.com" <douzhaolei@huawei.com>,
	"gustavoars@kernel.org" <gustavoars@kernel.org>,
	"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
	"kepler.chenxin@huawei.com" <kepler.chenxin@huawei.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"nixiaoming@huawei.com" <nixiaoming@huawei.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"wangbing6@huawei.com" <wangbing6@huawei.com>,
	"wangfangpeng1@huawei.com" <wangfangpeng1@huawei.com>,
	"jannh@google.com" <jannh@google.com>,
	"willy@infradead.org" <willy@infradead.org>
Subject: RE: [PATCH v2] ARM: unwind: improve unwinders for noreturn case
Date: Thu, 21 Mar 2024 10:22:30 +0000	[thread overview]
Message-ID: <bbcca1e205384cf0b42236e17f3969f7@AcuMS.aculab.com> (raw)
In-Reply-To: <bad25937-fc98-8e11-4279-ab6b3a727c1f@huawei.com>

How aggressively does the compiler optimise 'noreturn' functions?
Consider:
void f(...)
{
	...
	if () {
		...
		noreturn(...);
	}
}

Without the noreturn() call it is a leaf function.
So the compiler doesn't need to save 'lr' on stack
(or the save could be deferred to inside the conditional).
Since noreturn() doesn't return it can be jumped to.
Additionally 'lr' can be used as a scratch register prior to
the noreturn() call.

So it is likely that inside noreturn() (and anything it
might call) you don't have a valid 'lr' chain at all.
No amount of picking between 'pc' and 'pc-1' is going to fix that.
The only way you can find a return address is by searching the
stack and hoping to find something that works.

So you need the compiler to 'not believe' the 'noreturn' attribute.
Setup a normal call frame and put a faulting instruction after the
call in case it returns.
That would give you half a chance of generating a backtrace.

Without that I suspect you are playing whack-a-mole.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)



  reply	other threads:[~2024-03-21 10:23 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04  1:39 [PATCH] usercopy: delete __noreturn from usercopy_abort Jiangfeng Xiao
2024-03-04 15:15 ` Jann Horn
2024-03-04 17:40   ` Kees Cook
2024-03-05  3:31     ` Jiangfeng Xiao
2024-03-05  9:32       ` Kees Cook
2024-03-05 11:38         ` Jiangfeng Xiao
2024-03-05 17:58           ` Josh Poimboeuf
2024-03-06  4:00             ` Jiangfeng Xiao
2024-03-06  9:52             ` Russell King (Oracle)
2024-03-06 16:02               ` Josh Poimboeuf
2024-03-09 14:58               ` David Laight
2024-03-18  4:01             ` Jiangfeng Xiao
2024-03-05  2:54   ` Jiangfeng Xiao
2024-03-05  3:12     ` Jiangfeng Xiao
2024-03-20  2:19 ` [PATCH] ARM: unwind: improve unwinders for noreturn case Jiangfeng Xiao
2024-03-20  2:46   ` Kees Cook
2024-03-20  3:30     ` Jiangfeng Xiao
2024-03-20  3:34       ` Matthew Wilcox
2024-03-20  3:46         ` Jiangfeng Xiao
2024-03-20  3:44 ` [PATCH v2] " Jiangfeng Xiao
2024-03-20  8:45   ` Russell King (Oracle)
2024-03-20 15:30     ` Jiangfeng Xiao
2024-03-20 19:40       ` Russell King (Oracle)
2024-03-21  9:44         ` Jiangfeng Xiao
2024-03-21 10:22           ` David Laight [this message]
2024-03-21 11:23             ` Russell King (Oracle)
2024-03-21 12:07               ` David Laight
2024-03-21 12:22                 ` Russell King (Oracle)
2024-03-21 12:57                   ` David Laight
2024-03-21 13:08                     ` Russell King (Oracle)
2024-03-21 14:37                       ` David Laight
2024-03-21 14:56                         ` Russell King (Oracle)
2024-03-21 15:20                           ` David Laight
2024-03-21 15:33                             ` Russell King (Oracle)
2024-03-21 22:43               ` Ard Biesheuvel
2024-03-22  0:08                 ` Russell King (Oracle)
2024-03-22  9:24                   ` David Laight
2024-03-22  9:52                     ` Russell King (Oracle)
2024-03-22 12:54                       ` Jiangfeng Xiao
2024-03-22 14:16                       ` David Laight
2024-03-20 15:41 ` [PATCH v3] " Jiangfeng Xiao
2024-03-20 19:42   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbcca1e205384cf0b42236e17f3969f7@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=akpm@linux-foundation.org \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=douzhaolei@huawei.com \
    --cc=gustavoars@kernel.org \
    --cc=haibo.li@mediatek.com \
    --cc=jannh@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kepler.chenxin@huawei.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=nixiaoming@huawei.com \
    --cc=peterz@infradead.org \
    --cc=wangbing6@huawei.com \
    --cc=wangfangpeng1@huawei.com \
    --cc=willy@infradead.org \
    --cc=xiaojiangfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).