From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA3BCD11DD for ; Thu, 28 Mar 2024 09:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FF516B0088; Thu, 28 Mar 2024 05:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 888506B008A; Thu, 28 Mar 2024 05:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DA3B6B0095; Thu, 28 Mar 2024 05:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 490556B0088 for ; Thu, 28 Mar 2024 05:34:17 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 06C82410E6 for ; Thu, 28 Mar 2024 09:34:17 +0000 (UTC) X-FDA: 81945936954.13.57D68D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id E11C48001D for ; Thu, 28 Mar 2024 09:34:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BoHIGygv; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711618454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ZkO8G7dUIYKg9HYtYSV/Q/ao6mZL0iR8p+SuzdA7I8=; b=IDJlIz7Dl8jgu6XZcMM12MJiBVh6uGg6zTniqiXytR35mvZsqQp0SWx38xekhwwW7McWVX CLvhK85/bdPlm66idACykrwYVrOaR9EZK+NVD2Hx38RRroIubPMlHvUYfLHKyUcKErsgfc 6JF5uhrTrX6gGCRC3O9xpkEpsJNGwYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711618454; a=rsa-sha256; cv=none; b=7MaJBHDf+6i9BSDvyquaB8IO9ncUFwt3Mkdxzttrz/ikKpSqFKpBDxYlXKc51bZJpf042O SpNgshKMPFhQqQqx36WI2J53wDlDvoAc1K1tAPBjIlzDQR+rj7gh1CXJCK5o3HWl2HUMh3 Bjm6x69dkMlpOAb9iVG0wuk5hAZLptA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BoHIGygv; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711618453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/ZkO8G7dUIYKg9HYtYSV/Q/ao6mZL0iR8p+SuzdA7I8=; b=BoHIGygvzpPjb7T1MRlb5stAHNPMT8ISKshEtX27dK2fXGo1y55SSDaWhEYDIlCLYFq8X7 dRek6aJ9fAbo2KOj6BKYNlPEjDdqZl8j+RAso5pQqGFAhS63jPHAbA6on9skmmWogwYvd3 VHn5D9sfAxI8LZ5nIZy7QRZJ1tntlgE= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14-W45BE7yCMcSWJUjPpfpreQ-1; Thu, 28 Mar 2024 05:34:11 -0400 X-MC-Unique: W45BE7yCMcSWJUjPpfpreQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-51596f968c1so633071e87.3 for ; Thu, 28 Mar 2024 02:34:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711618450; x=1712223250; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/ZkO8G7dUIYKg9HYtYSV/Q/ao6mZL0iR8p+SuzdA7I8=; b=ihb/VqhKp2IoFu/H8I/Q9fV+HSD/Qi33xzDcuBQLrIvFwBWPBsF90aAx5uyq2vZhFW oZ1v53BLl09PJvq9u0ekuofH9x29IcB4exMAR1ii6lz0G09hUBU9dH/M8gzJvfdlEtN1 2V18PxS2VPe4hoBTAg7um4DGIi2AsCPwNQYFX5IBWasEwxF/RyAsndJbyA0+6dBBHZV1 omD6qfr0dGxfpLoKaXNIQP9SNSP2ni0VQMlq8tYujKvJFo4+JDFd6Ig6NLslw/6eqLej B+yrL4MDrrGo727SloZ9rdDvosKVzMyFKATACu1by1C+LHmvQcOzDDFu8QIPdaAcxIaD +5Zw== X-Forwarded-Encrypted: i=1; AJvYcCXkDrUvDRnyN+qnnY3vn1Az0pk0svgMQroThahy5NIabgSBSYg9mLVT/0E7UcknRTE4JqqpEYdAUvR8rS94P4mJq54= X-Gm-Message-State: AOJu0YxjDV9IQejlF0zQNrr3B29SEK3JRQ9fwx2x6iepHZJ01BQlXpBw FiAeDBhMUBTIP9oBq6WEcxP4wkV8OCAPZV8A+VSljSvRdRXnqcxxs/eCCh69Me1mMryEoJLMooH afOamvnNsHbfmd5mgk0ivJPY48LScC9iyCxe9ySHxrZAwmkYQ X-Received: by 2002:ac2:5b10:0:b0:515:9b0f:1235 with SMTP id v16-20020ac25b10000000b005159b0f1235mr1374675lfn.67.1711618449694; Thu, 28 Mar 2024 02:34:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErgecozQH+C47RHVDiAwA9NB+R7TzT83vOGfcPWn5XAWrfeXHki2nvXJMAaET7hkgfK3NFDA== X-Received: by 2002:ac2:5b10:0:b0:515:9b0f:1235 with SMTP id v16-20020ac25b10000000b005159b0f1235mr1374644lfn.67.1711618449205; Thu, 28 Mar 2024 02:34:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:3600:8033:4189:6bd4:ea29? (p200300cbc7143600803341896bd4ea29.dip0.t-ipconnect.de. [2003:cb:c714:3600:8033:4189:6bd4:ea29]) by smtp.gmail.com with ESMTPSA id ay34-20020a05600c1e2200b004149315600fsm4883082wmb.7.2024.03.28.02.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 02:34:08 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 10:34:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm: move follow_phys to arch/x86/mm/pat/memtype.c To: Christoph Hellwig , Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Fei Li Cc: x86@kernel.org, linux-mm@kvack.org References: <20240328084629.2955393-1-hch@lst.de> <20240328084629.2955393-4-hch@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240328084629.2955393-4-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: j7uqz6pj6kpegyxwh5g1wqjg9utkg7hs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E11C48001D X-Rspam-User: X-HE-Tag: 1711618453-427496 X-HE-Meta: U2FsdGVkX1+1Fyyu5T3cBMSEwe61+tV14Edq5IlwiWwI1Vjna9qEpa/6b07QKkn03y/tl3r3fgcCMxgPit8nJ8X+gykxr3j0X5eqiwl2e5xgtTH8j1t8aF005CHn1UrqIdYodH8rN+Cwajjccm2lU1hle4DEE6WHyTsMKyGfF03Lv6yYgHkvV8AcIC5P1BFyoQVpllfu06vJ/vD3PNdUaeB7e4ymwP4Umyee6KqNWYPhxf4BZjDvZsOY126pP/US+aNd2LyiqlawPuIqzFYu3gWsLR1XduiX/edJwndv5jSbjU2/HJmh90oU4ox2GgXJUYEhxak0H9zNVpz+kVCatPO4KQdCdbGxBi40DIqA1lSCNV2vre8fp9TRL1FIfq9zr7K2jzU4xm9dQaQ2tOFu8vhxMZCWAQtbtXSqgsqP7fW+9w1aOuVTKeYZCs2ZMAGuvcLi3AtdZjp/dtMkV2+ri+/Atfuql/3PAsMtQg7YEksIeZv3SybbUTeGg6yl6KE23RcRM310s8m28uDZaIvzVsqYFxM6FvT8S2SqellBuGBS3fgTyiBNL+y4zVAsgZ27yTjnL6N1q0R5yzZUzgJHvc6q41mqKfamWncKftQ4SCE/yN6IuSHLu2RUddHRYLbuzpptfDnWm0NmiNofG0BIw7Bjvbo//3avFVsDvakMd0iq7vH2ii0dBvGxZg7O7Ig/150jVXiYcK4ccthbc2J7DSQNy16YGbRBp8/ngEz3EiWvn/648WZGbgq+zONB4e3Adc9nNBQ4k5lJVrQFs+a+lZbp9tlrzBSj2Nux790UeffDY15LkOVTI7mSpUn/taISyjTB9+Ro032CvBaNERpJGz0MV0O/UsglrtngP0KBZzS6pmwATRNre9MLYY1nmLEB3LKesTutYIH5ZmLlUkEBIdz2Buh3SPW7+QteYDDjE/jdxQbg86+AAWhDkKjvzSYPQgCeLEUD4sRyE6PJtRg a25Fwwzk iQulp185yDVpuxowMV+Y8ZH+lS8O9jeUkyumPmVkBNZ6EDKnRTYtHwIgSuN013JJmARg4CnJ5qi4vSYOtVJ0D8scKBXlzj7Ub+SvAHL2yfFxhxr+qXjPI3Fmz3VkFxnRZdNYF8khzKh2LrykxJio5GmuKXanFkZ8/fxxvdlq/qZMWlrmCCeC17gfaD9I9PhHvlq/pEWnmlNKJy8C0yJdJtKs1hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.03.24 09:46, Christoph Hellwig wrote: > follow_phys is only used by two callers in arch/x86/mm/pat/memtype.c. > Move it there and hardcode the two arguments that get the same values > passed by both callers. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/mm/pat/memtype.c | 23 +++++++++++++++++++++-- > include/linux/mm.h | 2 -- > mm/memory.c | 28 ---------------------------- > 3 files changed, 21 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > index 0d72183b5dd028..c64f07b0fc2099 100644 > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -947,6 +947,25 @@ static void free_pfn_range(u64 paddr, unsigned long size) > memtype_free(paddr, paddr + size); > } > > +static int follow_phys(struct vm_area_struct *vma, unsigned long *prot, > + resource_size_t *phys) > +{ With an implicit lookup address, the function name is a bit unfortunate. "lookup_vma_pat_info()" ... not sure. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb