From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B65FC5B543 for ; Wed, 4 Jun 2025 12:22:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD3D96B057F; Wed, 4 Jun 2025 08:22:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAB896B05B8; Wed, 4 Jun 2025 08:22:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9ADA6B05B9; Wed, 4 Jun 2025 08:22:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9BFFD6B057F for ; Wed, 4 Jun 2025 08:22:20 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4F159BED5F for ; Wed, 4 Jun 2025 12:22:20 +0000 (UTC) X-FDA: 83517630840.24.75105D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id E63B3C0010 for ; Wed, 4 Jun 2025 12:22:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=REzkLS9i; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749039738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6lfXeT0z+TCzLVyd3cGFL+scSmu9BUEdMfvBKTxjadI=; b=LJ9X+8GtqlQfb3kOqnhvRe6LU6Sta6Rn8Hi3oGatJ9AZG9pRWEy4239ICHZyFZxSsxQwbZ I/N0DHp0XLpZEC9MXM+wyoUZKoPwtEVh3ls4T8zHlCTovW1fAmIo0bNwNbd86gpnzzvCri 8Ihi7YGk5O9ZubRRiXQ+nHaAYhoy6oo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=REzkLS9i; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749039738; a=rsa-sha256; cv=none; b=AvlZ0hPyp2QThhcBUOCkbQZj795tZ7SLpIlI/adTf5Oifp1qhWNDGKdCz7hrUAYmvJSj3V Fwx3GVpRj/M556/qvBi2bzaDgyNnlUoTtqWXW0FBWN9mJhLUhf8Q4NWyyVVJl80mGf12H0 TS5WA7GZ96Vtx+z5z1rSfkncRkKaelg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749039737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6lfXeT0z+TCzLVyd3cGFL+scSmu9BUEdMfvBKTxjadI=; b=REzkLS9iIFIcIXrxmyLGcQVa//qwZPTQvryK0hpH4AzfOKNnz2ho3cfwrRFh1nrDYvZJ9c P4WJe9rOnAPqlM7chaaJU5eqRZl3TRxkGIBn33sCUDGqxpgGLvEDOmwHcTD1nU7bdRqQV2 0bPc1cPXm2BnwGaKFmIjV+FmayWOeUE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-Dfg0b5s5OrikV-cHo5ISMA-1; Wed, 04 Jun 2025 08:22:14 -0400 X-MC-Unique: Dfg0b5s5OrikV-cHo5ISMA-1 X-Mimecast-MFC-AGG-ID: Dfg0b5s5OrikV-cHo5ISMA_1749039733 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4edf5bb4dso3723380f8f.0 for ; Wed, 04 Jun 2025 05:22:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749039733; x=1749644533; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6lfXeT0z+TCzLVyd3cGFL+scSmu9BUEdMfvBKTxjadI=; b=cnpoo+iHW2IdAspFaCv5XNNfaMOOnLTOpEud4LG/T+8h14t4fLWTkRkkVdQ/81KxG1 4W/zuutYtlmEQIdnjYqZqVpSpSXrcr7jm2v/TTq2rzLLLPc3P5HyakJWHdkNv4Hg2lQs pFjGmjQprX2iMicvjrqpBimlVlKpHRyOXuanvYcyTWEDm4aQFOkGaLtzSYo3LgiGRiq+ LInXcLre3AGFVUvtfWWyW0TnaXFiwm22/cVtISZi7CbfSrqehFCBPQHbYyV6FMu9mpa6 kKYptqZb2wzhvY3g2eZV7HmJ2ikItKAtlHkAR+uq46wPz/JGFN38ziiJM0zHXN69eAHi gHRQ== X-Forwarded-Encrypted: i=1; AJvYcCU3+KF1c9axWGqUj/Uz/tVWy/QZ9JAgFJSWDLR6jXgbCWkevkNw3PdJZtgH7+wzGgzD85HvVVd7Zg==@kvack.org X-Gm-Message-State: AOJu0YzJyjX4rCGvry01n5UWwe9kPQUKjHoYp+/ajX58ukiHp/RndmkF DeQgIvgqkAiC9sIZaNE8XyO8pG5xZelvPOGHSxQ5gPVZB98r8iX9423PV3B6d0WxQkuEhqUlwmk BHcUYUnyFe24eboxII/EAYjHcvHu9KPM4zTs12HuBOJ+AiJNxqBur X-Gm-Gg: ASbGncs9SD5AMtZNaygMYMdqSOS4sunkjgHRmGYRlMNeqBES3EURBVi8tGxlzycjHhG OkXzSwVMotWe1N0rltHjZ1e5x5PE8n0b3yCaiRt+cQuh3CjPl6iQV/0yUJbwE/CyblE1aAT/c9g k2FH/wep8TNAnGfpmrRCrjpDzrNcHOjwewv6ZIY3wBA5S7FxzucxP+hdyfHQZVQ+aE3cbOG+eGi ikM44USFAgKNK8YVK3bAMTRse30nEE9bZoOMoivcuDS9TXw7mp1exFVGmf9AULd+Wj4JCA46vZM IVE1oEwEB0XUqF1qnENDe1oYLr+0imnUlOmwpLhtwoKZ1NQAl/XYs29NKKd/xRjPGeVtPsMxUdM gwhrAIeXQZOAK0iotN2JiMv7meD+MZt3Kd7SLL/4= X-Received: by 2002:a05:6000:220d:b0:3a4:f50a:bd5f with SMTP id ffacd0b85a97d-3a51d969a2dmr2111961f8f.31.1749039733413; Wed, 04 Jun 2025 05:22:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFA9VuHpccMtdKKzp4Hz3kHndj5EggT/8SayDPYShxKlb0WORgYX8TtbaW4GT5gQgzKlo2NJw== X-Received: by 2002:a05:6000:220d:b0:3a4:f50a:bd5f with SMTP id ffacd0b85a97d-3a51d969a2dmr2111921f8f.31.1749039732918; Wed, 04 Jun 2025 05:22:12 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f009748fsm21291293f8f.80.2025.06.04.05.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 05:22:12 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 14:22:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/memory: ensure fork child sees coherent memory snapshot To: Jann Horn , Matthew Wilcox Cc: Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, Peter Xu , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250603-fork-tearing-v1-0-a7f64b7cfc96@google.com> <20250603-fork-tearing-v1-1-a7f64b7cfc96@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MsE1XO1g7ab7CAY1u-koBUZxCXYFDP2VVPV740A43us_1749039733 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E63B3C0010 X-Stat-Signature: z7km93cn4i45cx1ep9pkuq7r4hnxghpr X-Rspam-User: X-HE-Tag: 1749039737-62949 X-HE-Meta: U2FsdGVkX19ZcGMFnnAGzs0+IbNcuyBmqdE7mvLjbokZzq9CHO9mGbbgB6wyW67EPqOdf4CVskh5Hh3l+UYI+AOTuNAPCB5ZxLnD8Z/58bodG59aptzgDgfRWE7Q6fiGEUOvhaDPizuhRa/LvLEEPl0lwwjMrLAxu3Z7gcOZAYEr4ST2hq7ADjudtJSDYpJoNDBySh5p/5eSUmsXfPwCVu9GJQWRyvV0n2iRMEydnDkG4Z9PLqhR0KUBGIq+RRF8f6CXtMhZtXpxCgkT9QJsHlvm+sd3G1cxGfYK5p9nwlDmJOYpVoNGM8h9+utzeKAR24U9rn5ULxgR3ckUnSgp4gj2BvC6TmiZ04vzTffAZjSvlIuXENtEzOILkpca7N7AmVdqSI8ovGYJroSZiuzlTfUE2BAGhfwQiD2JHlxoui2+GhQAyQdvj3S6y9jxBMH1ZR7N8+WvSAemluruGVgyJulgKuPv1yS3ElJJykNJ6oIQy4Z4HXLwiZr6i0TvPvyIyv4fG4VrXBkDxrgJMcaHUV13n3BVzKHuqXt/LLeRfM+Ntr5Nd1cVYu2T11YHA9sBzvkYvbyQKHHd0JHCyAsR4F7GRHcODiQXfS+6faeavhV0pDpj6AeRcSqelTayQtbqFbI3T5AEWp58Oq2mTZYJYXojtO2+vpyFlY0Sf/fa8VSN4Ood2p5+tKtM5HvqIf21Bj+tV3Fa8kvVxW6PQmPVK6REcAWvTB/1h6IufetsEMg/FTiMAdTLRczN4qKneggtTpWVlIoUf3R6Nz8Klv8glwnvrwZoMdtVjmOUhvkSmEpcbFP2PgSbenUnQEz0LeZHGAhOM/kwpsgdT68UtFxlp5JEwKJr67UkQMOmJiIy1v5MjOtJV+jtJvgkF8hy8CKMVLyj+R5hOeHi8tuz/p57pfcn8CtZkspOdZBYxHp3fcUPLyz+/4TVJrXJhR+psJ66jklh1pN+55aenUSERNg Vb1omEm2 QG5dftmTiKh3ojHbIN3NbHyD8If85adgmY4MUC9WogkjNOyhMXvFDLlwjFuslTX3RKWR03LKVOzhizK2n/H2Tji9JEm49qIss4T4X6EZs99dwnQcxVO7HSJp43jydUqQH9yK2EmnFs4K7J6DzUvbiklCBQgM4z5+YZe4inHwH0wJY6jNJHlIJqSi3vdWZfsqV3w5UgjVUJzFBvGHXSpmlfqrdJRBMElHyS61sl7CI4AZ6DA1F+JiJ/Xjaf8Di9ZVjX3Si9LqcLgOkBgyZJSP6s7mZDLB0rP2lD4t4N/VE9nHZYx1KCQy718p68oJUhF4TonzuZRK1BPGvDR0vtpeOo+8YpaA7caaW6jXMpIoxTrlzR6a/TEN24nYxqdm+TODAw1xn73Crs02h2pSXNU+Wa7yM8vThQDlWAvpTU56/OxS+/JPBBpKjdxH7qFxGI35FV5JAPaHXwPtOK462lT/fqjb7Oriy2yrJ3PfG7z25f+eO/jrHnhbpPw7L/ZlxtkLJScwyEMj4vBOebVw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 21:03, Jann Horn wrote: > On Tue, Jun 3, 2025 at 8:29 PM Matthew Wilcox wrote: >> On Tue, Jun 03, 2025 at 08:21:02PM +0200, Jann Horn wrote: >>> When fork() encounters possibly-pinned pages, those pages are immediately >>> copied instead of just marking PTEs to make CoW happen later. If the parent >>> is multithreaded, this can cause the child to see memory contents that are >>> inconsistent in multiple ways: >>> >>> 1. We are copying the contents of a page with a memcpy() while userspace >>> may be writing to it. This can cause the resulting data in the child to >>> be inconsistent. >>> 2. After we've copied this page, future writes to other pages may >>> continue to be visible to the child while future writes to this page are >>> no longer visible to the child. >>> >>> This means the child could theoretically see incoherent states where >>> allocator freelists point to objects that are actually in use or stuff like >>> that. A mitigating factor is that, unless userspace already has a deadlock >>> bug, userspace can pretty much only observe such issues when fancy lockless >>> data structures are used (because if another thread was in the middle of >>> mutating data during fork() and the post-fork child tried to take the mutex >>> protecting that data, it might wait forever). >> >> Um, OK, but isn't that expected behaviour? POSIX says: > > I don't think it is expected behavior that locklessly-updated data > structures in application code could break. > >> : A process shall be created with a single thread. If a multi-threaded >> : process calls fork(), the new process shall contain a replica of the >> : calling thread and its entire address space, possibly including the >> : states of mutexes and other resources. Consequently, the application >> : shall ensure that the child process only executes async-signal-safe >> : operations until such time as one of the exec functions is successful. > > I think that is only talking about ways in which you can interact with > libc, and does not mean that application code couldn't access its own > lockless data structures or such. > > Though admittedly that is a fairly theoretical point, since in > practice the most likely place where you'd encounter this kind of > issue would be in an allocator implementation or such. I thought a bit further about that. The thing is, that another thread in the parent might be doing something lockless using atomics etc. And in the parent, that thread will make progress as soon as fork() is done. In the child, that thread will never make progress again, as it is gone. So the assumption must be that another thread possibly stalling forever and not making any progress will not affect the algorithm in the child. I am not sure if that is actually the case for many lockless algorithms in allocators. I'm curious, do we have any examples of such algorithms, in particular, regarding allocators? -- Cheers, David / dhildenb