From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA2CC43334 for ; Mon, 11 Jul 2022 22:55:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 259A1940027; Mon, 11 Jul 2022 18:55:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208CE940010; Mon, 11 Jul 2022 18:55:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CFF4940027; Mon, 11 Jul 2022 18:55:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F2343940010 for ; Mon, 11 Jul 2022 18:55:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id BFFF71202EB for ; Mon, 11 Jul 2022 22:55:51 +0000 (UTC) X-FDA: 79676328102.25.BECA00C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 5A004140072 for ; Mon, 11 Jul 2022 22:55:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A35A612F4; Mon, 11 Jul 2022 22:55:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30295C3411C; Mon, 11 Jul 2022 22:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657580149; bh=306Zt8on93XWkgQdga4uepYhOUdbfhX4MuA93F+mjDg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CK6oxDOms/jOi0NV/YznDDefa7DzL+1hTYbuZsX1ubF2D7Dc5bCKUoODI2BCGJX89 6NLGGeBf3orU1q8LBrJxMsNrQ0j6cVdbG3FhfCDMN0ZUKz6D4riXo6CB4iwPDRT739 WOsA0EPpXuYXczd0Z+7ZxV5U8ulJl+qvCV/9mIm8Od50we4E7mN8kQ/5NHAjIteesc FN/ZwBzoV7cycc328T5X0MdbBOZh++pvIOcHOY+cxZ32ENLjyEp+N/wTvpM+lrH73/ OAKQmoBmgIRy7tKoG4wIdPCUTRZq+cWBaLHhQcwgxOs/xFu2GAaqFudOGbWjPVirLB ATxDuYv4YevKQ== Message-ID: Date: Mon, 11 Jul 2022 17:55:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 08/15] nios2: drop definition of PGD_ORDER Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Guo Ren , Helge Deller , Huacai Chen , "James E.J. Bottomley" , Matthew Wilcox , Max Filippov , Mike Rapoport , "Russell King (Oracle)" , Thomas Bogendoerfer , WANG Xuerui , linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org, loongarch@lists.linux.dev References: <20220705154708.181258-1-rppt@kernel.org> <20220705154708.181258-9-rppt@kernel.org> From: Dinh Nguyen In-Reply-To: <20220705154708.181258-9-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CK6oxDOm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657580151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r3shUd3gzBPuldNw7CC7/zegDGS1ay3xxEGD9ZzmFSs=; b=L71BCM9TwlM5MSpzw3Edviq/CHg6siqt0PCZoqbSBbEZGXJzPqFQ0MFeg5Y9nPtt4PalrD X4fOIby1wATOgL1D+n88E6RwK+AommiGzYYA9O+pqluyTgE2KPOl31117nikMfJj5NrpbP dYARHI67vzy9G47DfhHdD+ra5P5N5QQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657580151; a=rsa-sha256; cv=none; b=PyMHDDL+Y5OFwmNZyq32OS9vzl6+wZ1RtvdzIBqZ6/9Fq93WQrklF426mECQ8qkuyy22yd 5A8v06LIezfvps64Yy68LpB9MrmwLadE7/EjunphtaT26ey/bWstpqP2dKyZfZTvHhjfOW qf90+m6Snc0ca/Fr5s3IuWF5+sxAa/w= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CK6oxDOm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of dinguyen@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dinguyen@kernel.org X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: ymprityxcc9raaoxmouzcdxhpwcqz61m X-Rspamd-Queue-Id: 5A004140072 X-HE-Tag: 1657580151-561552 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/5/22 10:47, Mike Rapoport wrote: > From: Mike Rapoport > > This is the order of the page table allocation, not the order of a PGD. > Since its always hardwired to 0, simply drop it. > > Signed-off-by: Mike Rapoport > --- > arch/nios2/include/asm/pgtable.h | 4 +--- > arch/nios2/mm/init.c | 3 +-- > arch/nios2/mm/pgtable.c | 2 +- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h > index eaf8f28baa8b..74af16dafe86 100644 > --- a/arch/nios2/include/asm/pgtable.h > +++ b/arch/nios2/include/asm/pgtable.h > @@ -68,9 +68,7 @@ struct mm_struct; > > #define PAGE_COPY MKP(0, 0, 1) > > -#define PGD_ORDER 0 > - > -#define PTRS_PER_PGD ((PAGE_SIZE << PGD_ORDER) / sizeof(pgd_t)) > +#define PTRS_PER_PGD (PAGE_SIZE / sizeof(pgd_t)) > #define PTRS_PER_PTE (PAGE_SIZE / sizeof(pte_t)) > > #define USER_PTRS_PER_PGD \ > diff --git a/arch/nios2/mm/init.c b/arch/nios2/mm/init.c > index 2d6dbf7701f6..eab65e8ea69c 100644 > --- a/arch/nios2/mm/init.c > +++ b/arch/nios2/mm/init.c > @@ -78,8 +78,7 @@ void __init mmu_init(void) > flush_tlb_all(); > } > > -#define __page_aligned(order) __aligned(PAGE_SIZE << (order)) > -pgd_t swapper_pg_dir[PTRS_PER_PGD] __page_aligned(PGD_ORDER); > +pgd_t swapper_pg_dir[PTRS_PER_PGD] __aligned(PAGE_SIZE); > pte_t invalid_pte_table[PTRS_PER_PTE] __aligned(PAGE_SIZE); > static struct page *kuser_page[1]; > > diff --git a/arch/nios2/mm/pgtable.c b/arch/nios2/mm/pgtable.c > index 9b587fd592dd..7c76e8a7447a 100644 > --- a/arch/nios2/mm/pgtable.c > +++ b/arch/nios2/mm/pgtable.c > @@ -54,7 +54,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) > { > pgd_t *ret, *init; > > - ret = (pgd_t *) __get_free_pages(GFP_KERNEL, PGD_ORDER); > + ret = (pgd_t *) __get_free_page(GFP_KERNEL); > if (ret) { > init = pgd_offset(&init_mm, 0UL); > pgd_init(ret); Acked-by: Dinh Nguyen