From: Usama Arif <usama.arif@linux.dev>
To: Pedro Falcato <pfalcato@suse.de>, stable@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
jannh@google.com, liam@infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org,
vbabka@kernel.org, chrisl@kernel.org, kasong@tencent.com,
baoquan.he@linux.dev, youngjun.park@lge.com, hannes@cmpxchg.org,
riel@surriel.com, shakeel.butt@linux.dev, kas@kernel.org,
kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH] mm/mincore: handle non-swap entries before !CONFIG_SWAP guard
Date: Wed, 3 Jun 2026 10:52:24 +0100 [thread overview]
Message-ID: <bcf95603-a04b-489e-8edf-b6bc4a42192c@linux.dev> (raw)
In-Reply-To: <ah8XqXQycZdbYFG9@pedro-suse.lan>
On 02/06/2026 18:51, Pedro Falcato wrote:
> On Tue, Jun 02, 2026 at 10:22:47AM -0700, Usama Arif wrote:
>> mincore_swap() also fields migration/hwpoison entries (and shmem
>> swapin-error entries), which can exist on !CONFIG_SWAP builds when
>> CONFIG_MIGRATION or CONFIG_MEMORY_FAILURE is enabled. The
>> !IS_ENABLED(CONFIG_SWAP) guard ran before the non-swap-entry early
>> return, so mincore_pte_range() can spuriously WARN and report these
>> pages nonresident on !CONFIG_SWAP kernels.
>>
>> Move the guard below the non-swap-entry check so only true swap
>> entries trip the WARN, and migration/hwpoison entries take the
>> existing "uptodate / non-shmem" path.
>>
>> Fixes: 1f2052755c15 ("mm/mincore: use a helper for checking the swap cache")
>> Signed-off-by: Usama Arif <usama.arif@linux.dev>
>
> LGTM, thanks!
>
> Reviewed-by: Pedro Falcato <pfalcato@suse.de>
>
> Maybe Cc: stable@kernel.org ?
>
Ah yes, I have cc-ed stable in the reply to this email, but probably that
is not enough?
Thanks
next prev parent reply other threads:[~2026-06-03 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 17:22 [PATCH] mm/mincore: handle non-swap entries before !CONFIG_SWAP guard Usama Arif
2026-06-02 17:51 ` Pedro Falcato
2026-06-03 9:52 ` Usama Arif [this message]
2026-06-03 12:07 ` Lorenzo Stoakes
2026-06-03 18:23 ` Andrew Morton
2026-06-03 2:55 ` Kairui Song
2026-06-03 12:08 ` Lorenzo Stoakes
2026-06-03 12:20 ` Usama Arif
2026-06-03 15:02 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf95603-a04b-489e-8edf-b6bc4a42192c@linux.dev \
--to=usama.arif@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=baoquan.he@linux.dev \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=vbabka@kernel.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox