From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E026C3064D for ; Tue, 2 Jul 2024 06:59:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32C106B0096; Tue, 2 Jul 2024 02:59:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DCE16B0098; Tue, 2 Jul 2024 02:59:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3EE6B0099; Tue, 2 Jul 2024 02:59:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F0A1F6B0096 for ; Tue, 2 Jul 2024 02:59:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9EECD12138C for ; Tue, 2 Jul 2024 06:59:01 +0000 (UTC) X-FDA: 82293910482.25.6A52A17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 62548C000C for ; Tue, 2 Jul 2024 06:58:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1+OATPM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719903514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/B0Z0MV2H+mXB99/Q2B+jnVb7kgZA+pZ2Hb4x6PDJ0=; b=WrOQATITMBX3d4auZDjMVbMqtcd2w2B5vjdOr5O/0jtcF6D53CVF6PQJ3OpGgLyLizSI1u QHxLIyKH0JgJa9Wlr3SDIHhUUMIRz4OtD1ATq3WJCuj3UcVqCA5ctE+II4SJKy8SQ7D0Gx 73R0+9H/xevxWhzg9EYufLM45vsPg5I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719903514; a=rsa-sha256; cv=none; b=BcgxXew8P/p0sETZ9HYTxZCkm2tWVHNSPHlrlo2Sfauz7y4VoZSMsOk2KtgI5ctF79GFEX jMlwx0sDoxhq01S637ubziNyD25ovXyCJkxtblCaGDQR83UANfMGcQcUQkB0Ba5V5/NvXt LVIaBTywGHdjDer13sXwzbmJTy7qQp0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1+OATPM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719903538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i/B0Z0MV2H+mXB99/Q2B+jnVb7kgZA+pZ2Hb4x6PDJ0=; b=a1+OATPMbLRYXo81JSJNnyY6C3Nb7tJJs/ZjVck1rzQnMtFYgetXjeh3fqnl+6AytA3E1P b+jQfD7OGCrvl4ibIy95nD3GTr1PvKYGtBM1ZqzgDWn3fxJIrTBtJbXBbTEmK9KwX8YfsA z4M6IFbFYe2gxEEZduN+AiNYZD777pg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-J3NxRAUVNfmHCsYSPdinHA-1; Tue, 02 Jul 2024 02:58:55 -0400 X-MC-Unique: J3NxRAUVNfmHCsYSPdinHA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52e765bc03bso3873296e87.0 for ; Mon, 01 Jul 2024 23:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719903534; x=1720508334; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=i/B0Z0MV2H+mXB99/Q2B+jnVb7kgZA+pZ2Hb4x6PDJ0=; b=lSv6BXDwY5nqtESC48DJ+zLGySWFt689QdiFHAEsx644SlRekKGmpkLfa+Cvr/4M3B yTuW8DVMJLuUqxOu3Oz8nczlW9sCsTQCPKT0hV7GW52CpD6z4dsV8DWiRuqbXaBHVOo1 TCmaA+YAW8pN4MJCJudggjr/Jam6c7DOj8T5+SuI3X3M2EesvMOERvjgyXaYu4P9LD2a /O5frVgEdkfW6xldbVprecUStiGUkjcz9wxtLxxdJ4p3liPKA3pijqelhtINEFNeLEWM k9I2eXicFSr9zpxFGHC6yCI3Rqqai+luwf7mg2eN0p38M1+Op1fBJr1PHVsDr2e27g18 9AHA== X-Forwarded-Encrypted: i=1; AJvYcCXv1XVjcxWlffe6LTYjWrsQU5BfImk/WoRiJGQMCTlJgZ+VLy0WCGlQgkg8LrP1CwMAC2hWIp1SeuKSUrPxezKX7Io= X-Gm-Message-State: AOJu0YyuZ2obOT7fR6+wP7RJGeWanOLh9XHM2mozSjF4t/XZ7NA4ahMT gSKVLQivk6uOAOSqS71DXBGlMl+K7eNdwWzcMSsmXp/RpVHhRb0zER2H5yekBmYNz0fJ8CV/6r1 rpYIKbKyCSTA6R+5IAmjl98gIp+fqNyvey+JsjHyll+M8CvUs X-Received: by 2002:a05:6512:33d0:b0:52c:d7c9:fb14 with SMTP id 2adb3069b0e04-52e826874e3mr5179923e87.34.1719903533787; Mon, 01 Jul 2024 23:58:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQPYNKgkeeEUSFtG3BTZIFflkQtmzxYDD6d1tPnsPFmy36k84hYXDu38iOEUtpfRcWMC6fhA== X-Received: by 2002:a05:6512:33d0:b0:52c:d7c9:fb14 with SMTP id 2adb3069b0e04-52e826874e3mr5179886e87.34.1719903532372; Mon, 01 Jul 2024 23:58:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:2400:78ac:64bb:a39e:2578? (p200300cbc739240078ac64bba39e2578.dip0.t-ipconnect.de. [2003:cb:c739:2400:78ac:64bb:a39e:2578]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3678a23b349sm410272f8f.36.2024.07.01.23.58.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 23:58:52 -0700 (PDT) Message-ID: Date: Tue, 2 Jul 2024 08:58:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: zswap: fix zswap_never_enabled() for CONFIG_ZSWAP==N To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Yosry Ahmed , Nhat Pham , Chengming Zhou , Chris Li , Johannes Weiner , Matthew Wilcox References: <20240629232231.42394-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240629232231.42394-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 62548C000C X-Stat-Signature: 8wtf81ha18ajyw5eb61pa4y45chxqxj1 X-Rspam-User: X-HE-Tag: 1719903539-146978 X-HE-Meta: U2FsdGVkX18Q4DNwn3qBb7AAzIp42wX+C1NzXOr6949zNasRA7GmuLGdpfI9a0aInM6mUXGhz8M9xs3apf7i/xkJuU4objd4ZpwltFzj/HIxCkHrzAhPkkJpCwWa+IlKkeOnHNMhiz1opI6goNN5bhOzMJ9V3WDMTkpQxqGgp/YMOGz5l5UMuw1jL+MIt3uoLdfJ2Rckci9SRZEeTJBMB9/oxKwBlXgAlb4sHV/yucfGZrnjU5P4AS80Jqe51KreBPmP+bJ5ARGIusLi+xx06XFAZ3VK2BO7eva9E/mihUNkW7Wql+d9zQjJt/+4XtpwwsrNtXvFOTk2waq3h64liQCM6dgx7R38kya7vNWoiDPrpRHnouMtWpUxzlvYSEke7Xfioh0UI2pDAAfxTOlqbdAkJPSo10Tq2PbKdnu2PvaCqtbKyjwZnd+uzxM6nuhZCYRrI4jaqrXEZEWQ2RAYMPN1iLJSR1VAR9pBzdMLeJrzWVlcEiVYovwtnAJJFNb3BZ/gac9vF76K7PN9FMLe5nfWm0eyFE4nbUEHTovgqld00jXOXRAp+2CKOPYENNEjjRxh//jxrkre2OlFe9iMNvzLO517ciMcaRFAGfEGbsmrSS3gfc0JSlXcYTaQTwm1aOxyK59WZMaTaCPxcGK/w89ouE9PmgCm7dYCKnVI4SurzVzqIOLb7Vjc+D4KdOFKgp6U5rX72bI1qzixvewY7i5oeF8tlvGCs/JF3vYBex+6NzJhFXcWw7fCjsqn/iMgaeMIZq55V3yIIGsgyjHvEsNIpzrioL6LaQYfAiBiyjSxgeuNrlVRghSHj4BwK2r9NhKEkizccrMXDHLVG8kmGMt0Flwe3ofchzPCoLRXPf1Q7BlNCQYm8Ks6D8HNvq4LIajUTO//4d7JVU9vl8JcTcaMx1nDNekY4FTcePMFA9mZk6et0JmMOjAizXs2vZCwsa9Qp13hvcOPCOIbK/1 i6Jz+QR3 u7J6rJKp3acD7KsLsgoybLIz/imO+ooFJSFnUxoCVEcipQix4Qd3UNKSL7RrQimXB6F1Mdfj4haDR0XfzHMZNIUdmxB9KpBQYZNqAYoI3+7TEQ8BINGpP0Q9ZW/BPPla6GL5ESi291ruFNViKLnUIOAB3LiVXyGhwkykcIm0Zm48KVgAXB6T8xAg7EtxiBo35GCkidqNj6rYhZQVz6SestndXt2/lnWXGncTwBdliMSbVl+lmj2iXcgXjFwoChaleAsWRSEpGo62qHoC1ZttT/lkPBWI07TRVtDFaCQ/xr9OqqPcLGHlrnjlowUgR5UtU05eH1aNP22DTyFuvfIBy6CF4Hn4m3Q8FXcugTTWdPqxrbSN+5MH0Cm0+5/hMyBYHOafUxSZ8qZa4fTT8UqJFuUdL9I28iNqZFuJkYiOYxAKf8UA24wySTtu4Dg4J8Z/Vx2iX3r3S9TAONM+nS8CowpX2BsIPWJQGQ433j3rGDd2BfU+tm0a9aotupBZ0jdBQI/V6GQBkjj0yPKeTehuOlroSmIZxsJAIqoF1ul/iObSYKCrbnHf77JvizPW2IKJ8HFhqhwqkSpBq4n3h4lWUuQiG4Lyxil7aTx5johJY5ZLcLOS+kV5ShwxQRilts/QGoru2EzraXxtNRC4ZOThTcY4jJYO/5XMpCtzcxUVFRZVbK537BAciBB0AiOSZUccWwiM2jR4ngQTdhsAmxaVaqdUkUSFXBZT+tsjn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.24 01:22, Barry Song wrote: > From: Barry Song > > If CONFIG_ZSWAP is set to N, it means zswap cannot be enabled. > zswap_never_enabled() should return true. > > Fixes: 0300e17d67c3 ("mm: zswap: add zswap_never_enabled()") > Signed-off-by: Barry Song > Cc: Yosry Ahmed > Cc: Nhat Pham > Cc: Chengming Zhou > Cc: Chris Li > Cc: David Hildenbrand > Cc: Johannes Weiner > Cc: Matthew Wilcox (Oracle) > --- > include/linux/zswap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index bf83ae5e285d..6cecb4a4f68b 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -68,7 +68,7 @@ static inline bool zswap_is_enabled(void) > > static inline bool zswap_never_enabled(void) > { > - return false; > + return true; > } > > #endif Acked-by: David Hildenbrand -- Cheers, David / dhildenb