From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC67C369BA for ; Wed, 16 Apr 2025 18:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEC0D280018; Wed, 16 Apr 2025 14:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9B06280001; Wed, 16 Apr 2025 14:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C12E5280018; Wed, 16 Apr 2025 14:01:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9EBB6280001 for ; Wed, 16 Apr 2025 14:01:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3EB11B1B10 for ; Wed, 16 Apr 2025 18:01:54 +0000 (UTC) X-FDA: 83340675348.27.CDDA0DC Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 419684001D for ; Wed, 16 Apr 2025 18:01:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=af8Zr8eT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744826512; a=rsa-sha256; cv=none; b=bBBhgpG13SU59Mw5/H9lie6eZXZQWiBGhANMCyjO7NnVp/a7kHUbPjF5VkzeYKQOrGAFHF NKdy1b5AtrlzPuaTIpr3jUXfkAqrRDD34kFyvVhl62xWIdLxctwsHYLRz8JfWE/t5smvUH kz+tDykU8KUKddRCnZBj+9lUxkyNpD0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=af8Zr8eT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744826512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ke1YrxQQmLR6ajJYMYuAIitTVymOTGcJs7MZD2ruDpU=; b=r/YIkU7wFSjRObpWOqMsEQ0Wt5uZCcGrFW5tSIlwUGDXVUS9XvlxhDWgUOrOmjcd3OlmgV oWLAlMuMwqn9j4HV/UNfcyTGP+g286lWoCXPM+Ivih7LPUhHMOnAE5m1TVb24FTh0Mn3sC zz60zxv1qJj924t7BaahrIUrfDPrnew= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-476b89782c3so72538031cf.1 for ; Wed, 16 Apr 2025 11:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744826511; x=1745431311; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ke1YrxQQmLR6ajJYMYuAIitTVymOTGcJs7MZD2ruDpU=; b=af8Zr8eT1Uq0TtJUWbERBS2X39nYuSQtNCUDjJGv6qC37Pp0O0SaUb5eOsrLFrFjDt HzMHf8WK4nR8iWkaZ5Muv7VYTQiXYveAssWqdwIOdUA2miv/DWG0cM33vQXy+2KXCsip oeXkprA/TOk8zMDJO/yM020bwPJg9NAlNFFivb6rOHl4M3N/GCKIuPeXlM5B5WV2OX4N XySalW4kckiuZ6SxVHkUM07rezrCs5v4E3H8HnYLMYREHv0ZUsPHJ0na307xCOO8udZE PZ9HmNBhHOl+3WwNTRtHhRbOcphOusdGaASt5kzju3tt4omRhwGTZBKJzT8dapGlwkxi jP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744826511; x=1745431311; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ke1YrxQQmLR6ajJYMYuAIitTVymOTGcJs7MZD2ruDpU=; b=coRDTz9wEqC8fBLY++ZTXXNeXlMd5kq1F3U8UtNHam0J+30wq1HO8EHYed+2Aw8U+L gMB+cK+PZqzkrIott5iwbryqr/cNZVllZUYCSLkOOHOhVhZXFf8YyP9KydPILuBDNLrO CMYPRvCzDhjB7I1tHnM/oyBU09wnYxw2aiiy0aWVEfR/WQpc0tIYwdenxJyEHoYEcSYd 8EqefsYzsDr6WaCW6jJ6FKg7jsz8/vnMARFVGlGy/grEzfYr0Snzj/BPqNYUquv1/5Ye eopNTmi80JOuLBLQmy8BaIFPYTQg/XDt4Vltxq2Bl5K5/FEVi8UpS8E85xTSoC6+1BdA InYw== X-Forwarded-Encrypted: i=1; AJvYcCWo2itN+lnymLVCgBHpWW4cjP3kRB9WG0y5+CEvHgi4kDRT56hZPgYKlk4W34mozPT1nL7bEs6saQ==@kvack.org X-Gm-Message-State: AOJu0Yzw+jdCXSF8UXpD79h4B1OorsRgwD2C5lhE3PdQ3AMla1qp6JO0 7oGlWI2bb66N2io6R2GzVW6WS9q/BXSXmJUd8zl3moGqRX68wLUW X-Gm-Gg: ASbGncsWIs0iEJAp2TAE9o7c5btM03XqmMgcqn34RLw2owkc7kpTNVmGMBBHjvsNVN2 5V96yPZogHsWPTxVnhPA2kHPVg1lcUYGDj7vUTNno9dCW/IuhV6WavKLxDYqfkEGKpwzKMxLhB7 IKjspd1wykEK96+elPWI92waTXgzdTxAgK6qR3mcyIJB5aF3+kDIWms2AyNoAls/HdKcVwJaZzP bZMT136mgIoiCshTGXrGAuGu/UnI9DAZHC9psi5VYKaqeVTzSpoSDR3FBdfrYjiU4tyHnYcezbV sKhmS0omUNnc8SJBfbTcXftxjyjeHYqVZfHJNhrssNEUPE62UNuitMB4RQr4kUDS1V94cM9/ X-Google-Smtp-Source: AGHT+IGhsO6K/MdxArhwu+UIFuP2aWlgtxAKLQqrnXCnrmpcCUGM9u/wAH1270OEw2RxBR4zOD7IjQ== X-Received: by 2002:ac8:7fcf:0:b0:477:c04:b511 with SMTP id d75a77b69052e-47ad80d3836mr46787771cf.31.1744826511232; Wed, 16 Apr 2025 11:01:51 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1151:15:b31:ddc1:afa7:7c1e? ([2620:10d:c090:500::4:d585]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4796eb2bd8dsm111652001cf.35.2025.04.16.11.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 11:01:50 -0700 (PDT) Message-ID: Date: Wed, 16 Apr 2025 11:01:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> Content-Language: en-US From: JP Kobryn In-Reply-To: <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 419684001D X-Stat-Signature: 1t4ezicp49ncs6f7nxoumicf56a6ibmm X-Rspam-User: X-HE-Tag: 1744826512-522539 X-HE-Meta: U2FsdGVkX180v0El5Zw+IvG0qHCioqm/C7KV0zsywwdhshxrDD5d8+LPA0gGzs/Hsfb794cdONScBYmg7EVKCnIt+DYfStyA9hQ0ZdoH8bbYJph0D9uYKz5fnBO0fiXP/L48kRVxhDY8I0RsOgRVhfxeT70eTJ6YmT+DFvnFXQv3LaRCKQvfGkZqFlx6IoSasAUj2IBsip7bOu7llmkHQsv1WtCyzDVhUTvtOfTDMYJVMTcjXF6v+fkDN3PXhSmuyXd4QpVPW4LanxVb2bDp9yBHv5uAxTBBDy7s88NlLII8ceuP+NqA4G8WHk8u7GBYr9M/3abRBA09BRMPvPOwMrjgldXtxTgD00pMdDnFnsIcoNYEjGJwdxgOLR6yvq6MreG8S8GUjemEj/l06i6qhgQsuhhuJ9Zbm5aI9iiNyeXBhCgNootDAIDr66IWH0pak3a5Om5aHwXCmIfa3dO5VIYPc0KdyP4f+SqXYUxj5eVvxQzyvjuimGZtZtap5T8PoXZ/SUAdHa1LvaiukR5IiTVAL3FKz6vVmou+cFPd93DO7C2pgtbjLBuNcwGJ9DI5DxZUzAp6/eJRWv6jXkEFb3I96urxJSGESyYiDymnUnfQw5rJggIl2Sfn3pM2ZuxAkh3hGmXsZlP3zTZ10HMrv6QH5jIBo9mcDQXJ0iYy2l4cFF+QjZ219NBQvSvvv+8xsFOeernfubGr2yxsanviEsNlVK+ff0ByQ5A2kfszYsPlOtTs6T+/RUvTgk/xvuo/PtVyyyURSKzdcif0LF9z/3iSlQrhEj6aCzEp9zqTA9I6DT4cQivJQHyw9hjtpqtGUE9OnO0QgPLsre0sHRAPZTqxBDgY/R5Z1gkG+me/T2MhgxyUnD7SQ3Q51bZxoxnKMRFu6F/Dg3+8IB9AdzYm0gm20ZXrB6+MO3RiQPAGPhHQYwnAJtFhgwCgLms065J/hvNsSEMCi27dJ3jx7e7 t80mjrZR 9p1u/5Icd+0m5F238P/fNzyQmXacAf2RUwltuQnkhfDPHXb3Bdd9p4sYu9H/LbSViEqm07fQkfzbbCABXvF+wzt/4mMDhq+KEdNLNfMjkqQw9qeNpsyUz1phiCApZx1xyB+UrNew/X8NB3aeX0cGYuvf7L3wBwGDn0vGIj5C0k5AWvO1cjPEXcu/Be6DtqNI5FhPqdHF0wgweMWbrCa1apxBD2Q3hhtoynD9ECS2x+IgXL5FqPunNdWEbnzS8XppYw27KBuE9GKpJ7r+Zve1Rf2PeDNVU+7qySL+DsYJl9p5rnDIQRnrQq1R06u5ZJJhgnhdE37SwPqhIfhXfJ9ZLwW+/N03KTwY4R26K2qgoWiWDM6cV2mNGFrb+P42VzAhMIcuL4Dr9WRf3Gm9ihkdaVhfJoTQvY9OBXKrtUQ78w3BXcqOn1idIISUm4uDbse991wGGUcAsaqJ+GcolrjpgXdyEMT1X+4ePEVvFxVFeyuH/1H5L0CGeWJe5wqZSrVUt+fbV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/15/25 10:15 AM, Michal Koutný wrote: > On Thu, Apr 03, 2025 at 06:10:50PM -0700, JP Kobryn wrote: >> --- a/kernel/cgroup/rstat.c >> +++ b/kernel/cgroup/rstat.c > ... >> static inline void __css_rstat_lock(struct cgroup_subsys_state *css, >> int cpu_in_loop) >> - __acquires(&cgroup_rstat_lock) >> + __acquires(lock) > > Maybe > __acquires(ss_rstat_lock(css->ss)) > > It shouldn't matter anyway but that may be more specific than a > generic 'lock' expression [1]. Thanks. I see what you mean in terms of improving the output. > > Besides that this patch LGTM. > > Michal > > [1] https://sparse.docs.kernel.org/en/latest/annotations.html#context-ctxt-entry-exit