From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5A9CCA47C for ; Tue, 14 Jun 2022 13:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 398016B0078; Tue, 14 Jun 2022 09:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3483C6B007D; Tue, 14 Jun 2022 09:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C23A6B007E; Tue, 14 Jun 2022 09:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B24C6B0078 for ; Tue, 14 Jun 2022 09:08:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id D0B7B120261 for ; Tue, 14 Jun 2022 13:08:48 +0000 (UTC) X-FDA: 79576871136.17.22DAD21 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 928BFC0098 for ; Tue, 14 Jun 2022 13:08:46 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A253BB81865; Tue, 14 Jun 2022 13:08:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2081EC3411B; Tue, 14 Jun 2022 13:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655212117; bh=EZWyEzJis+wg+PHTrtf74/eJzbtQm0oSGOp6nBki/Rk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AHrZD7735QNaoCMuug4m4qn9KDEQV0TbICVBpz+nqBEOQCVpQ60kgseLGx6wx4DyY A/CS2P/thli6EBiDkEiUayVVmhgyskPzplaDm2HqJeYNnEsxvwoMRRHT7cco34hTvi ca4wyxORjxPgD44fL2mBeCA+aOSR2lPKCXDade6oMAyCZSyhDnw19SDWPGttx5R1R9 pr3Srk7PmSU9/NFBH3BypFwJL0zPQWXY1N3+Vq5MezkjHRpUyE4iq5F5WJ0GQKrvLW kJl7EWKB2wL18RUY22AXcOYO1hYsQWoa8stdoUgeVt/lS8ibbeKs3mo4BcaUJrHXqr 6YIuDW6u3H10Q== Message-ID: Date: Tue, 14 Jun 2022 15:08:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/3] mm/mempool: use might_alloc() Content-Language: en-US To: Daniel Vetter , LKML Cc: DRI Development , Daniel Vetter , Andrew Morton , linux-mm@kvack.org References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> <20220605152539.3196045-3-daniel.vetter@ffwll.ch> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20220605152539.3196045-3-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655212126; a=rsa-sha256; cv=none; b=dTO7OqSodq7ljEyr/zOAhq61+I9eehTG3xmnrS1z0wBhf/R3mr6oaBkykR77jVBfF1/c+F dJi8t/oBQAd+TenmSnjgRVfNJTcacDjJAkSfYoQQdHZnoBiXmzI2nuNCsawPyPRXs+QcQ/ tz1D8hPSBlahGHp7bNRhQu74GpmqO4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655212126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1xZO7zgQuxPInisCztAqkUJuVFugKBcfTgsPE/l72SU=; b=lIHS3mpDzXEws4uqy7bIA3/YUZVJbEDDr1vmjUS6gqbQTnQc3jIMKb9sV0o7GPYyMo12uK WxV7oExuFDdtSDDXDzr1RrWRs64C08dXIKDptfuU9B5PlKqnhdpK1VbzniqPvH4b944dyy A3XVF7ccYLbfgf3ZB+/0r6V2mzMGHS4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AHrZD773; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of vbabka@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=vbabka@kernel.org Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AHrZD773; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of vbabka@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=vbabka@kernel.org X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 928BFC0098 X-Stat-Signature: gmfi5yfqyxnpdagxxejqspcqr5cu3rfj X-HE-Tag: 1655212126-572306 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/5/22 17:25, Daniel Vetter wrote: > mempool are generally used for GFP_NOIO, so this wont benefit all that > much because might_alloc currently only checks GFP_NOFS. But it does > validate against mmu notifier pte zapping, some might catch some > drivers doing really silly things, plus it's a bit more meaningful in > what we're checking for here. > > Signed-off-by: Daniel Vetter > Cc: Andrew Morton > Cc: linux-mm@kvack.org Reviewed-by: Vlastimil Babka > --- > mm/mempool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mempool.c b/mm/mempool.c > index b933d0fc21b8..96488b13a1ef 100644 > --- a/mm/mempool.c > +++ b/mm/mempool.c > @@ -379,7 +379,7 @@ void *mempool_alloc(mempool_t *pool, gfp_t gfp_mask) > gfp_t gfp_temp; > > VM_WARN_ON_ONCE(gfp_mask & __GFP_ZERO); > - might_sleep_if(gfp_mask & __GFP_DIRECT_RECLAIM); > + might_alloc(gfp_mask); > > gfp_mask |= __GFP_NOMEMALLOC; /* don't allocate emergency reserves */ > gfp_mask |= __GFP_NORETRY; /* don't loop in __alloc_pages */