From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEC3BC43327 for ; Tue, 30 Jun 2026 15:15:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9635B6B00BB; Tue, 30 Jun 2026 11:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 914716B00C0; Tue, 30 Jun 2026 11:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 802FC6B00C1; Tue, 30 Jun 2026 11:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 56EE76B00BB for ; Tue, 30 Jun 2026 11:15:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DDA80140500 for ; Tue, 30 Jun 2026 15:15:25 +0000 (UTC) X-FDA: 84936927810.18.FBADFF3 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf17.hostedemail.com (Postfix) with ESMTP id 64FC14000F for ; Tue, 30 Jun 2026 15:15:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DbCvN2a+; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1782832523; b=zUDYXyTmX7a+0v9AlU1MoQOrL/sUCsSS6KagSKojZ0P9A6H5XLZIB+aPXhfBP5XakUQQDb KtY+z7gFEN2JNY8D4xNJAP7thd8HiQI2OkrpdGyiniarRuuQhlF39YAcgnvGeNUr6NqmDt CnbwtMUR6Ovr4JP0J146jvj0uaDxWB4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1782832523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NJtdwo7CYpqk5QMqp6wZod8zu4LWb5ufSk76ZdNMOmw=; b=wxpOImwqw+W7ooILEXlMmvWMHuCwfio7R9wcT1LiPh/zvvBAZPzNKGmlAWuDBzYm8gk6DO y2wIrUD7f+wQxVu5O3O81eihMzZrHuyXS4XwvyszGdawAv5vM/2KYhFI6OVNrQDh5Lbvzw uBycA+ryL1bHXW6vcozqx3LV57uXLg4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DbCvN2a+; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782832522; x=1814368522; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=f1c4FlMC3olZxC3giH+6deLBbehRifubsyfC7HTpIQs=; b=DbCvN2a+J8mGCDLk4N6ONy9URA/seKhBvnAZGuMnX5AtxXzpdbeTbBIm yBKEBCW1Ll85lvjwdMsGYkZj0ikBOb8A/qRiv/+53vV1Tr/UAyvsEuHwi iFgA/uPTFloCwDlQpuQ5b/lLCiSHlW3dF+EBn7Ew4ymPZz0bcuounr2lj JrbXA0agnSmAbd/ctHyt3bmMlzmPSoh4syiFUOApd8EbiSg/ICbIY4QEv Zh3SefjnVmp8iRT3P2AkXp6HNzmH4kec0CGOQ7NEmY4c/TuucsIv7RfwO OhSrfC/GdVglSgHmcGSMdUlqjVDPu3B8zV0cAz953H2joZC3gC7OhmVsd w==; X-CSE-ConnectionGUID: cIowe3LwR4eaPIHTn3kZAQ== X-CSE-MsgGUID: lAxjjsMyQlWUvQNh3YhUmQ== X-IronPort-AV: E=McAfee;i="6800,10657,11832"; a="87386285" X-IronPort-AV: E=Sophos;i="6.24,234,1774335600"; d="scan'208";a="87386285" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 08:15:20 -0700 X-CSE-ConnectionGUID: lstz0gkFSimhaXBdx8wchQ== X-CSE-MsgGUID: NMO51T81Tk+iW/xUz5199g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,234,1774335600"; d="scan'208";a="247820700" Received: from jmaxwel1-mobl.amr.corp.intel.com (HELO [10.125.109.240]) ([10.125.109.240]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2026 08:15:18 -0700 Message-ID: Date: Tue, 30 Jun 2026 08:15:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/vmalloc: widen guard region to defeat ENTER-based stack pivot To: Pedro Falcato , Xiang Mei Cc: Kees Cook , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-hardening@vger.kernel.org, Uladzislau Rezki , "Gustavo A . R . Silva" , "H . Peter Anvin" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jennifer Miller , Tiffany Bao , Ruoyu Wang , Adam Doupe , Kyle Zeng , Yan Shoshitaishvili References: <20260629214712.1198680-1-xmei5@asu.edu> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64FC14000F X-Rspam-User: X-Stat-Signature: c84ttxrureuqwjw1eades4751w7yc5d8 X-HE-Tag: 1782832522-909903 X-HE-Meta: U2FsdGVkX1/0OMsBreWM9qDdXKmFUiiRKb4vnx6f4+sO6GYilk3qADAsDmyXNv8V9pmqiVsmjP3YyCS84+enrtzUQCJtPnfJoWbPSkRM8G7Dd8Ar7JrJ/bPm/LaxAEablJzrIS1PC2pj/S46b3c+FWIrqaIAaXS88zCI80OIfXlHTg9WTx1JTc3YRc/C4cZXOZlZ/6wJ7NqUqCKPBkCjGVqjvZpa5kLWAzjmxxSyAmEzAfv1CDxJHyHPcyiC08P8BvGQn3F4UhrxzzAB0FSedjghA6kD72QlSN/6NVTCKCIf3Du78Mi84xRqOylK5NnFTjpng/ZjYczZ27eo+sAInTC52I3hU2rF7COl2sh2sz4NlCEWkv+GlqIf5TWzphYXxOMyBmFU7gZ9u9UXDg1HtFjoFlf/SEsqhnslcTAp+2mvLcRyhOoAqcZR/OISo4dNfmoWsHUWiBFY44nHbyXI4Zjinbu/V9CDdVPYlOsYfu0rr8kL3rbf6e3umZ0IMGEX5DgpXFdBno1jcmMuCuFXdyv7TtqIZjqIt6N781iWre1OZKJwVPVLtpPvZwEMfH4lIQ4TBuM3Elo1A3YatSAqbkZ9NVejjCmrq8WBtHyS5H4vPlA4rzS3oBMw3eETYqrjzAAAppe6mmjKN3a8Eu/1DhqKkcJbA9G9uSObu0Yp2CU3YJ6x95XrILOYWerrzUPvAqZcx3QRc8trVdJEUB3W4MNKJ+vrRL3N57814h0LS5cCT9rt9YJSYQJNYiEpwHUaj0Y2YInpuEopNJa+vb9/SNGK9gJF2eVygaifGdRNbNFgaCcjzc+GLufFGynQVeKnYDchl8IYUF4hM5/SRO0ABQngn7HPIrAnMMmHAeRDJCLA1/10YhPLiOh4ExjXuMgGN/ncO+F8Es885xDtyirBqJ19KM3QkeWCoIEDiiSnHKUm65vgyB13WCCJeTCe1aORVDfffj0umbWpxYXkhY0 izZ27/hb kJflJPmnPWcV+dMyKjKXC5W6C72lTysOVVPhnsGRXeyK+tGzjiHGgfqumw2Q2KEkZejgJEqcH/XN2P+5SomJ26h4s370Bts93DCDEa2SCjuEpVrpRTN6h/G5TwUdnaAA/E5qdo2R+hhpQbq7af4E+WEP/t/nzOnl9nzIKx1rEzWGR4DiWVrcdaYgXAVsE1D+uZa+f4hyo/ToHCts= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/30/26 07:40, Pedro Falcato wrote: >>> To even be considered, this series needs to be refactored properly. >>> Making this VMAP_GUARD_PAGES a separate patch is the bare minimum. >>> >> Good suggestion, I will do it in v3: >> >> 1/3 - introduce VMAP_GUARD_PAGES >> 2/3 - mark percpu vmap areas VM_NO_GUARD > I would suggest you create a VMAP_STACK flag and condition these guard regions > bsaed on that. Otherwise it's a bit arbitrary as to what callers get 0x11 guard > pages, and which don't. > > (you can find the concrete stack allocation functions in kernel/fork.c) The real question here is whether VMAP_STACK is a good idea or whether __get_vm_area_node() should grow functionality to manipulate guard gaps and then just have the stack allocation code use it directly. I, personally, despise code like this: static inline size_t get_vm_area_size(const struct vm_struct *area) { if (!(area->flags & VM_NO_GUARD)) /* return actual size without guard page */ return area->size - PAGE_SIZE; else return area->size; } I'd *much* rather it be something more like: static inline size_t get_vm_area_size(const struct vm_struct *area) { return area->size - area->gap; } for example. Looking at every use of VM_NO_GUARD, I think the kernel just gets simpler if it goes away. It's only referenced in 6 sites: 1. __get_vm_area_node() - Munge gap argument into 'area' 2. get_vm_area_size() can be replaced as I showed above 3. kasan_mem_notifier() - just pass a gap=0 to __get_vm_area_node() 4. kasan_alloc_module_shadow() - just pass a gap=0 5. check_sparse_vm_area() - check area->gap instead 6. Just remove VM_NO_GUARD checks. No flag means no munging the flag.