From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2148CC433EF for ; Tue, 12 Apr 2022 00:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A38B66B0071; Mon, 11 Apr 2022 20:59:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E7AF6B0073; Mon, 11 Apr 2022 20:59:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D6516B0074; Mon, 11 Apr 2022 20:59:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 7B0EB6B0071 for ; Mon, 11 Apr 2022 20:59:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D0721EB2 for ; Tue, 12 Apr 2022 00:59:50 +0000 (UTC) X-FDA: 79346419740.03.32A8430 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf22.hostedemail.com (Postfix) with ESMTP id 549AFC0003 for ; Tue, 12 Apr 2022 00:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649725189; x=1681261189; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=ID7Dlx34WXaq5itFE0ozcc4Gc9FFa/Ra2b7+KNAMdtE=; b=fPvvFrT0wi8kRYezdxHlDCOzlQLsG5r7aOCtz2Qzhf93BF7pjxSnPIbP DcBaXjeaeGVAREkn7QqG1PodMstYRNBqu1XSwjclyLedesvkO2zMJs8HN I9LnRYZPxeBPu5ePmM9q+4cbClrP3y4sFG2oL3Ye5Si4dHbw9MGjQf6lL sTA9EIFLxEFmD7zaHU8I3edrkP8z3fMSOx/1RVUWyVNG0tOFwtaSSGwQm M/XxlU752kpK5c7kGkr8J9kkdWOYnLara0+kiXwz/fDVIL5RqRDXoXPSw 2pAdXPEu5GOGP3ylI5pAG3rrZyTw9YqwZ4GPNfJq9zGrHVjjrn8xCQCri g==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="249531678" X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="249531678" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 17:59:47 -0700 X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="551469928" Received: from joliu-mobl2.ccr.corp.intel.com ([10.254.214.243]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 17:59:20 -0700 Message-ID: Subject: Re: [PATCH v2 5/9] mm/vmscan: activate swap-backed executable folios after first usage From: "ying.huang@intel.com" To: Miaohe Lin , akpm@linux-foundation.org Cc: songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 12 Apr 2022 08:59:17 +0800 In-Reply-To: <20220409093500.10329-6-linmiaohe@huawei.com> References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-6-linmiaohe@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: cm5dkuh9s5b9d9pk58u6wwcfi5d6aqtt Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fPvvFrT0; spf=none (imf22.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 549AFC0003 X-HE-Tag: 1649725189-15821 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2022-04-09 at 17:34 +0800, Miaohe Lin wrote: > We should activate swap-backed executable folios (e.g. tmpfs) after first > usage so that executable code gets yet better chance to stay in memory. > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin > Cc: Joonsoo Kim Reviewed-by: Huang, Ying Best Regards, Huang, Ying > --- >  mm/vmscan.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 0e5818970998..cc1193e320c2 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1412,9 +1412,9 @@ static enum page_references folio_check_references(struct folio *folio, >   return PAGEREF_ACTIVATE; >   > > > >   /* > - * Activate file-backed executable folios after first usage. > + * Activate executable folios after first usage. >   */ > - if ((vm_flags & VM_EXEC) && !folio_test_swapbacked(folio)) > + if (vm_flags & VM_EXEC) >   return PAGEREF_ACTIVATE; >   > > > >   return PAGEREF_KEEP;