From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F061C636D3 for ; Sat, 4 Feb 2023 06:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A6D6B0072; Sat, 4 Feb 2023 01:27:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B175A6B0073; Sat, 4 Feb 2023 01:27:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A05C96B0074; Sat, 4 Feb 2023 01:27:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 917AE6B0072 for ; Sat, 4 Feb 2023 01:27:26 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5360580166 for ; Sat, 4 Feb 2023 06:27:26 +0000 (UTC) X-FDA: 80428627692.04.67FE333 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 33B3C140002 for ; Sat, 4 Feb 2023 06:27:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2YwQZp4m; spf=none (imf09.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675492043; a=rsa-sha256; cv=none; b=jA0GMouUTUi8R5jTmiL2vpUXBQzgXopbUrQePAKlAlU940ZNR1+PS4/PeDZapiCvJSbDWh MoIU70aJ0YetXdJegEN1/+loKsFaU9sHsZIjlhnl5sNLrNvTW2Vr2ye1gn0Jer94PAbfoV 3xxv0eZqh2VtJwzuKQR75omRZ07GxPM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=2YwQZp4m; spf=none (imf09.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675492043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7nzow32rldzNRE37/7gZLZ0DJPZ4skYJN8/BZlQpFHk=; b=ExNTPpDHrdkfFW08cQhNwXHh1NO79C4YgFaEXI7FjQr2jms+i6Obf0XOSaO7utJH1iJ3+G JABHo/mCxBzZT0OebTS4ipTSbRHQPYXzOxiPm5qOsA6Jopk2yIYfaA56KcUw0taqi6GzjK AbtBqelHGr+0JOvLFyzWFlwFSkS+6yg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=7nzow32rldzNRE37/7gZLZ0DJPZ4skYJN8/BZlQpFHk=; b=2YwQZp4mtMaTi6AM43p5TdTgtO 8J0TesrZJTOBzm7aN91x/naDVgRRjh48UwOwfHeBTI3n5C2I0fWIA68N09Ba1K4Jd06s3hYG8XoPE hPY53X1MBuOUKpHEUXfabdD/nMFHMYOO/fKPcfImJQfASBkJg1swSQsiAk3X6ehtB9433TMtnxW6M 4ca/FY7SUkAjLnbr0hvoL/1n9FOKTEn7PQyk78FM/4t9+phXP6Sl6fhVyjaBVLKKh7PfAQGNJbr/r Lk3GybijmUv7VogKD0lkUWRhDupXzi+TvYDgNuPUnvtbguJ1ziyyJNHOvg35NGM+Q1yzolAzwLlRE 2UVQKaoQ==; Received: from [2601:1c2:d00:6a60::9526] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOC12-004ZAV-3y; Sat, 04 Feb 2023 06:27:12 +0000 Message-ID: Date: Fri, 3 Feb 2023 22:27:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] kasan: use %zd format for printing size_t Content-Language: en-US To: Arnd Bergmann , Andrey Ryabinin , Andrew Morton , Kuan-Ying Lee Cc: Arnd Bergmann , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230201071312.2224452-1-arnd@kernel.org> From: Randy Dunlap In-Reply-To: <20230201071312.2224452-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 33B3C140002 X-Rspamd-Server: rspam01 X-Stat-Signature: n6r5puxfdxee69x3mpniomtz1675d7gr X-HE-Tag: 1675492042-615823 X-HE-Meta: U2FsdGVkX1/o2x37kFDJ21o9asO2IMj6la7qoMwMwAo42Yww0f991uV1k7Y03Gxuygq5aNhWCoSwy5wwwCgUc4uU9Uhe4O7gNBcxJOMrPb2a2w6wWsKLbu4gLlBmRHKTpBLWKr3+1IreEVEKHt30gmLPhaIcoHWIQqki747XGv0ShVDIjsth5D287fosRzCSQT6DBM4qaxfEAEHLAN6P12bY0dRKcKjs1TzK0c+QuQvzcpKqLVJeW8OUuD+pQBRJDd0uryn/0oGqsqn1G3txd+3Jup1aLwLkMleagGi3G07vu/GTx/TadQRr3Js2FH2yl+3wjOIFvQ4ohMxiL0EebreGO1qacdB9ixa8nhDkqordWdF84usRT6SWb7+8Q/Hn/9J8TQQPL/EWj5dTGqgEhBNgE0uT8kYBMFXxVQMvA6O/2UDEq9edCVFHnUqOYIC6/iOcNz5NsfE8ccU8jOo6vV7vK8a+Urzx+vLdUHuA4twEgM+q5SMRzq9HML0WYpYDGUHEe1mIGEKJVnbnjw0may+c6+KcVS+FBei0Q1yPchJnJYO4n5Rc6V7Gs0me78knaVs2rGvXOsUMrF/XeScbYdyikGvLUJCccnFMfbzmXtbvSGrwZq30gX3odcubrDY4e3gh6GzFVHKL8wevUWzNgKxMeB8mEs/oFe7Wxnl4k9FRa3o/30UMMFrlZqcdr6//pyufKu9a5mnvU9QQEU9I1fIMgi7BuuLium59WSribfAZlb9+jVYVe9sM5Hhd4AmB9FhnIfWGPIA2oLp2toDJeoSxCbVHpCBc6TEwoLf1RN//nGaebfzZ1WsLf9JgGurboT1xCFYA9FXmmGw7HYoOppDn6PZTiX4RgwXfCmKW/+Q8BjOXtTyVEoYqWGN3ks/8mCRH/XDpTOYYAI/RoHfme8ybLNmYddzCoy2n9F0Hu6pP1gVLIwDdZ365GDW49imVcLpYz/e5F0KgMxaq0Jg dKiCRp3w Vhy/fTvTikAB0xZdQjUJAAXpVgfvoQoulZvE8QuS6Hml+OqpRB2GasHE4AnztOdTSASektSD7YOVaAiEyho75+5u80tVt9l3Iom+LW2XyixQY/f5WwapipGrC7FjF5QkqG/HCP+VhjNpXFHfkoehDkia994j4tf+Mhb1NtITwNEHhJzRU1UUFmgINR0spawsbqwH51ZyP08CFMpdUbDtrAYBa6X3XcuUOarNTEnDfrUAB2XA1ooao6wNPgqsFuvU8Y9MpFbXV1Yk0E3xu8q9TO5iOWmC58Cerke+E5VNrnXnzyYWjGoBWEUGRcV6SvEJUlNMeVusspNIK+gvQ9EZIr+iMVLLC8VZbtbnwT9n31bugOy+Q5W7KrAJydF7oEXCU3aRD2631bKrGr1ZxwCec6lsxcBvB5Z4I0h4XfHf+7nbdZznRlt1gulfZcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/31/23 23:13, Arnd Bergmann wrote: > From: Arnd Bergmann > > The size_t type depends on the architecture, so %lu does not work > on most 32-bit ones: > > In file included from include/kunit/assert.h:13, > from include/kunit/test.h:12, > from mm/kasan/report.c:12: > mm/kasan/report.c: In function 'describe_object_addr': > include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=] > mm/kasan/report.c:270:9: note: in expansion of macro 'pr_err' > 270 | pr_err("The buggy address is located %d bytes %s of\n" > | ^~~~~~ > > Fixes: 0e301731f558 ("kasan: infer allocation size by scanning metadata") > Signed-off-by: Arnd Bergmann Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. > --- > mm/kasan/report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index e0492124e90a..89078f912827 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -268,7 +268,7 @@ static void describe_object_addr(const void *addr, struct kasan_report_info *inf > } > > pr_err("The buggy address is located %d bytes %s of\n" > - " %s%lu-byte region [%px, %px)\n", > + " %s%zu-byte region [%px, %px)\n", > rel_bytes, rel_type, region_state, info->alloc_size, > (void *)object_addr, (void *)(object_addr + info->alloc_size)); > } -- ~Randy