From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56233C3DA6D for ; Tue, 20 May 2025 10:30:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9D906B007B; Tue, 20 May 2025 06:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E758A6B0083; Tue, 20 May 2025 06:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D64076B0088; Tue, 20 May 2025 06:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B2D726B007B for ; Tue, 20 May 2025 06:30:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30AE45CC5D for ; Tue, 20 May 2025 10:30:32 +0000 (UTC) X-FDA: 83462917104.01.340CF91 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id AE338180020 for ; Tue, 20 May 2025 10:30:29 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EEya9UBO; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747737029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IyqZDF6nTsKA5ptYOVkepI7N/Zyz69GWHnyAHJHWDW8=; b=JS1oqlwPr7WSmBWaHVnFAPd7KKEJ4eFtplwn8GT4PoN6EPB6d+liyKFjwAwTGdeAHThKN8 0Es5kShve1p9qmY0Xr1ZCMkv6Y89vvtziWw6bHTdOJKGgRJ1MfUEzaJEkSKn57rRg+HYRS s7dB/ZnJoc0hjv53HFCVxWbpKWe716U= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EEya9UBO; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747737029; a=rsa-sha256; cv=none; b=xotvLiJeqkrT5JWRZm+gXm80nUc5G8NYCvCB7YEVx45giP318WGZVTcfPBLChKBKKzYFvs /7N6YjuEw6L3wsKxYxeakdZEVIHCGdYJEPx1QfEyL4wgT7ozG5k9Sm0p99cLdfnjl70Vav yP/g+E6qhwZYSQm7xl3xs09BiV+Rlps= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747737029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IyqZDF6nTsKA5ptYOVkepI7N/Zyz69GWHnyAHJHWDW8=; b=EEya9UBOFdccTmdRaWIWtWoBz3x5EW5hJsf1Da6nmFWx2EhE4lanvgVl3GwlaYG2SR2VjK t8HYkC49LtJg1JZ1EhfwZHVJPpLW9yNlqzwByZpNuVfHUccgxAiMdyQMdXVQFwHdTXQbVM ZwRfzRE2WZmgAXsHsBkk9YTboYVsQyo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-sL2IvCpoPxSroGrhYu3Baw-1; Tue, 20 May 2025 06:30:27 -0400 X-MC-Unique: sL2IvCpoPxSroGrhYu3Baw-1 X-Mimecast-MFC-AGG-ID: sL2IvCpoPxSroGrhYu3Baw_1747737027 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a364394fa8so1671733f8f.0 for ; Tue, 20 May 2025 03:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747737026; x=1748341826; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IyqZDF6nTsKA5ptYOVkepI7N/Zyz69GWHnyAHJHWDW8=; b=F+jmSyo83I88y25DzbN0wDy5fbouQOCpYmgQTO6IleXT7N/T4Sx+dbEsjHFloJ6ag2 +H+dGdEqVGZMRID5FDkkWuE5t1ErO0++QnRRTwi940HG+RyF/d2u5rUDnFEm0/JIdV5e T589JKSATXGnhLqOSRxikS4zNUCBOZnNhLU2lOZvAG21+JnHJY0z4dSBWS6V+eTyelps e7M/2ZFP2Dk/YPQKhAmiHAbKtHvhPXH5dDxjevc2sLgQ81S/3QIKoxbgt6q9kH//H+u/ OqMoIOp7rxqHd3idtReWz8lJCl0CouQbp7NpN0dTc4Q8LRdayT/SXPUNjHl4siT1yN2a yrPQ== X-Forwarded-Encrypted: i=1; AJvYcCUUyl+sE50HMbk0CRynphDLVi8PBJIiK0hwffEUQKg4egQWRhfFQ9Se/85kCkz/y8ZAxAz02N7QcQ==@kvack.org X-Gm-Message-State: AOJu0YzCDvtTFaRDfhnqqfKAHlKLzYfkDUL+3SeG0xZkJlF5g0jrMraY /Q7oMK1/Hwnl04itesZg5/an+NUwQLLW+XhdY9CN7NXg4Xwc/CorkQJGUruxC2NKno8VLc2x0OV gqvYqscZ7/Z3J7sz1tGHWItTNb2QswsC0/Pc3oi5KcE7MHk0y0kWX X-Gm-Gg: ASbGncuXLoNam+FvxUv7vmO5B3RnyhPhdk+JLd8cduHC7wCCJjQaYMMsmJ8207vcP7w Pv+oQ5iLmgzcKhNxk4jjI2tFI6BhwlruPVicCJCrOC5hopwoJljOZb7jnX8ZCdaFEGQzG5XwtnX 0RrNKzqO1OpQIosFpeBrMnxB6aaN8IVL1TUZ3XQoklTIJR7/3Q0HwJLGiUrvoSPLlvjit6EtZuL 8SrFQryAriWZotMPw12mGpX+sHrDaa1/r9vrKZqIgpLDBhFv9A+S3g5iAQjSubeowfmGRcyGeC/ 9EgnbbTwgN6TCMvyN03+MA7eT+BlGrNvvqTfsEcNsNQzzI085akx0pmWlPHBHHrgFAvUm4I2gsN Z1v6bfyvkI7IEIe99q6Wzv+MIwipnIzwgU1xM+U8= X-Received: by 2002:a05:6000:1881:b0:38f:4f60:e669 with SMTP id ffacd0b85a97d-3a35fead108mr14152707f8f.29.1747737026544; Tue, 20 May 2025 03:30:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoaw0m714635En0zqDIhccEWnaF7oScgqO/CS2yGTyppvcyz0MOxrqhsvQmQEsW4QqhBt2Ig== X-Received: by 2002:a05:6000:1881:b0:38f:4f60:e669 with SMTP id ffacd0b85a97d-3a35fead108mr14152674f8f.29.1747737026139; Tue, 20 May 2025 03:30:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:7c00:a95e:ac49:f2ad:ab84? (p200300d82f287c00a95eac49f2adab84.dip0.t-ipconnect.de. [2003:d8:2f28:7c00:a95e:ac49:f2ad:ab84]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d1dfsm16243981f8f.18.2025.05.20.03.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 03:30:25 -0700 (PDT) Message-ID: Date: Tue, 20 May 2025 12:30:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/5] mm: madvise: refactor madvise_populate() To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Arnd Bergmann , Christian Brauner , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park , Usama Arif References: <96503fba082709bc4894ba4134f9fac1d179ba93.1747686021.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <96503fba082709bc4894ba4134f9fac1d179ba93.1747686021.git.lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zviq1aXPgOBf25CGRMbaM875UL_Y9zLMB4kE7PdqlOk_1747737027 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AE338180020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ni4orey8pxnifebgsbusb9418skg8cbs X-HE-Tag: 1747737029-286651 X-HE-Meta: U2FsdGVkX1/5Xa2BQLUDr+Rzuyy8Q/FFC7a/PY/7GiN5NAvyHRFFRspjKLdrs7T7pw5ENUgk3UX2oVxQcsDBNDuVR+54ahDH0RzV22o9DzknRNokHqTD1P3yz7wNHZRXoSsWlWJWikQYy1PU3L0NYFexhJXepNAsj06Hk2AuvWBQxykIpISJBCvWpHxua7YHvNs5xuq9O/4xRtiYXlbZWt63X/whiFwwiZOvN4lP3ly7LFOyh3ih2BuBYrLJuoI9WxftXdEV/YglJ99mWSeQ4WfriLJs4oZ1+PfktCuXukLluD7/0uCgqw+Cn11x2Gy1cke6S7HEuLcIQist8wV6jX25XSsUgP/kyMjTWUjZgAuGfVZcRoxCTBa4c/SHx7ZUslxW3HvUONK2EEXj0Ya1CcNXJLVrUhjoNutA3aOozzNPm7XOe1n+oHWB/T5S5v01ldntPePGgdNSN9kmhHoGA8HlCjQE76blRiKnLpvAG/Bg6TOhA0sgvRfsuVWtgwTNRP6vslv8mqmOD/upxlzLdszHjphtGd2lSw7bXVukabPjdoFXdbfT2mRctGF+4P8JXXsgZY7aWiUYcfFo82xcJKcZtQoM7EeVKkC9tkwwZVl+O3rCCdBz4M9f/46hb+VoPGlK+9IfY19SBoZNmdYmytvlFXFv6l5suWmQuYXQwOjwXx0sBs0w9XhaEY92EtaIAXQa7fhBEZ8V8BUek/zufVk5t/f2C0F4+EKf/qE4lieQXtkq9MIWT8LkCkd9ZD8wA4rmJOY4kmLk0JHEjopcWqcgkKf4SOdE9FXl1Yo8XZI1NUHemaSy6a8XFNHD/V69LQdaLmKycw9zW6oW9zxa/iTo9fwYniAt6bMwZXZErknSHI2OLn5UUFMF2fjb4QQeIR7Dh59YNbFGcwwDucyrwJ70PE9xsHH1hke6OtZ67uH7bYC2MKvNDxP8nMiwa7JQ6unjWKZ98mN/UaWn6up xBlaM312 2Q+eFiYbSlBO++VGU+//YHdH8zCYNTjD9vFjgfI4oxvPlzKxUEUZvC8rH5gAh0Ff8317yxihVhKKkTJdOEBFBEi5lSISHTLAUdqYp4HO2PuGcDN+dxE2gRKV1UPMl7rwJjjAGZfzc2VE4y84QtLcM3jv5KGkZG+ymgcQFFdU8lfYBqDAFqBgJuUu19GeEwvlIlccUy2jReZ7jOUQ+39oSjGTEED8XG6vIcWZP3Sb6I+6vFNMCShdMii8okZsUDi9Wqd9xynDeP06rD0A52PdDvqDzWHCd7QuB3cY4IKLYzwd22OAlFZsNIr4BesjT/qPLofrF5m+knYNhEf6HH++1sOM/WSsPL7T/cynU3tqso9DH4U1N5bUKiPWhtMWmEmRw+PQdjOb+RZUByboz4bvJtK6hvWwW0c3747RDFBLjgRoXRXT1RV2+SEr/F+gAnyMIYKfW8uZueWNzEYqKRJYRPn46QL5ZlzqoTlaU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.05.25 22:52, Lorenzo Stoakes wrote: > Use a for-loop rather than a while with the update of the start argument at > the end of the while-loop. > > This is in preparation for a subsequent commit which modifies this > function, we therefore separate the refactoring from the actual change > cleanly by separating the two. > > Signed-off-by: Lorenzo Stoakes > --- > mm/madvise.c | 39 ++++++++++++++++++++------------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 8433ac9b27e0..63cc69daa4c7 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -967,32 +967,33 @@ static long madvise_populate(struct mm_struct *mm, unsigned long start, > int locked = 1; > long pages; > > - while (start < end) { > + for (; start < end; start += pages * PAGE_SIZE) { > /* Populate (prefault) page tables readable/writable. */ > pages = faultin_page_range(mm, start, end, write, &locked); > if (!locked) { > mmap_read_lock(mm); > locked = 1; > } > - if (pages < 0) { > - switch (pages) { > - case -EINTR: > - return -EINTR; > - case -EINVAL: /* Incompatible mappings / permissions. */ > - return -EINVAL; > - case -EHWPOISON: > - return -EHWPOISON; > - case -EFAULT: /* VM_FAULT_SIGBUS or VM_FAULT_SIGSEGV */ > - return -EFAULT; > - default: > - pr_warn_once("%s: unhandled return value: %ld\n", > - __func__, pages); > - fallthrough; > - case -ENOMEM: /* No VMA or out of memory. */ > - return -ENOMEM; > - } > + > + if (pages >= 0) > + continue; > + > + switch (pages) { > + case -EINTR: > + return -EINTR; > + case -EINVAL: /* Incompatible mappings / permissions. */ > + return -EINVAL; > + case -EHWPOISON: > + return -EHWPOISON; > + case -EFAULT: /* VM_FAULT_SIGBUS or VM_FAULT_SIGSEGV */ > + return -EFAULT; > + default: > + pr_warn_once("%s: unhandled return value: %ld\n", > + __func__, pages); > + fallthrough; > + case -ENOMEM: /* No VMA or out of memory. */ > + return -ENOMEM; Can we limit it to what the patch description says? "Use a for-loop rather than a while", or will that be a problem for the follow-up patch? -- Cheers, David / dhildenb