From: Andy Whitcroft <apw@shadowen.org>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@osdl.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@csn.ul.ie>, Andy Whitcroft <apw@shadowen.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] lumpy ensure we respect zone boundaries
Date: Thu, 23 Nov 2006 16:50:10 +0000 [thread overview]
Message-ID: <bf938e31d7fe72a5128a5bd22bb70480@pinky> (raw)
In-Reply-To: exportbomb.1164300519@pinky
When scanning an aligned order N area ensure we only pull out pages
in the same zone as our tag page, else we will manipulate those
pages' LRU under the wrong zone lru_lock. Bad.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 3b6ef79..e3be888 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -663,6 +663,7 @@ static unsigned long isolate_lru_pages(u
struct page *page, *tmp;
unsigned long scan, pfn, end_pfn, page_pfn;
int active;
+ int zone_id;
for (scan = 0; scan < nr_to_scan && !list_empty(src); scan++) {
page = lru_to_page(src);
@@ -694,6 +695,7 @@ static unsigned long isolate_lru_pages(u
* surrounding the tag page. Only take those pages of
* the same active state as that tag page.
*/
+ zone_id = page_zone_id(page);
page_pfn = __page_to_pfn(page);
pfn = page_pfn & ~((1 << order) - 1);
end_pfn = pfn + (1 << order);
@@ -703,8 +705,10 @@ static unsigned long isolate_lru_pages(u
if (unlikely(!pfn_valid(pfn)))
break;
- scan++;
tmp = __pfn_to_page(pfn);
+ if (unlikely(page_zone_id(tmp) != zone_id))
+ continue;
+ scan++;
switch (__isolate_lru_page(tmp, active)) {
case 0:
list_move(&tmp->lru, dst);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-23 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 16:48 [PATCH 0/4] Lumpy Reclaim V3 Andy Whitcroft
2006-11-23 16:49 ` [PATCH 1/4] lumpy reclaim v2 Andy Whitcroft
2006-11-23 16:49 ` [PATCH 2/4] lumpy cleanup a missplaced comment and simplify some code Andy Whitcroft
2006-11-23 16:50 ` Andy Whitcroft [this message]
2006-11-23 16:50 ` [PATCH 4/4] lumpy take the other active inactive pages in the area Andy Whitcroft
2006-11-23 19:02 ` [PATCH 0/4] Lumpy Reclaim V3 Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 16:59 Andy Whitcroft
2006-12-06 17:00 ` [PATCH 3/4] lumpy ensure we respect zone boundaries Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf938e31d7fe72a5128a5bd22bb70480@pinky \
--to=apw@shadowen.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).