From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49202C3DA4A for ; Thu, 22 Aug 2024 06:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D797B8000A; Thu, 22 Aug 2024 02:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D298480009; Thu, 22 Aug 2024 02:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18B38000A; Thu, 22 Aug 2024 02:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A321580009 for ; Thu, 22 Aug 2024 02:56:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 55BDBA050B for ; Thu, 22 Aug 2024 06:56:37 +0000 (UTC) X-FDA: 82478973234.07.C42529E Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf04.hostedemail.com (Postfix) with ESMTP id 7A03940007 for ; Thu, 22 Aug 2024 06:56:34 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724309714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q2ZFSSca5VAlKChZ8j4L5Em9Iswvz0rNwY7z/mSToN0=; b=b4xqA/5iHK5kkwThlCkeNzgO6zlNo+6JQdM4eBliwg75RKAdBy1cgE6thcV/MKn06RksZ8 jlwpFIkT7BaU9Gr7Js4uxL10HD0TP/VH0BMXHX0qLXlg5OGQ1N2kuEsr6ZOkEpulvuCCjz PQsFaodbdH4dPQDz6OvqxriXqjQzV3A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724309714; a=rsa-sha256; cv=none; b=Ukg9p2zpu9wqyzTSlVqFxgMmTmIuKvtZ7nLOpwCvt7oRPI6N/HCVcj2JBL7hoIrj1egdFS iFM9zhWijaTIPZeYGojDzi79he2+F3CJ3eE+KH94XYlfYr5d+UChWoT0BxqNL4EoTyBcPg W8LbsWR+2IYtHO6KrBmj+XhXXCbUmBc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WqDWZ4NwBz1S8RW; Thu, 22 Aug 2024 14:56:26 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 911891A0188; Thu, 22 Aug 2024 14:56:30 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Aug 2024 14:56:29 +0800 Subject: Re: [PATCH v2 4/5] mm: migrate: add isolate_folio_to_list() To: Kefeng Wang , Andrew Morton CC: David Hildenbrand , Oscar Salvador , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-5-wangkefeng.wang@huawei.com> <6df49109-d39b-9852-b5b2-a5b88c9329e3@huawei.com> <927205ab-bd83-4765-b2bb-3fd311f5ac6d@huawei.com> <5aa2f835-0337-d7d9-5ad2-1c5ca2d439d9@huawei.com> <7095d43d-327a-4e1b-bc94-365c06df2f9c@huawei.com> From: Miaohe Lin Message-ID: Date: Thu, 22 Aug 2024 14:56:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <7095d43d-327a-4e1b-bc94-365c06df2f9c@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200019.china.huawei.com (7.221.188.193) X-Stat-Signature: 7qnqz7i1mc4r7qse887pf59y6r6fxyja X-Rspamd-Queue-Id: 7A03940007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724309794-9964 X-HE-Meta: U2FsdGVkX1/+E1NIADHnnwxlXEtj1QRYdZvFrTiyBZegVzGo256nDEi2P56cwr2kLQCf5NBCf1HAqqWuGJqnmkcfbGek3kZytmoPheevlVLZGeoz0WDCmuqvcul0ZWOtKM7kmCGDYCwu0XoBT3Zz5uLI+RgRUXYVvk/xY/ZrZLpFnF611Gyrodd0Q/vjIdsF/aB4OxWKZ37MQZsl02iYnJ4jRPgaXP/82WjUgO/YpEdzJSoo4M32/HClBB047qtl4PqJhayseQOd3KQFAJpJxJDvZ5hkjYKmRmAeETgmaKwv79ba5DS6eZmDtlbI93F3Xg3vcIEdU5jpABxQHZKCyMumd+F1JqoVymK1QaOj3Ul1cFOHpVKYnaXClFGTp8e4G9LyHRFRZ/qCPKtW1FVWhXS1jDYyASDBxqbVjLH/9Q7P/Ti703jF7q7u3tCbBrFpluiYpgZXmHQd+RhxXoQ4mg4JMaYFHjIZ2fXXCn4yzsZVOhHt0M/6QYwH6jD7W6tfahyQTSUhGFqQHIQrYxTOPK1j74l+5nfRrChAAEPYH/6MFNtt3dRv7lP38iNvNWCoBcBYZZeoCs9sRvTxpOj5tW+JPxWFFwwPkW9Rzfg5jI29nECgRCYP3opy6eH9UrAsO7BaRQdSuTWo1sqePJLxUM/mup4hjgeIfkkTu+Z2DNVFYionpHlDiZ60WU+f+JKCTu3bwi2E716Tk5EOievX9/xAdBWijN1qVNmkLpTMyV8Jp9eG32l0DIzj6bMUaFtup7q67a05DBrE6D0AbhP9tBTfIler7QlhvFe+P9A9/5a/wVP7w2W5p3LgguMDGJbmnEFLGRIeu6zA4bboRJfCBDz7PSbCQT6gY+bbRvxf5YAvh4iUYclKw2/e8mQc0PoagPTBjGrhPstEmLTOl90nua71WQd6qCHuryFHVAHejfuilqyY0lg86eBjWEk/VCwSO6sx8ZiAdyYaXbQGGuq zWw+yg6r tQXFv6mMOTan2O/Hlu7GHBuuvKCuY/NAnXhdF1xtpz1mFZxx6PesiAPROd6hZ5FGcSPuoZIQdxsqOAf/l1zEs18TJNjj4xSb+uhIpyWyKLyrxPTJHuZidttJ5LKn/jm3q4Mgq+o2huw7s9Yjp/rP8pu/5VOUN+UFRB4AlxEUSIWWl+IYudXl7KfcNEFTywuQM6C4ktaFAzPeApHXWkkqdxyy/RyF6qDF1afPWNsP6ybLXHrvz/UMuuAya9aYyqHKxrwqhW/fb/nDoojnA+koVDewrA9HcODrHeIAOn0TdX1BFkES3MlOj6ub/wPybQKa4c9Xx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/21 10:14, Kefeng Wang wrote: > > > On 2024/8/21 10:00, Miaohe Lin wrote: >> On 2024/8/20 17:46, Kefeng Wang wrote: >>> >>> >>> On 2024/8/20 17:32, Miaohe Lin wrote: >>>> On 2024/8/17 16:49, Kefeng Wang wrote: >>>>> Add isolate_folio_to_list() helper to try to isolate HugeTLB, >>>>> no-LRU movable and LRU folios to a list, which will be reused by >>>>> do_migrate_range() from memory hotplug soon, also drop the >>>>> mf_isolate_folio() since we could directly use new helper in >>>>> the soft_offline_in_use_page(). >>>>> >>>>> Acked-by: David Hildenbrand >>>>> Signed-off-by: Kefeng Wang >>>> >>>> Thanks for your patch. >>>>> >>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>> index d8298017bd99..64a145a0e29f 100644 >>> --- a/mm/memory-failure.c >>> +++ b/mm/memory-failure.c >>> @@ -2671,6 +2671,7 @@ static int soft_offline_in_use_page(struct page *page) >>>          struct folio *folio = page_folio(page); >>>          char const *msg_page[] = {"page", "hugepage"}; >>>          bool huge = folio_test_hugetlb(folio); >>> +       bool isolated; >>>          LIST_HEAD(pagelist); >>>          struct migration_target_control mtc = { >>>                  .nid = NUMA_NO_NODE, >>> @@ -2710,7 +2711,18 @@ static int soft_offline_in_use_page(struct page *page) >>>                  return 0; >>>          } >>> >>> -       if (isolate_folio_to_list(folio, &pagelist)) { >>> +       isolated = isolate_folio_to_list(folio, &pagelist); >>> + >>> +       /* >>> +        * If we succeed to isolate the folio, we grabbed another refcount on >>> +        * the folio, so we can safely drop the one we got from get_any_page(). >>> +        * If we failed to isolate the folio, it means that we cannot go further >>> +        * and we will return an error, so drop the reference we got from >>> +        * get_any_page() as well. >>> +        */ >>> +       folio_put(folio); >>> + >>> +       if (isolated) { >>>                  ret = migrate_pages(&pagelist, alloc_migration_target, NULL, >>>                          (unsigned long)&mtc, MIGRATE_SYNC, MR_MEMORY_FAILURE, NULL); >>>                  if (!ret) { >>> @@ -2733,15 +2745,6 @@ static int soft_offline_in_use_page(struct page *page) >>>                  ret = -EBUSY; >>>          } >>> >>> -       /* >>> -        * If we succeed to isolate the folio, we grabbed another refcount on >>> -        * the folio, so we can safely drop the one we got from get_any_page(). >>> -        * If we failed to isolate the folio, it means that we cannot go further >>> -        * and we will return an error, so drop the reference we got from >>> -        * get_any_page() as well. >>> -        */ >>> -       folio_put(folio); >>> - >>>          return ret; >>>   } >> >> This works to me. > > Good, my bad for break. > > Andrew，please help to squash above changes, thanks. With above changes added, this patch looks good to me. Acked-by: Miaohe Lin Tested-by: Miaohe Lin Thanks. .