From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6266DC83F1B for ; Mon, 14 Jul 2025 15:33:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038E58D000A; Mon, 14 Jul 2025 11:33:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDF588D0001; Mon, 14 Jul 2025 11:33:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA8168D000A; Mon, 14 Jul 2025 11:33:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C61D98D0001 for ; Mon, 14 Jul 2025 11:33:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CA2512AFC4 for ; Mon, 14 Jul 2025 15:33:49 +0000 (UTC) X-FDA: 83663265378.10.2DC0830 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 2CB68180014 for ; Mon, 14 Jul 2025 15:33:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VmHYnWaD; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752507227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IfaRF94pmBxwnztabnfMWV5BZVR2hROVdYqFrlRAYP4=; b=5HJmO2PKQAKgcBduh6pBi0HbbMgloJgD5L3U95Vqgc2AFlpgxayn0EzU6r/3eO0Vyud/BM KQxPWF1XXGSdxdQqcp0qXj++lHeMHnM6vyD+HOqZ3ZIuve6T2my6eHxi5Ly3o0k02qVndm Pw9sQNRTYf863y6ZUcRgl/rIHmuJOWQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VmHYnWaD; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752507227; a=rsa-sha256; cv=none; b=02ByzbYvyI3TIqgLcXP5J3D6emo6UbWSiUjChm5YNLIVKtrsaM4bMjNlVCn8xdkPQuTDP4 ijT8gk2W+29Eu8np6cphKWOO6C0ZLjCMVfY2EtkJ/wwkFnk7a1QVxq/R5y0qDEU7nOaqNA J9jzn+NWuHO96VVLymfuUIPTsLm1cQU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752507226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IfaRF94pmBxwnztabnfMWV5BZVR2hROVdYqFrlRAYP4=; b=VmHYnWaDBsoX/jCjvZQy/asT/IfygnSynYSdJD+Of8uItZ6kO43g++Y9eZN16NetZTcRs6 F6RUYpO/xB2/KsH5a5lzkXAvQiTQZc34BqL5gsfC9MEdlt2IysV8+Kq6e7dQyeuM3C6X+W mjYV6Rb5mbTKTk3mDp+2TzlhsULDEjQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-dj6UaPFwMZKNJicXQYou2w-1; Mon, 14 Jul 2025 11:33:45 -0400 X-MC-Unique: dj6UaPFwMZKNJicXQYou2w-1 X-Mimecast-MFC-AGG-ID: dj6UaPFwMZKNJicXQYou2w_1752507223 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4538f375e86so36115635e9.3 for ; Mon, 14 Jul 2025 08:33:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752507223; x=1753112023; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IfaRF94pmBxwnztabnfMWV5BZVR2hROVdYqFrlRAYP4=; b=M+AOPjcrhvehpKWdfQYE92dzMh5rb0ZRjvXP+WVzL9igWVPwjipKZYwlBKpy0eYXiN nBQ0jYmqokzJL3ZestZ04yMGvt0dSdfmP4wh+JSSj6H4yA/WJlWoczHm2EuulcK8uYHH AEEDOHRULsunWJCgdSF/qodECy3/eVsyJ/C5e6UzcySmG9x2O+OphCdDo+bCPDpyqawU Jac3tXo/vzZzLV4wd4CeBeg7RWRF/JrrPjzTrQtZU9CDAF7ASMoS7b1Nq8QxJqN0OMGM XbvGmC30fkfBOJF66uVOu3dj7Atp8LDuADv6L6LpTISWymM/VL4GwABZFAhDlTAgLwaf cTDw== X-Forwarded-Encrypted: i=1; AJvYcCW2VA6bjpkQAuBSwVog+toBGVg6dG6cAbPFZV/vlwFfwJDiUDVyhedRDQclUDFuNKkPzpBBQ5Rm5g==@kvack.org X-Gm-Message-State: AOJu0Yygih5EisS3ER8yOKdY7YiToQRM1YW0aMrhh4WT00RwAbqlR5L5 4gbI6Q6j5LB/g96dwl9zItXUpNMqe1mHPt0yduE95CYZ8f7fR6dqlSaZzUXIx/Hhlq6MLGqQwul 8kpWvkDxmAhl3XTHL6uZVkrfexeC9Q+m/KD1PXcwng1dPR/NVBwXb X-Gm-Gg: ASbGncskWxyL4BzfPQJOm1Sw1kWi4K1zlAg3Ni+kEmYXYf6wfJN8gMufHodajdqLnZL iNST3HpYnV+EpxP/wIlF+ae7xwEWjxErl4/vAzcQ+OVt9s3FIUiQJhVvybfquAc1Qv73Ag4Q96a yO7+gTxH8fQ/i7DTR6JEyC8pHQq+pXpWmg6xJHVEiB1mPvkWe2ztLDyd6XrrmibVwQw3tmH2LU+ 48cOQG+MfsonRei+cwqzYg/WSbi+ukYa5s1jSX9m7waIwcPT5lLceRtaULU8v5eSY0TB1ZjrDej ybI8d5tmAT3lZWET5lHTq/Iypjyn/mz4lh9unripIUo0nW/rxl8EQfib7/fXlYGwoWticUMLEtY cMVpwEhCq+jQl3pEzSZwHvjhIP97r3TrmUP/az6dMG+y4YLT+f1IEgUiWW4hsDEpm X-Received: by 2002:a05:600c:4445:b0:43d:4686:5cfb with SMTP id 5b1f17b1804b1-454ec28306cmr121066225e9.27.1752507222993; Mon, 14 Jul 2025 08:33:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnHAjZ/8K67tpQ0Hx6A2SMdZUz+fZ0nzNKk9PiL5OdQ5iCE8ewDI71n/DDIbL5w9IOkPOMqA== X-Received: by 2002:a05:600c:4445:b0:43d:4686:5cfb with SMTP id 5b1f17b1804b1-454ec28306cmr121065875e9.27.1752507222535; Mon, 14 Jul 2025 08:33:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e26f7bsm12930555f8f.95.2025.07.14.08.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 08:33:41 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 17:33:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm/memory_hotplug: fix hwpoisoned large folio handling in do_migrate_range To: Zi Yan Cc: "Pankaj Raghav (Samsung)" , Matthew Wilcox , Luis Chamberlain , Jinjiang Tu , Oscar Salvador , akpm@linux-foundation.org, linmiaohe@huawei.com, mhocko@kernel.org, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <61325284-d1d6-a973-8aa7-c0f226db95fa@huawei.com> <7b2c054b-fc33-4127-aaa9-9edf6a63e142@redhat.com> <924d9d25-e53c-f159-6ec0-e1fd4e96d6e2@huawei.com> <4c5d4fd5-5582-11d8-9fee-24828ac1913d@huawei.com> <8c9719f0-c072-40bb-b7f6-6f2cc41a31dc@redhat.com> <1D589FE5-3515-4ED5-B12E-D5CE23BA5D13@nvidia.com> <641F5B0B-2B48-46FA-AC58-3A8A4BEB1448@nvidia.com> <3702f6b0-27a9-4ca1-adbd-fb1e2985b2d3@redhat.com> <345f7ae6-b2d6-44cd-b8b6-2bdd4b33e9d6@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hmsxU5420HjcRIKLPEwk-SMjqKEVqyaTy6C0Ejgk8iE_1752507223 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 2CB68180014 X-Rspamd-Server: rspam06 X-Stat-Signature: 83kxomycwj4ypqxj44hie6cyqchjzgdf X-HE-Tag: 1752507227-701341 X-HE-Meta: U2FsdGVkX18dUoj40bd9Q0gbIhnxv5aruTuZRlK3L+2u8B8/31sk8RSXvABwTubrQC46NXSN83inbgggu+Gl0dbrL56mznlIkBSWzydaLMOwp0jxPMRn4DTv3A9L+FRB8wRTj4upZ3QeK883II8q2j1nijI1oQVAqdYWn3RIJ4zgtaVbwuFc+8hKqnKKLMC853yGpHTmboUyvzSLbpW1R0LgbEdUxcNBX0hWceH1kPpaxGPa2+7ZV/cYwfiH+PU7HPSESrdUOS8/CcOUlgOARy5y+y3SMcfHM6AxpMAyKA0Raw/u7ARaJIHfxANqrhd/N7TMoI4KiBIRwTKVOllh9K7T/xXHg981GT7h4jC2g5g3h4DdjNIzZ3TfhysCsZwdfchvDovjaoHac7vQlvHyEVNVsYGX+Pka88Wb56Y+vgWo4MB+HIn0zACe7A15oeUU+dsqZW0F5SOAOde06mRvbAz+SR1w0h9OKuphQYjmjOsnjHnpm0nVS5UC7+Yar4/9DjybgZYMW9MrHg7dRDiLIY35Jw8mdPrJVQXpcdLR6KpWoqHNQwwWrRUWjlPn+npchxfsKibmJx/rJat0bLXocEeyzVPDPXv3Hw5K2yA5qKbhibNcbNAO4zUUTd6anv6UkMrdNHOcVUiKQsMegEHlG9/ViQS3dn+RiSg9ECkatj7yWnN8IhbO9oZ0AAlqyhCtEM0OfSC1dwzsEImIQ2E3egYOcgWqg/ECjfaQlXwX9FXYonixWdxRy4RUbCuAl8EMGtUYjiydZTYm5Ozu9HEiihQgS6LmYDfP5Znx5UTtZ2wDYyNvB/ytueEjNQ4ZA8YZut5e5i34Uy+cCzlk5SYD/5FBgP4X2i+f5Y4RRN1o3rb4zlpyDgW9+CsFV4Jb5LI6+JWrq4uSH0d1irQdiPxAHHD2DkW0/XCYaYf+5/4fCiXz/P6HBp6Cby1mj66s/tJkRCMyBTet9O3Y95UIt4J S+CSaQpc 6Mu1E8avz/w0AfpjKgUGw4pm4kr1MOdr1andLhC91VwMWHKIXRaHw5SmAHllZydO4JHLcd3wT+f52m81Gfq+pi7kiPX5Yp6Oxl9DGq1AfuOzyYdDx+82pe/4JjrZroNKPLyGKi4vS85Z3w2o73oBr8dwSIKbgKvS9pSImTBupWTO1djSz/rb8YT5G04aj3UnXRmM2eeQDGGqFYHVsdXF8fChwM8KrMY5px+5nxTDSgUrTT2ZnkYEc7biNw7QT2HNNG9A2MLHXtM97tcY0zZsj5rKkRA/xZ/nmqHj9QpR9cWBkR4gJN7GXqNQQFzhbAnaeraoORkygj+auBFmhkW+wQTx2WSKbyUG2quC1GjyOTEgYJ4rDQC/jVIsBS0KgHrxOfyMPpjDCCzo24Xt8bPGOmI79MHul8t4BUXxIINn49SWpKlVK/Y3h1AfGJnVQP31t99F1MZ/5gEKcT5n7jWqQKhtCeXRx1j152/yZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 17:28, Zi Yan wrote: > On 14 Jul 2025, at 11:25, Zi Yan wrote: > >> On 14 Jul 2025, at 11:14, David Hildenbrand wrote: >> >>> On 14.07.25 17:09, Pankaj Raghav (Samsung) wrote: >>>>>>>> So we will need to take care of madvise cold or pageout case? >>>>>>>> >>>>>>>> Hi Matthew, Pankaj, and Luis, >>>>>>>> >>>>>>>> Is it possible to partially map a min-order folio in a fs with LBS? Based on my >>>>>>> >>>>>>> Typically, FSs match the min order with the blocksize of the filesystem. >>>>>>> As a filesystem block is the smallest unit of data that the filesystem uses >>>>>>> to store file data on the disk, we cannot partially map them. >>>>>>> >>>>>>> So if I understand your question correctly, the answer is no. >>>>> >>>>> I'm confused. Shouldn't this be trivially possible? >>>>> >>>> Hmm, maybe I misunderstood the question? >>>> >>>>> E.g., just mmap() a single page of such a file? Who would make that fail? >>>>> >>>> >>>> My point was, even if you try to mmap a single page of a file, page >>>> cache will read the whole block (that corresponds to min order folio). >>>> >>>> Technically we can mmap a single page of file, but FS will always read >>>> and write **at least** in min folio order chunks. >>> >>> Okay, so it can be partially mapped into page tables :) What happens in the background (page cache management) is a different story >> >> David, thanks for getting to the bottom of this. >> >> OK. So we will see deadlock looping in madvise cold or pageout case. >> I wonder how to proceed with this. Since the folio is seen as a whole >> by fs, it should be marked cold/paged out as a whole. Maybe we should >> skip the partially mapped region? > > Actually, it is skipped, since split_folio() bumps new_order to the min > order, and if the folio order is already at min order, split code return > -EINVAL. This makes the madvise cold or pageout code move to the next > address. But what if the folio order is 2x min_order etc? -- Cheers, David / dhildenb