From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8317BC61DA4 for ; Wed, 15 Mar 2023 18:58:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F73A6B0071; Wed, 15 Mar 2023 14:58:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7436B0072; Wed, 15 Mar 2023 14:58:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86E5F6B0075; Wed, 15 Mar 2023 14:58:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 774546B0071 for ; Wed, 15 Mar 2023 14:58:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 451E0A11C0 for ; Wed, 15 Mar 2023 18:58:30 +0000 (UTC) X-FDA: 80572043580.26.E3FA4EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 840E920023 for ; Wed, 15 Mar 2023 18:58:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BNEVfVUV; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678906707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kwq97ii9j4Uobk/QWp3tFh+rm8HJDcqt7MfCwBpcIz0=; b=aAuvCY4avHXFN9cge79NhEx0fet8Lb8tmgZq+5Xxj/xYL/gBwNdm8mtomObd7Bn/V5WXMz 6wLfIBbMZP79617RWfopAKvuO9v1/V4gsDArxMueGBcRizSjqTmNyhSQLNSfa/VKuEzf7g 6pBhHwI7EBj9j56djKRQnM4USuqvf7g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BNEVfVUV; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678906707; a=rsa-sha256; cv=none; b=GLMrpQiIudf8dxqX8X4Mf8nhS0b41p3UgwC16d5tKPbbYPJ1St3pvdBrvJsd1Cw5ubitW1 vXiBgd2sWh0zvl01eJCW0EHgjPtkdtrVkg/rYM+CWft3fhzIzHypBQuEvQCGkSBOgSXD+m qbkMbTZsDPj5RsTvUmcK0F4Mtl0QNlU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678906705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kwq97ii9j4Uobk/QWp3tFh+rm8HJDcqt7MfCwBpcIz0=; b=BNEVfVUVoSfhJ4nvHsmcnSzy8MK6LYZobJeA/wv7xwwKIuuhLllVerLewR+6Hx16EKQIdT sPWlYhfULn0E9aQKqLwhl6Yp3EBTf0oH6lMsLopV1IVQBdD2iHDUPvzi59yh/9Ivyilc6v XTAxfBT7gZ4rOx4Ls8Q8YZ2Ul0+mvYo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-Q_ma_TN9MBOJKB5TyoD6QQ-1; Wed, 15 Mar 2023 14:58:24 -0400 X-MC-Unique: Q_ma_TN9MBOJKB5TyoD6QQ-1 Received: by mail-wm1-f70.google.com with SMTP id 1-20020a05600c024100b003ec8023ac4eso1111014wmj.0 for ; Wed, 15 Mar 2023 11:58:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678906703; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kwq97ii9j4Uobk/QWp3tFh+rm8HJDcqt7MfCwBpcIz0=; b=G9EemTI01YYBRvNf4olX/9wT1v9lsqsRbA2feSZvVqejqbbV4/o+GEFoErahoQhhsM 92Vrb23enXwvZBZZioVlvy6ByK2FcL4UXJLDe1U6Ji6r4O4QxeIm2i37m4SA1GEX5t7x HkTMgvk6NDI2i4Zp7UBzCjY8qQKyZZ9W9yuJKvRroCEzFDhV2SI5WAQ9YL+nmehPTJSF rwS53w+dNN9sCoy/HwbAZxU93YFuGXl0MC0yo+SeiFW1CZzS3/tv5AdNi+G2VGEfUt1R aVJp65fHeXcJepvdmxAktZe1fhNH6xL7dbh3/H5Ds2R3xtgGN5tdGwNP0M9046LKoFuZ P9PQ== X-Gm-Message-State: AO0yUKUPBsSO1OnkOmuOk64SUA32AVdjrW71JH2vNJ18G8kwAGQ0s/Ek JkyMo3gvdLlNjqygaKf4zx3+UA9fpX/8JR5fv1r9+1iwIC23KzIFOzZ+uSQyB+4sgooobdYSkyR 3K9kCvdiGU/A= X-Received: by 2002:a05:600c:3591:b0:3e2:1dac:b071 with SMTP id p17-20020a05600c359100b003e21dacb071mr15684819wmq.13.1678906703230; Wed, 15 Mar 2023 11:58:23 -0700 (PDT) X-Google-Smtp-Source: AK7set9wHxtbJeJaGu+TUflUL+yBb+lhiGSDGexB3h7ZOMkBv9oBaMw6khZUH1IgPgUBcAEXtdGuIg== X-Received: by 2002:a05:600c:3591:b0:3e2:1dac:b071 with SMTP id p17-20020a05600c359100b003e21dacb071mr15684794wmq.13.1678906702944; Wed, 15 Mar 2023 11:58:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:2f00:2038:213d:e59f:7d44? (p200300cbc7022f002038213de59f7d44.dip0.t-ipconnect.de. [2003:cb:c702:2f00:2038:213d:e59f:7d44]) by smtp.gmail.com with ESMTPSA id k26-20020a7bc31a000000b003eb596cbc54sm2862421wmj.0.2023.03.15.11.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 11:58:22 -0700 (PDT) Message-ID: Date: Wed, 15 Mar 2023 19:58:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v19 01/15] splice: Clean up direct_splice_read() a bit To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230315163549.295454-1-dhowells@redhat.com> <20230315163549.295454-2-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230315163549.295454-2-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 15ezkwb4zsx84ffrprmmpwt9p5ex6xwq X-Rspam-User: X-Rspamd-Queue-Id: 840E920023 X-Rspamd-Server: rspam06 X-HE-Tag: 1678906706-646382 X-HE-Meta: U2FsdGVkX19JTitjI+FLNTrB8NeNpNwHQTgbq99uILeuB5WQz3GmLijcugQtotChDhV/pfGseIYNmAyMcy2enEIglVI0O/bW/n1ti9N/IwIwnhRGrjzIhP6j+AsNwlfZUSgkSfgvs21Hhj7zZCT9eG1r7QZNQq2Bi+/Ti9WyhkztmcpdehU+s+p7RpW72XzPMvKTdwLcEjHdHupVIFRKikOjNgNBDu9CT9qVUeVpoh3+Wblr9nCKNFLMzLPPD+CAMf/B08gpcixxo0S9oCCk6wH2Pw3BWfpXAq4S6ZmxPkq2Wc+ay1muGI+YX3pyKZHaaz7VERpXgulMC3UpOixNOa6u1i/mrXBoV5sSkt7j5PkQTVKzrZL4DzMnZrnQWCfWBeyEp7CkkVt4jzFoOU8mdrLuCKvMLZhG4avxRXwcNgajOw/TrxwxiJ7WhnsljVQsXL7Ts/B2nbK7/UQcZWKCmcINwi24AptAdq59kedSJrIltaANC3k3dc/zNM8aT3mkTFMz2GUAOKADpbMpM0sYkfHlm2ryf5HUaK/GXAe90mRCw0rwQm+F3nF68AwTLlMFMOVDLWT30qdKbPO57Vn1k5T63u4096e8MRPALl3IjAj8imQDEuWPvq8es5ali7oMk2mQ6WWwvmbK8RfbtYP/tXKFFpQ0wSUSq2Z/5Ldrci2/s3g+WCGvFrM5iiD1QDPNL68CWs8RzpesGHaL8EdWRQZH2sjqg78SlA64QBhF4/b0RlYHY1kQn6I8y5pqu7izYD9b21JOyUDgfyGAgaTnVQaL6wt3TSVOQaksSreHHAKGHWMsgm6raJYvfLOJQK+e6Rax8U53dry3Q8YTRMq3/CoVvjW/w53CG8DsLfgTtKLs5m0IOE0FeDa6P42rPtBKjaFVhkF78H8gecVjcCiY8LxlIcKaI4joQr3SAwTYIjnwOAQO5hmARsXFgrMJ5d1AMdwDPgA1XQ68VSOoy7M erO/COXu ph76k0ri35/ePmyXCg6YB6pSsoeOZ7RAnXRUUJOcGJlLWuFUFLM99WdT4y5ekq1vhj2NVNPRZyDIsjrsEG4Wzl14D3C4Unr69OJ2i8H7a7OGqx5911/m1pLOHxhGbsmKAxLAUgOhc/WCLwyXIeNmB59nWuU49up3eQxso/Vdla55DnXS611KJ4J1IU0JfYCcWVFzFYv8nzFIHgV3s4xdZtaaln62EWtHarkHSfixpOPTqsHP+IGKa6ZKimKUd2LKsfnIieVpTuFoJOuntqCuUXQfpxTCF6Vp8hKEvWlkbSWqwlH/Ofv92iAcgnWP+EvRrSz8ss8n7i+eBwGQ5jcxPhZjwFeMnKB+GttzKn/Epw1tgNZ8j/6qOxxeDTXTTxnCND5ay0dQ6slZ0VsUCpf13rrvQ4FlLy8E5q4rx7cJQ/jxTqcHC7x0QA0WIRPmoXCESrc61tINYEUqctLFlMrJEvIeZ+5sMLNmPk9MhqkcJ0xABVAbEaiRqyH07r+w5sCW3jmcfrmnuCYxlxDxPumUNHojlVqiFe9/MxeoriUauyAQWAATWz8L72o4xnREckAAsoaLjnnUVQO98ITPoGHkPnQtStUK7N5zQjPMArlofPqs1O8F+8clWWCqIaepeEURuv4aZ4xFGf6qenvDPyT0Gh0sODraFzWh4iOEEtaMTB6t4Mk94f8oOANTUCkC54rsc+hNmtK352covb7gCSU++mak0cpZ9ObywIx/A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.03.23 17:35, David Howells wrote: > Do a couple of cleanups to direct_splice_read(): > > (1) Cast to struct page **, not void *. > > (2) Simplify the calculation of the number of pages to keep/reclaim in > direct_splice_read(). > > Suggested-by: Christoph Hellwig > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb