From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58346C47DD9 for ; Sun, 24 Mar 2024 17:56:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1B26B0082; Sun, 24 Mar 2024 13:56:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B50D96B0083; Sun, 24 Mar 2024 13:56:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A182F6B0085; Sun, 24 Mar 2024 13:56:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 93BD96B0082 for ; Sun, 24 Mar 2024 13:56:05 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 37D1DA05E3 for ; Sun, 24 Mar 2024 17:56:05 +0000 (UTC) X-FDA: 81932686290.05.46A15C0 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf17.hostedemail.com (Postfix) with ESMTP id 16EB540004 for ; Sun, 24 Mar 2024 17:56:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=svE32i9g; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711302962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=byn232HqbLUXPUvx2c18EvzX1rSPJ4RU19LSf5yLwD0=; b=hz1wWmVoieVDny/YiZAyhpJ8q9gq5rmmhVVDcWw2Dv1EC8Zqoim+L8EryoqdJeJJcABx8T GDcgxxpYjsxQJZm8serg2g3fbxFLQ8lRAkiGZSqd48aM5ZK20b4B5TRXi/9fKX1h1f3h8m B2A5UBevTYdC10yd4TVQPWRcBr7VjWs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711302962; a=rsa-sha256; cv=none; b=d3hV6f2Etul0ikagT73MzSkKeIklYovjWSl309Z1mxwUyvOmJu7Nz4Glzerl1EmGon06ML 02yGT+wQa3mZqIo+GqUxMr41wyneb5BgGV8WKb6fQtMo76O3YggMSKaGec9703DkuIgZGu oEkkKr9rFtezouiiUWuTGNOgFsuuOeI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=svE32i9g; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1711302960; bh=fa5fUBKyxJrg3h40phiy5mMcmrDjqBtTD6LNmVoyvRg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=svE32i9gt2Ke09RCTjMcLfFSENFh7wLFwxL9X9TGyhWJXIuDMTj3MwPb0z1nOyq6B h9QjaAOEDlECVzDLd8Z41GizDb/zc90mheuhOF/NseP8aAajhARB1NxlevFUvNpaMJ +oKzcEj7Px6xSnrwmihtVDUTYz8dQx+yr7HNFoQL6VJHu8I29NY+loVA+3fEZy3oiU lIWeGkKLwMewNN/NfcDxt6Hxd6/jtXCmDtAN3r3OPBMXUEoWEiemy4siBVXigb9F8k EqmR64nhi40Qta3N3X7CXF1QwRk03wTCvjS+jIF+aXj9MATJokg8e4bzjBTtl9yrRo RRgmh7utALcvA== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6CF983781F92; Sun, 24 Mar 2024 17:55:55 +0000 (UTC) Message-ID: Date: Sun, 24 Mar 2024 22:56:24 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Andrew Morton , David Hildenbrand , Nico Pache , Muchun Song Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: Fix hugetlb mem size calculation To: peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240321215047.678172-1-peterx@redhat.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240321215047.678172-1-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 16EB540004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u3nmzusdbab7p5c8wnhscxec8moo4dhc X-HE-Tag: 1711302961-582449 X-HE-Meta: U2FsdGVkX18VVQmXFCJJtKlcRT2lqzHR8mpuJuaWarYMbJOKLpF+amPQsJEN19GpKcEGl8Oxbfd0H5vaKwqncFr7GOTpXFch4tYT9w+ew3NWkzQiULn8S98IqGEa052SVoHoS8p13JJti6F0lLIrjFP7VHnkA2lPJfc/CH2UWMRFLY11i0qg3ObpHY2eIkdtsN/ro5f2X2R6/nzgKA1k/O9rQOz+uwEzK7KPjmLZiEyRtQW9BJUSzSqdMOd2e2z4FuNe3vp2hFDurkoppEUEVVrcs4FmkqdVHqN0EUebOiuRMcy2IHnenIeUXk8x9y+4aQ4ZTbUWjJ9b3WI03u8XeiZRRiRhHDspPdER2dQ/GxW9xJ4aEVdEF/h/5FjPD6mYeXC6arjDyHKvzTAdicMTrdmxCOSFAeqt9QUYoDxQRziMhmVs35dC5u6SJZO5D8xHPMwdhiBwIG3TbmRaO4vNLbQpOAHWSP39P/1w4Ow+DhGnHeuPRQJ7o8MY12D/Gaqy3RSZVBYuAaEL/y/jk3iiX32LYl0/o6lrzCaHQm/cMcco2bjaiV2IZqb5y3stIXewxCYqTdCoxrnEM/tC/S4ISepjpgqNXNtxRhTzUzX9e8EieUpwxTB4SGu9y71mysXKP+iWwiKomK0kYLOU51I+HSZFuj1D2Y49O7TbD4WQlCvYTf0gI/3A1AYKv3C4eL6I0XaT9KfNZNtsEUEL4gNOblgJ2x9kGWtwqf5k8JqhKViyD7LRroBxJ7fMNaNMA4EXaEagrFZI0jrzMBADy3m/z0reeat/FSX+8iVAHhdoSYut2JetYvVAWn+NGNsOg//MxGPjYLua2KieOTiTnWJJz58X4nqV5rAOGhkH/srTMdnGg8UaoR6IWYJ20sCxHl6YejGlUQcdp/XgUbrAjB1rTA++9U44FA+SoLApFV1W5pfTbwDqvGJBe7CsUCQYT2lLvLyZq+RIDA4F5ZZGy+g uJVIdfjB LxLNcCyFd4UdeRTU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/22/24 2:50 AM, peterx@redhat.com wrote: > From: Peter Xu > > The script calculates a mininum required size of hugetlb memories, but > it'll stop working with <1MB huge page sizes, reporting all zeros even if > huge pages are available. > > In reality, the calculation doesn't really need to be as comlicated either. > Make it simpler and work for KB-level hugepages too. > > Cc: Muhammad Usama Anjum > Cc: David Hildenbrand > Cc: Nico Pache > Cc: Muchun Song > Signed-off-by: Peter Xu Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/run_vmtests.sh | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index c2c542fe7b17..b1b78e45d613 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -152,9 +152,13 @@ done < /proc/meminfo > # both of these requirements into account and attempt to increase > # number of huge pages available. > nr_cpus=$(nproc) > -hpgsize_MB=$((hpgsize_KB / 1024)) > -half_ufd_size_MB=$((((nr_cpus * hpgsize_MB + 127) / 128) * 128)) > -needmem_KB=$((half_ufd_size_MB * 2 * 1024)) > +uffd_min_KB=$((hpgsize_KB * nr_cpus * 2)) > +hugetlb_min_KB=$((256 * 1024)) > +if [[ $uffd_min_KB -gt $hugetlb_min_KB ]]; then > + needmem_KB=$uffd_min_KB > +else > + needmem_KB=$hugetlb_min_KB > +fi > > # set proper nr_hugepages > if [ -n "$freepgs" ] && [ -n "$hpgsize_KB" ]; then -- BR, Muhammad Usama Anjum