From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Shuah Khan <shuah@kernel.org>, Hugh Dickins <hughd@google.com>,
Vlastimil Babka <vbabka@suse.cz>, Peter Xu <peterx@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes
Date: Mon, 24 Oct 2022 15:32:52 +0200 [thread overview]
Message-ID: <c14a306e-2814-2c9a-21f6-35d477b0fe3d@redhat.com> (raw)
In-Reply-To: <20221021125724.0bc29fdad1c696b8fe92f7f9@linux-foundation.org>
On 21.10.22 21:57, Andrew Morton wrote:
> On Fri, 21 Oct 2022 12:11:32 +0200 David Hildenbrand <david@redhat.com> wrote:
>
>> This series cleans up and fixes break_ksm().
>
> Quite a lot of fixups were needed merging this. I guess you couldn't
> develop against mm-unstable because the v1 series was already in there.
Nowadays, I tend to send against mm-stable (I remember that was the
suggestion). Usually it works because there are no conflicts -- this
time there are probably quite some kvm unit test conflicts.
Feel free to ask me next time to rebase on XYZ so I can make you life
easier ;)
>
> For this reason I'll henceforth be more inclined to drop serieses when
> I know a full resend is coming out.
Yes, good idea. While the fixup-patch process works for small
adjustments, it's not a good fit for bigger changes, especially once
involving new patches.
>
> So please do let me know when a full resend is coming out.
Will do; I kind-of did that [1] but I should have been more clear
("Please drop the current series, I'll send a new version.").
> Or, of
> course, send little fixes against the current version.
I prefer a full resend when there are bigger changes that involve
modifications to multiple patches ... which also makes life easier for
reviewers.
[1]
https://lore.kernel.org/all/87104912-6615-4917-eae1-6ae0a80677e1@redhat.com/T/#u
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-10-24 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 10:11 [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 1/9] selftests/vm: add test to measure MADV_UNMERGEABLE performance David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 2/9] mm/ksm: simplify break_ksm() to not rely on VM_FAULT_WRITE David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 3/9] mm: remove VM_FAULT_WRITE David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 4/9] selftests/vm: add KSM unmerge tests David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 5/9] mm/ksm: fix KSM COW breaking with userfaultfd-wp via FAULT_FLAG_UNSHARE David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 6/9] mm/pagewalk: don't trigger test_walk() in walk_page_vma() David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 7/9] mm/pagewalk: add walk_page_range_vma() David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 8/9] mm/ksm: convert break_ksm() to use walk_page_range_vma() David Hildenbrand
2022-10-21 10:11 ` [PATCH v2 9/9] mm/gup: remove FOLL_MIGRATION David Hildenbrand
2022-10-21 19:57 ` [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes Andrew Morton
2022-10-24 13:32 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14a306e-2814-2c9a-21f6-35d477b0fe3d@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).