From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8119BC433EF for ; Tue, 31 May 2022 16:58:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 186C86B0072; Tue, 31 May 2022 12:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 137366B0073; Tue, 31 May 2022 12:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17896B0074; Tue, 31 May 2022 12:58:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E14A46B0072 for ; Tue, 31 May 2022 12:58:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3BB4C33 for ; Tue, 31 May 2022 16:58:23 +0000 (UTC) X-FDA: 79526646486.19.5D4F1FA Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf21.hostedemail.com (Postfix) with ESMTP id BDC851C004F for ; Tue, 31 May 2022 16:58:08 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id i10so3062092lfj.0 for ; Tue, 31 May 2022 09:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=y/aNKJXZWqRuqPNJq3hEjocGGUwSzRQP7BmWbTX4fYk=; b=4fhxtldUto8lIjf5Vd/ncQaAJRtTe9kfVGUB4asPKmakTApkAdCaPdi7Bfcu0KbGjo kD49uDvDW9Xzc41t6h1FLF1KalEudS0DGuprg5CxMTW99WTyFQ9rgeAEWNJSQ314icL2 uEiI2vAgVsL0gbqL/huVqVMIF1m2OMJQvdptH/2DFrK4SBICbnNytIj/nxHMm1P3Jwaa EtldNWqKYWWlp3BKACGbSLZzh42nyIh//5qMl2jzMm3GlLAZAyHfdzVFFc9pl0Clt3ly JgGXUV1y2Qz0h3WH1ginmZ2kzSEHRS1SRECRWsgWRGXq5Sy4YeqBiqrNF8ikQmg3Wlqx gd/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/aNKJXZWqRuqPNJq3hEjocGGUwSzRQP7BmWbTX4fYk=; b=nM8M249fu/qjoQ82zwVoMhwCg+ztugUzHOcwwJa/Oj7LmrZD/47K5Bv5uenLi6ba/c +ePWNrh0RxWpPcQy+q/ie28JX3JKbbyNT6m21O+qUw8Oh3qmCtc1Aku9v4KX2Ck5HCg1 6LGprNcul2jIBKEhMx4GmXgzscTh8YxxBQF5udMNvIld3GeqEYYc4QUK9V7R1sIZPVn8 bbYlIe9uLPW4wYuyYmOcDoeVmw+uapE6SVMVPYyLWSb5dF7cPVqfnanGL49K3r1H4s6/ Lb0ffHT3Rg0jOU6BBcKWiztcqN1yIudvTo+hUwPLc60I4rjaa2jJDCWBV5fdDpQRs7nY 4R/g== X-Gm-Message-State: AOAM532ppvBV6mIsA+GioOYLNAgmJIQqbW0TIfhLFUNW6DYfeJEbcaXV Yy32u+3nzuYT++5fApZRXOxC7w== X-Google-Smtp-Source: ABdhPJz3Fl42XMGA34sRuK/Xk+fdkRg5ifvRHo3oEFZREdnnLYlDX9W+yUOzfRqB00pHmgu/BO3/Bw== X-Received: by 2002:a05:6512:a95:b0:478:82fb:7783 with SMTP id m21-20020a0565120a9500b0047882fb7783mr28720432lfu.471.1654016300830; Tue, 31 May 2022 09:58:20 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id j5-20020a05651231c500b0047255d2115fsm3063876lfe.142.2022.05.31.09.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 09:58:20 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 19:58:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5] tracing: add 'accounted' entry into output of allocation tracepoints Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vlastimil Babka , kernel@openvz.org, linux-kernel@vger.kernel.org, Steven Rostedt , Ingo Molnar , Andrew Morton , linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , Matthew Wilcox , Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , Michal Hocko , Muchun Song References: <80bcb043-3782-1d81-d8a2-4bdcb213cf30@openvz.org> From: Vasily Averin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 8tgry1ftfegjuztt7tf819pquiw8sddt Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=4fhxtldU; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf21.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BDC851C004F X-HE-Tag: 1654016288-178328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/22 14:46, Hyeonggon Yoo wrote: > On Mon, May 30, 2022 at 10:47:26AM +0300, Vasily Averin wrote: > Looks good to me. > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > a small comment: >> >> TP_fast_assign( >> @@ -33,42 +35,46 @@ DECLARE_EVENT_CLASS(kmem_alloc, >> __entry->bytes_req = bytes_req; >> __entry->bytes_alloc = bytes_alloc; >> __entry->gfp_flags = (__force unsigned long)gfp_flags; >> + __entry->accounted = (gfp_flags & __GFP_ACCOUNT) || >> + (s && s->flags & SLAB_ACCOUNT); >> ), >> > > It doesn't make sense for SLOB to print accounted=true because SLOB does > not support object accounting. Thank you very much for this comment. SLAB_ACCOUNT is not defined for SLOB, but __GFP_ACCOUNT really can incorrectly set this field to true. I'll think how to handle this correctly. Thank you, Vasily Averin