From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507C5C433DB for ; Tue, 9 Feb 2021 01:06:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0970164EAA for ; Tue, 9 Feb 2021 01:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0970164EAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6458C6B0005; Mon, 8 Feb 2021 20:06:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61B1C6B006C; Mon, 8 Feb 2021 20:06:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531416B006E; Mon, 8 Feb 2021 20:06:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 3CDD56B0005 for ; Mon, 8 Feb 2021 20:06:25 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0403C18425A61 for ; Tue, 9 Feb 2021 01:06:25 +0000 (UTC) X-FDA: 77796938730.28.D512E7A Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf09.hostedemail.com (Postfix) with ESMTP id D1C5F60001A4 for ; Tue, 9 Feb 2021 01:06:22 +0000 (UTC) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DZPnP4Gggz165Y3; Tue, 9 Feb 2021 09:04:57 +0800 (CST) Received: from [10.174.179.149] (10.174.179.149) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Tue, 9 Feb 2021 09:06:18 +0800 Subject: Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO To: Yafang Shao CC: , , , , , , , , , , , , , , References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208101439.55474-3-laoar.shao@gmail.com> From: Miaohe Lin Message-ID: Date: Tue, 9 Feb 2021 09:06:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210208101439.55474-3-laoar.shao@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.149] X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1C5F60001A4 X-Stat-Signature: t4nkrbr11jmqk9zo8gmkr9jse74eupp3 Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=szxga04-in.huawei.com; client-ip=45.249.212.190 X-HE-DKIM-Result: none/none X-HE-Tag: 1612832782-18932 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/2/8 18:14, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. > This patch is motivated by David's comment[1]. > > - before the patch > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > - after the patch > [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head) > > [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t > > Suggested-by: Vlastimil Babka > Cc: David Hildenbrand > Signed-off-by: Yafang Shao Looks good,thanks. Reviewed-by: Miaohe Lin > --- > mm/slub.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 87ff086e68a4..2514c37ab4e4 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -612,7 +612,7 @@ static void print_track(const char *s, struct track *t, unsigned long pr_time) > if (!t->addr) > return; > > - pr_err("INFO: %s in %pS age=%lu cpu=%u pid=%d\n", > + pr_err("%s in %pS age=%lu cpu=%u pid=%d\n", > s, (void *)t->addr, pr_time - t->when, t->cpu, t->pid); > #ifdef CONFIG_STACKTRACE > { > @@ -638,7 +638,7 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + pr_err("Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > page, page->objects, page->inuse, page->freelist, > page->flags, &page->flags); > > @@ -695,7 +695,7 @@ static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p) > > print_page_info(page); > > - pr_err("INFO: Object 0x%p @offset=%tu fp=0x%p\n\n", > + pr_err("Object 0x%p @offset=%tu fp=0x%p\n\n", > p, p - addr, get_freepointer(s, p)); > > if (s->flags & SLAB_RED_ZONE) > @@ -788,7 +788,7 @@ static int check_bytes_and_report(struct kmem_cache *s, struct page *page, > end--; > > slab_bug(s, "%s overwritten", what); > - pr_err("INFO: 0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", > + pr_err("0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", > fault, end - 1, fault - addr, > fault[0], value); > print_trailer(s, page, object); > @@ -3854,7 +3854,7 @@ static void list_slab_objects(struct kmem_cache *s, struct page *page, > for_each_object(p, s, addr, page->objects) { > > if (!test_bit(__obj_to_index(s, addr, p), map)) { > - pr_err("INFO: Object 0x%p @offset=%tu\n", p, p - addr); > + pr_err("Object 0x%p @offset=%tu\n", p, p - addr); > print_tracking(s, p); > } > } >