From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: sohil.mehta@intel.com, baohua@kernel.org, david@redhat.com,
kbingham@kernel.org, weixugc@google.com, Liam.Howlett@oracle.com,
alexandre.chartre@oracle.com, kas@kernel.org,
mark.rutland@arm.com, trintaeoitogc@gmail.com,
axelrasmussen@google.com, yuanchu@google.com, joey.gouly@arm.com,
samitolvanen@google.com, joel.granados@kernel.org,
graf@amazon.com, vincenzo.frascino@arm.com, kees@kernel.org,
ardb@kernel.org, thiago.bauermann@linaro.org, glider@google.com,
thuth@redhat.com, kuan-ying.lee@canonical.com,
pasha.tatashin@soleen.com, nick.desaulniers+lkml@gmail.com,
vbabka@suse.cz, kaleshsingh@google.com, justinstitt@google.com,
catalin.marinas@arm.com, alexander.shishkin@linux.intel.com,
samuel.holland@sifive.com, dave.hansen@linux.intel.com,
corbet@lwn.net, xin@zytor.com, dvyukov@google.com,
tglx@linutronix.de, scott@os.amperecomputing.com,
jason.andryuk@amd.com, morbo@google.com, nathan@kernel.org,
lorenzo.stoakes@oracle.com, mingo@redhat.com, brgerst@gmail.com,
kristina.martsenko@arm.com, bigeasy@linutronix.de,
luto@kernel.org, jgross@suse.com, jpoimboe@kernel.org,
urezki@gmail.com, mhocko@suse.com, ada.coupriediaz@arm.com,
hpa@zytor.com, maciej.wieczor-retman@intel.com,
leitao@debian.org, peterz@infradead.org,
wangkefeng.wang@huawei.com, surenb@google.com, ziy@nvidia.com,
smostafa@google.com, ryabinin.a.a@gmail.com, ubizjak@gmail.com,
jbohac@suse.cz, broonie@kernel.org, akpm@linux-foundation.org,
guoweikang.kernel@gmail.com, rppt@kernel.org, pcc@google.com,
jan.kiszka@siemens.com, nicolas.schier@linux.dev,
will@kernel.org, andreyknvl@gmail.com, jhubbard@nvidia.com,
bp@alien8.de
Cc: x86@kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org,
llvm@lists.linux.dev, linux-kbuild@vger.kernel.org,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 10/19] x86: LAM compatible non-canonical definition
Date: Mon, 25 Aug 2025 22:24:35 +0200 [thread overview]
Message-ID: <c1902b7c161632681dac51bc04ab748853e616d0.1756151769.git.maciej.wieczor-retman@intel.com> (raw)
In-Reply-To: <cover.1756151769.git.maciej.wieczor-retman@intel.com>
For an address to be canonical it has to have its top bits equal to each
other. The number of bits depends on the paging level and whether
they're supposed to be ones or zeroes depends on whether the address
points to kernel or user space.
With Linear Address Masking (LAM) enabled, the definition of linear
address canonicality is modified. Not all of the previously required
bits need to be equal, only the first and last from the previously equal
bitmask. So for example a 5-level paging kernel address needs to have
bits [63] and [56] set.
Add separate __canonical_address() implementation for
CONFIG_KASAN_SW_TAGS since it's the only thing right now that enables
LAM for kernel addresses (LAM_SUP bit in CR4).
Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
---
Changelog v4:
- Add patch to the series.
arch/x86/include/asm/page.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/x86/include/asm/page.h b/arch/x86/include/asm/page.h
index bcf5cad3da36..a83f23a71f35 100644
--- a/arch/x86/include/asm/page.h
+++ b/arch/x86/include/asm/page.h
@@ -82,10 +82,20 @@ static __always_inline void *pfn_to_kaddr(unsigned long pfn)
return __va(pfn << PAGE_SHIFT);
}
+/*
+ * CONFIG_KASAN_SW_TAGS requires LAM which changes the canonicality checks.
+ */
+#ifdef CONFIG_KASAN_SW_TAGS
+static __always_inline u64 __canonical_address(u64 vaddr, u8 vaddr_bits)
+{
+ return (vaddr | BIT_ULL(63) | BIT_ULL(vaddr_bits - 1));
+}
+#else
static __always_inline u64 __canonical_address(u64 vaddr, u8 vaddr_bits)
{
return ((s64)vaddr << (64 - vaddr_bits)) >> (64 - vaddr_bits);
}
+#endif
static __always_inline u64 __is_canonical_address(u64 vaddr, u8 vaddr_bits)
{
--
2.50.1
next prev parent reply other threads:[~2025-08-25 20:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 20:24 [PATCH v5 00/19] kasan: x86: arm64: KASAN tag-based mode for x86 Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 01/19] kasan: sw_tags: Use arithmetic shift for shadow computation Maciej Wieczor-Retman
2025-08-26 19:35 ` Catalin Marinas
2025-08-27 6:26 ` Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 02/19] kasan: sw_tags: Support tag widths less than 8 bits Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 03/19] kasan: Fix inline mode for x86 tag-based mode Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 04/19] x86: Add arch specific kasan functions Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 05/19] kasan: arm64: x86: Make special tags arch specific Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 06/19] x86: Reset tag for virtual to physical address conversions Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 07/19] mm: x86: Untag addresses in EXECMEM_ROX related pointer arithmetic Maciej Wieczor-Retman
2025-08-28 9:50 ` Mike Rapoport
2025-08-28 16:22 ` Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 08/19] x86: Physical address comparisons in fill_p*d/pte Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 09/19] x86: KASAN raw shadow memory PTE init Maciej Wieczor-Retman
2025-08-25 20:24 ` Maciej Wieczor-Retman [this message]
2025-08-25 20:59 ` [PATCH v5 10/19] x86: LAM compatible non-canonical definition Samuel Holland
2025-08-27 6:32 ` Maciej Wieczor-Retman
2025-08-25 21:36 ` Dave Hansen
2025-08-26 8:08 ` Maciej Wieczor-Retman
2025-08-27 0:46 ` Samuel Holland
2025-08-27 6:08 ` Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 11/19] x86: LAM initialization Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 12/19] x86: Minimal SLAB alignment Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 13/19] kasan: x86: Handle int3 for inline KASAN reports Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 14/19] arm64: Unify software tag-based KASAN inline recovery path Maciej Wieczor-Retman
2025-08-26 19:35 ` Catalin Marinas
2025-08-25 20:24 ` [PATCH v5 15/19] kasan: x86: Apply multishot to the inline report handler Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 16/19] kasan: x86: Logical bit shift for kasan_mem_to_shadow Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 17/19] mm: Unpoison pcpu chunks with base address tag Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 18/19] mm: Unpoison vms[area] addresses with a common tag Maciej Wieczor-Retman
2025-08-25 20:24 ` [PATCH v5 19/19] x86: Make software tag-based kasan available Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1902b7c161632681dac51bc04ab748853e616d0.1756151769.git.maciej.wieczor-retman@intel.com \
--to=maciej.wieczor-retman@intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=ada.coupriediaz@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.chartre@oracle.com \
--cc=andreyknvl@gmail.com \
--cc=ardb@kernel.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=graf@amazon.com \
--cc=guoweikang.kernel@gmail.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jason.andryuk@amd.com \
--cc=jbohac@suse.cz \
--cc=jgross@suse.com \
--cc=jhubbard@nvidia.com \
--cc=joel.granados@kernel.org \
--cc=joey.gouly@arm.com \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kaleshsingh@google.com \
--cc=kas@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=kbingham@kernel.org \
--cc=kees@kernel.org \
--cc=kristina.martsenko@arm.com \
--cc=kuan-ying.lee@canonical.com \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=pcc@google.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=ryabinin.a.a@gmail.com \
--cc=samitolvanen@google.com \
--cc=samuel.holland@sifive.com \
--cc=scott@os.amperecomputing.com \
--cc=smostafa@google.com \
--cc=sohil.mehta@intel.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=thiago.bauermann@linaro.org \
--cc=thuth@redhat.com \
--cc=trintaeoitogc@gmail.com \
--cc=ubizjak@gmail.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=weixugc@google.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).