From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A4CC43334 for ; Thu, 9 Jun 2022 12:46:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55EB78D0013; Thu, 9 Jun 2022 08:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50F0A8D0006; Thu, 9 Jun 2022 08:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AEB68D0013; Thu, 9 Jun 2022 08:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2B7158D0006 for ; Thu, 9 Jun 2022 08:46:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 07816810F7 for ; Thu, 9 Jun 2022 12:46:18 +0000 (UTC) X-FDA: 79558670436.08.F528458 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 562B740085 for ; Thu, 9 Jun 2022 12:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654778776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=bfaVa0reba5JNx1JCCi449akB/iE7w7HJkh+iPewcoKUtXRVntBOZRj18BsRFXEJQD7Xt3 GObsr5AzbK9k5Qx9iLnaJWAyVgOUUAb6wweVt7qXGOICRsO1ol959im5WFYdFixia0rC7b ZHeTquzJ+C6aZV+E1vVG8wDxl9vLE1g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-454_jFzUObWzePg_RevdFg-1; Thu, 09 Jun 2022 08:46:15 -0400 X-MC-Unique: 454_jFzUObWzePg_RevdFg-1 Received: by mail-wm1-f72.google.com with SMTP id h189-20020a1c21c6000000b0039c65f0e4ccso1526202wmh.2 for ; Thu, 09 Jun 2022 05:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=yNL6778QEY6BDgRGHjMKSKXvlM8grjlKv2LkZjGzXHTN8hNrg3Qz3Lm4L1zbgn6wMb 9rBX/BW8MrLaxf35sCBrDk2J9JU/BK7h9lNl7QdCV+8zgOzaw5eQxG6/Nny34KbvkCZf PooGCi9jz/Vh7ffI7IeDKPgg9sX7wY1s+279ybUIgJVKgH9Zf80Yut1JKaq047HlyPcT DvlHxpvJmmrD6pGhQqun1Dxg7jk0H97bvni6QYpmfV+FgZ3+ILF2652poDthCxI0lm3Q tbL07YtgoNCAB0X7hUBQVnfgVvToalYPbq5ypVH50HPA403Qm7Lq27DRFbe8iUtGYT/k q8dQ== X-Gm-Message-State: AOAM531vWTdUIH2HcLy3aKl14YCsUfOq50Swjb3uedp5DxNTtpaW+5vw oLEOn8EzmBuAo87CN9rT8FcX4WZFsfNTy8BOsmPdM6zBTQ6RONPVG8u5JmNIQsAogE/fgLJiTuw qDV9z/UB7Q+k= X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022148wrd.283.1654778773729; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFg5i2EPJ88Gv87gtw7EHVrLhSwsyQAltgpPZk1DxRKIUlDObIOhdmhH9jKki5ThpOI9Vqng== X-Received: by 2002:a05:6000:168b:b0:218:54da:90ba with SMTP id y11-20020a056000168b00b0021854da90bamr12022117wrd.283.1654778773451; Thu, 09 Jun 2022 05:46:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id a7-20020a05600c224700b0039c693a54ecsm3854607wmm.23.2022.06.09.05.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 05:46:12 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 14:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 01/19] secretmem: Remove isolate_page To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654778777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zufIRXqzWNkS/vBQ6LnlofDt3t0aO0GgELLgxZEV3qM=; b=ShAcN4pWJ5JFC4pI007yTJXM1k4ZvrUwAM1psTSsESpm4Q/AJP+X97YxQqgDOIQ7qj7NbU fnj6z34ixePsnUt5X8r6RPpUxV7PGc+o05ZkMjKllnR08zThbKyRH6xRd8Nt+/1D21/F2n xNXL5zkp7lsCD1Wil/CwgaKtwh6D43E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfaVa0re; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654778777; a=rsa-sha256; cv=none; b=2dFIRFBsDv4XpJmnxXfXVAGjmApFVZQ8Smg7kWgcJRjS7+lDKTytJ/ODoTVjbUZYSntNSF 6+/qsY/qqE8dGWcyRhskHp2F+FELOtiwC3fOXbB6kSoafAfJanw0EfkSvtBBu5HxWEGvib LvezPvZOcLVD3OCmKUOOcWRs8paL900= X-Stat-Signature: bj51odxbjtwg8hm4bd6gh1ekx9pje3an X-Rspamd-Queue-Id: 562B740085 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfaVa0re; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1654778777-556261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 206ed6b40c1d..1c7f1775b56e 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = { > .mmap = secretmem_mmap, > }; > > -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode) > -{ > - return false; > -} > - > static int secretmem_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = { > .dirty_folio = noop_dirty_folio, > .free_folio = secretmem_free_folio, > .migratepage = secretmem_migratepage, > - .isolate_page = secretmem_isolate_page, > }; > > static int secretmem_setattr(struct user_namespace *mnt_userns, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb