From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566DDC5320E for ; Mon, 19 Aug 2024 09:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E222A6B0088; Mon, 19 Aug 2024 05:44:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAA626B0089; Mon, 19 Aug 2024 05:44:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFC476B008A; Mon, 19 Aug 2024 05:44:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F1176B0088 for ; Mon, 19 Aug 2024 05:44:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 468AA810AC for ; Mon, 19 Aug 2024 09:44:48 +0000 (UTC) X-FDA: 82468510656.08.2218331 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 08AE4140011 for ; Mon, 19 Aug 2024 09:44:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FFsxwRZK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724060599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X7b+bc2Fo4YhsnAnVepxHT46haDI0ngnxKTuXpjd31Y=; b=oB8HVquObhJNBQWH58xZ5XrOtb4RM3PBIhRwl38QpgfOtmEH+q8Rql45TPzoOMKA0qTmoj Yu2SJ37/sqN3+4a+NRphCMyAxK80P1VVoUFu4+stXxerAj9F7axm7wNwA8lOthAmOEOTx4 j/jd3h271PyLiF/CteF/8e8/xPBfMxg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724060599; a=rsa-sha256; cv=none; b=eGjZ0X2IePJSAZkAegG2IkvimLb4h7kjqjl3mP2YtViT2fRBoNM1T5B1LSI3A1RBxCVS4q Uq1JiCyX4wnpnHAZ88/y4H7b3wOxf0yLNsIrmKOMyN/teqLjzVx6TIB9Hq6A/wFSx6dKQP y9pVs81Bt0h8dP+LhQXCy/U6xGRyyTM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FFsxwRZK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724060685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X7b+bc2Fo4YhsnAnVepxHT46haDI0ngnxKTuXpjd31Y=; b=FFsxwRZKe5vJyfBawrr4raYB8CCQeuoyqFU7UdXS6ZBngJpmfvZYiDdpd37GFPAmEZwsyu wyiyVI573s5dSwnjqVfaqE6AqQr+8joo5ZZaRg3je5T7OWRkm3EPXiauw4nOq6v59PeiZ8 gTc6V8wNGA6icOy2Jkx3G6blr2EHtz8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-9K--Q3alNHeUG6Q3pTbZwA-1; Mon, 19 Aug 2024 05:44:43 -0400 X-MC-Unique: 9K--Q3alNHeUG6Q3pTbZwA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-532fbabc468so4274465e87.0 for ; Mon, 19 Aug 2024 02:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724060682; x=1724665482; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X7b+bc2Fo4YhsnAnVepxHT46haDI0ngnxKTuXpjd31Y=; b=RAktAKZbMq0XrBjfmMrjttrK7w4goD2w2ht/Z9xSag8fev5FmArKkp1UU/KpM1w8dr yao+k/Y7ZXkmuBlSyxgH/oZwnmJllnyjRna5nAe7VAHMov8GuSyCGSW6i2RfF9HmtGVu OKNDKMozCgE97ftEymTmVmImU0q4PxeYV1CcFD7Tlxkru3xFlvpgXLoTyljBy38zSzS1 MebuVfQnfoT60vCM9/BTVaPxD9ang9772+VLns4G4msHvDM06wSSyvG2jc8S3Sv/v9yK jYuosOojT+dgH0KRS5Kg9Ytw25Ds9kycFMA+HHl2BJ7Mwo9BaIl/7L1V/3ef9ZELIa89 +54A== X-Forwarded-Encrypted: i=1; AJvYcCXJ1opC5eZ9poVqCfajnHj7H+RpAsxvAn/46eHxlAcCwOLyDr9qRajsvhkry0TKD7MuveYmfATv0rH2V+r3DkcCc+U= X-Gm-Message-State: AOJu0YxjVxg91QQ/sRu/mybh9gZp9REZpj7VSRKAyAVQEbv380H/3Err Xb/b5n0nSEZKXszckkSaohf0t+SbhP1wuM92QIpjU1edGp8UvosvgRv0YLHDy8pReYwMxJkpsMt XIfJZFu+QNyEnTmx+2ceFZJCksx8DEAvJLgWMblSfsy0/21bH X-Received: by 2002:a05:6512:3190:b0:52c:f2e0:db23 with SMTP id 2adb3069b0e04-5331c6e23dbmr7076109e87.40.1724060681645; Mon, 19 Aug 2024 02:44:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbYGv1dAC8BOp9d/6TNk5lzGG8ZgJtu5nNzr+cDStN+Hg3fhU03hbsM1RivhzFc0Ut8BK3Ug== X-Received: by 2002:a05:6512:3190:b0:52c:f2e0:db23 with SMTP id 2adb3069b0e04-5331c6e23dbmr7076080e87.40.1724060681068; Mon, 19 Aug 2024 02:44:41 -0700 (PDT) Received: from [100.81.188.195] (ipb218f908.dynamic.kabel-deutschland.de. [178.24.249.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8383935710sm609276466b.129.2024.08.19.02.44.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 02:44:40 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 11:44:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: prohibit NULL deference exposed for unsupported non-blockable __GFP_NOFAIL To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, Lorenzo Stoakes , Kees Cook , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Wang , Maxime Coquelin , "Michael S. Tsirkin" , Xuan Zhuo References: <20240817062449.21164-1-21cnbao@gmail.com> <20240817062449.21164-5-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817062449.21164-5-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 08AE4140011 X-Stat-Signature: qb55hnquikg91gk7mttojhopk54f8jrz X-Rspam-User: X-HE-Tag: 1724060685-333068 X-HE-Meta: U2FsdGVkX1/T3DVtz/UouCRfKtCexqCh/vDKaH4jiKdOAg527fs7PPLjHTP6ngclIwd2y8T4cdQxMNY8vqFUpqhTLQKgYFlzlaY0q2d7VrZlECLdZQqu/RXpM68wpmpJwRgBiErcn/5u8PTA7Y5Bpg/vlYpg1kCInQ6ag1geduLMWDJ6nzbM8vwS5C4zNrjPECWo11+FyUVXngBI+AcrwVIF4NFt/xQfWGNxdzz3rqmTQEQuUWAKxmDuRZxgQ466UhPkw3VcSAly33SvotPPQc7qJksLV/XCN7+LXMA2k56AaFy8YgUuc6WnyyNP8a7RbddkysglfPa3iR2Sl3rxrT17JVtbQosCpu/3f19G6GLv3CzrCosMgPjVNbIXJRZ2L946RwIt2/Y9tLM2eH3GS4HdW2TTKsrbmFz+tjVpEAG64y7kriHOq25gE6d5WxU1E+H8iJoT53OJOFnsquqZIFxQqdKYe63W0rdnOL2ugTQ+mblAIFh6+3lAYpy5x+MuGSEyHR0yhMqtSL8U9j7F1Jf2rfPPNnXn+ii6sjzBeu2gPgrch4y4c5OU6exD0Riihsy59TM2ekebO3fuzY3ZE+WONxSqWnRIdrKuxMeyqiJ0LQWU5xFNn1zsoo+QnmDTRcdlvP00NkxDr5YwUFQd3xwzQCNqBRcLOy4QNiYxDO8Ms5ez4ir5bmHhNR4yf/OQT/5Do0Up0413cuHkUMHchQ/j1Y466DM9uAOsuEqLN4///SnqilABxFkj9pEua8fRhFtA7kGLYFPJkacPsAPtYBc6u+w1sMueGGlt0SyoIc93TEdAvZOz1BWioEUa489pF42SYfsxYw/TqP9JRd59YXV5j2A1J6hvTP+tTdomY/bVMDgRw7hGbR3k/LjOh5gaWyKgHXUn1zwWxPui8H490MsdEzbF8vJtUHp2OihEYIm4ZX3gZXHlFI/Avcsqob3/6ewHB14RT9Mdc2puKc5 x6vmqIbh /BE3gVke8n9ImxIoRMafT0acuXWkFd18iNWn/8Pq3u/xdswLL+J0p8IpvOBhVLOgT4ySBA8uMzdAgQBZ6avwWwonIU8TDZznXFZrv7Nll58QuR4h/TqP5kulqyH3vFkiYe/HZT+rkEfa8PoEHasU/P6OW0Mmjb8VVfyH5mhQ2TrOBmmx7peYR/m38eGaSoQCrJp+v91kBXyT6qj+/gGkUbhYWHxUhYa7wC7B6LJvkXkGqAJ3fdl91aXj8yEJdfktDoITBSROm93x7TnCUc3KZQUPAQE3cSV02K5M/ARNm20tawSsafrecH+HzBAj3oJHz2ZKpsJNYNHanWetbrFrfI0bQHv8YMJjDGLsw4E0vTyMqWRcIwRRifzE1kZwUFmCbKTOy7y4Gzq639vnxF6Weuzq/RZzPgkiElO5+jtZJ2HFdP9xPPiIdoILB7VTj+ZcUB0O1yBuT9va2ixkRQmLTOZ1cN0eKcRHJWeidJANQBVjeVwyMddUSBECjD+RRex3M+o7/ePGAkeicWQMWmXv82mQRFSmS4wkXHRVcWiiOpO5ZMwx1bfU/8X509FsAfakWVwU2eGF6EJ30b3JVXco4RtDaHHXGj7wkA6vYYRz5s8h/20ZaEEgVgqzWNsM8RngudZnVeqR94LK+xVHqJF7IUTJjrQCgfqloDr1dCCbxD6+SmT1vl/1zftNnN3tIZp0VHI9nqTBe53P3dMyYkRiZN1x0A8FTnHM/k0eX94w3MQ1zTQG21U+dmAB5RIZcXABdLfguI1MD5FhWiNwOxr3RJz9YENETFGkVZGrvJmSYrisN0Mft+F23ijLo3wAuGfsD1EIKqTuauN46AjeSw2TlPUUDWh8wi3yO7HngkFj///sUN8AAg9HmiYTyPp154h6NpbWV2I0ZBZyuyOaj2V4qyjThcKX9KkEpIjYBE/2a33/22E+mLe57EwHY7QB0fGBCn7lmRayLGkgpNVkZJadLAnoGKdbl 5duIAzw5 69t63rbHJRnywDMDNuSQSz35gMNNePeRpZ4WVcrecwLNhXFjVqZhxPx+RGm7rlofmIFsPkocERjSFaIgWHmTSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 08:24, Barry Song wrote: > From: Barry Song > > When users allocate memory with the __GFP_NOFAIL flag, they might > incorrectly use it alongside GFP_ATOMIC, GFP_NOWAIT, etc. This kind of > non-blockable __GFP_NOFAIL is not supported and is pointless. If we > attempt and still fail to allocate memory for these users, we have two > choices: > > 1. We could busy-loop and hope that some other direct reclamation or > kswapd rescues the current process. However, this is unreliable > and could ultimately lead to hard or soft lockups, which might not > be well supported by some architectures. > > 2. We could use BUG_ON to trigger a reliable system crash, avoiding > exposing NULL dereference. > > Neither option is ideal, but both are improvements over the existing code. > This patch selects the second option because, with the introduction of > scoped API and GFP_NOFAIL—capable of enforcing direct reclamation for > nofail users(which is in my plan), non-blockable nofail allocations will > no longer be possible. > > Signed-off-by: Barry Song > Cc: Michal Hocko > Cc: Uladzislau Rezki (Sony) > Cc: Christoph Hellwig > Cc: Lorenzo Stoakes > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Linus Torvalds > Cc: Kees Cook > Cc: "Eugenio Pérez" > Cc: Hailong.Liu > Cc: Jason Wang > Cc: Maxime Coquelin > Cc: "Michael S. Tsirkin" > Cc: Xuan Zhuo > --- > mm/page_alloc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d2c37f8f8d09..fb5850ecd3ae 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4399,11 +4399,11 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > */ > if (gfp_mask & __GFP_NOFAIL) { > /* > - * All existing users of the __GFP_NOFAIL are blockable, so warn > - * of any new users that actually require GFP_NOWAIT > + * All existing users of the __GFP_NOFAIL are blockable > + * otherwise we introduce a busy loop with inside the page > + * allocator from non-sleepable contexts > */ > - if (WARN_ON_ONCE_GFP(!can_direct_reclaim, gfp_mask)) > - goto fail; > + BUG_ON(!can_direct_reclaim); No new BUG_ON(), WARN_ON_ONCE() is good enough for something that should be found during ordinary testing. -- Cheers, David / dhildenb