From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A329AEB64D9 for ; Tue, 4 Jul 2023 08:30:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 187E428006B; Tue, 4 Jul 2023 04:30:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 137F490000D; Tue, 4 Jul 2023 04:30:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F198D28006B; Tue, 4 Jul 2023 04:30:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF54290000D for ; Tue, 4 Jul 2023 04:30:14 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D151C0999 for ; Tue, 4 Jul 2023 08:30:14 +0000 (UTC) X-FDA: 80973257148.09.19E3D10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 479FAA0010 for ; Tue, 4 Jul 2023 08:30:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7owGOlD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688459412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jMe050D13WY1uaScFpdas/d0b3mrsdGbmrzs7inJNzM=; b=ckQxgPXn19X+V0QFav4MhiOdB0hB+3NviR5ezciA7ZFO3672Y7ngKMPdANCixIVejVp9ui 1rp9BdpIXaZ7mEAaEX/lOOoaRiTHvN8umI8An1pNVib8eMewjmw80tMfLWsConaFy/2r0g cF045dk3Yd8mhrbprbrI+pdrpHqE2Po= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7owGOlD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688459412; a=rsa-sha256; cv=none; b=nEIss3WW6VcJaoVEzpqvoywdr4xgf6I5N97E967h4rQIeS2a8UAhOFhdslWxtGPtUmvoRZ HJDgFBa1SC8XNgntr6qSfE4357sCZEbax8BFPcYLtjBP7rs9gaTcMSADmA995CISKLce04 nF3aT5IJ76MWO4vu47cMBRNXEau2JXA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688459411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jMe050D13WY1uaScFpdas/d0b3mrsdGbmrzs7inJNzM=; b=h7owGOlDL29tHv4PWMhcVqd9PboLu7EJhsLZpOf0eRCLMw5OSc4+qzODKJIjL4ABQULq6+ EBezIGM1WtNxg69vaFeVc9CS/6vB5XUOULg1TlX8ep3Cm26IEh90FaPt9U8c17GvnRG7cZ jrDmSLoNCMFif6iOsAX3hsfUQojy/kQ= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-jM3CgNjDNUK1OXvWyb6_Qw-1; Tue, 04 Jul 2023 04:30:10 -0400 X-MC-Unique: jM3CgNjDNUK1OXvWyb6_Qw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-988e344bed9so449928466b.0 for ; Tue, 04 Jul 2023 01:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688459409; x=1691051409; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jMe050D13WY1uaScFpdas/d0b3mrsdGbmrzs7inJNzM=; b=G/BtcJE4lySIm+njsDse+XFXITLcZJHIXpkjNz+d/VJETdl/ZZX294TSDMmESB0EP9 UAEPvtAtkugyUI7kFQT8wajBiqW+4p9VHIJcSXca0DoELF2VCLHEN0FW1mJFFVaOhz99 Wpl8o1hNjzpf++yhQKP9pnhQDmlp+uVZcTnAKJ1Bh55ZkN27OocuEWSVwMGkXA6ezZjX WFr+05XrcCvvls2klGuf836qy7PSZ6VLcvGzns3CXIeVRSKRGSZdpbYILURA2nXDX8ud XL5TB0MHEiGxrmdFJOBDJrKDFUyHg/dcsXBWAsGDXuoNBDQegAuJ00AYa8OAosH6ubjL v8gQ== X-Gm-Message-State: ABy/qLYgHpo0+qXYjpmBId2JgE2gxbqinP/48VOs0zsVoEUUeEqXhWoe YADwU82VBen9QU1kPI6H1XSAexeDC3ZPr4zPOpVXJJwlIghbIwDAu+mk3RtLEAP/12Qt/K/YXpi w1MhegVGHalQ= X-Received: by 2002:a17:906:11c9:b0:982:b920:daad with SMTP id o9-20020a17090611c900b00982b920daadmr10024598eja.71.1688459409128; Tue, 04 Jul 2023 01:30:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4T2NP2N2wePSULvVTtY5otoNRZ6cofVmW9Hdstaf4NxGERyuE+FFQWYbB4oXDXP0hRnE2f1A== X-Received: by 2002:a17:906:11c9:b0:982:b920:daad with SMTP id o9-20020a17090611c900b00982b920daadmr10024557eja.71.1688459408771; Tue, 04 Jul 2023 01:30:08 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id l16-20020a1709065a9000b00988be3c1d87sm13006895ejq.116.2023.07.04.01.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 01:30:08 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 10:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed To: Linux regressions mailing list , Suren Baghdasaryan , akpm@linux-foundation.org Cc: jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org References: <20230703182150.2193578-1-surenb@google.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ydrauna6m6j8es3i1agaz9q84eb1tbp4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 479FAA0010 X-HE-Tag: 1688459412-999645 X-HE-Meta: U2FsdGVkX199mU33woIog9XxncnTM+FkXptwY10CHS8egW6MNYw3KvCH4MfoDYEr49/lBaKkmq2+Sh2zoKA1WxZn637vhjeUOjM7qGIy1MOumYNMzI/N6syFudisXlhOrOG1F1zk8odY+Tt3hudC05PW3egOeufVDRV5zmlb7q+o9mKzwpWCrqW3rH/YsGr9py8OsBUCXdi5iLHHBJ/y3beQXDCGmIHqiBQre32HUxZUhND6J03wIZM7lDRoQ9PJoiSAyyP4nJld9XsqqjlmNoMjO+m0zTEdL/Wh1fyGBy0mj1lXNiMyt8/iMRDCvVSTtEENT9s++tP4I+ae/BnD9fdMMs6S9gdt7oHvd8QVQUOoh60QsUn5u1c0wk9GAiYuuVed+Mr8u+uTwwfkBloVcI4bUMKP37ehhdpUPGABbHfVdVOXSCDTZ3iLeAgPXZfcOAPEmOqgT0toJuEVAYSt+QSfox4ye5M2IHquU/qIR3EKIBeOjW7WYW5OOvXKdGTH5plXAV7dqxFeyRreKLgTCmB97AhebcXXxAazYzVrc7NLWk0yp8MWARAw/ZpERoGMMnZv4Eq/IDZ1JLs3UqOc6Rx3OW++p967eD4DkkP70VXsdsrSR+In7TrIrW1L5v1YzPFbJrzSfSFXfHuTkswyYm/Yk3vhLV+fzTsVS5DEtreI7FYkYIbyDmNgowUN8KY559ZwIbw+QVBlpPmBIvZMjJi+QoylatNKJx0sHYM5VyBUYTKQmuWOWQlCznN7byMb/FMXFqDNHK7EJAMO5VhfItZ9r5pgVPW7lV05T+SJpo/s+NUvoZa4h/yu7OgF4psL/2l3J3DKOifYJv4VBt6+nzHLGxjHiM/1SjpsH1FHZwiOR87Rl5AEquD30vrzyHiQQCPlF3WPJZvP8vtYvshaa0nG3Ixl3cUbMl+NcnVZPgLbqqKrnc4LR5U1fWHDRFyAMguXwPqLGu55SwzNQg6 kbhC4uvN eExbzw+DrSA7rHlmKE/bNCZ4c9P4jJnQpiDuv1OiL5gc1paTJ7bqyqv2Fkgmz0QtYv53qnqYaKEdVyjqrymYCJyWAGZflKSfLF4R125TSq88ooenoPJkgOtLXtj0RR23DgdJzDKY6XbySRUclgZkDvhN+wTKciP3bTKx83ONYov3F0My1IVIF7raYGNjxhIqd4lr47KXNwO36FRGWBxVnY6LxFrIY6xyoyvwi0eyZMFjDlA1wY0+XRa4RhT/kcb/GOYzklM4mQFwUM6ZnIpTCv68FgsFNd0zKyw0J1SphbwMrEIc2oaq+wleJoOhuj5/NkrlnJ80crExexSxvfNmQq/0G9fq1IwzJnYrFa/GY1DvLei3aGDIPow23cKbu60HB3R6dMe+q5V1ZcI4CGuFiiZDJ7aNp5nWFFZGCVWXlyA2QvrWUilsN47Wod5Hg1JVDnAZ2ZjMp4nBwnWm5+sBAx0mScxDJCmOAP2W2hP7rzJq+VJM0GIuVvyMRtPzQgZalvviyv1JpvfcstJjJDn+/Mx9GKdOQw108HmgliRXWOu7SAvZpRkByy4M/V3kAgcgEkeRG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 7/4/23 10:12, Linux regression tracking (Thorsten Leemhuis) wrote: > [CCing the regression list] > > On 03.07.23 20:21, Suren Baghdasaryan wrote: >> A memory corruption was reported in [1] with bisection pointing to the >> patch [2] enabling per-VMA locks for x86. >> Disable per-VMA locks config to prevent this issue while the problem is >> being investigated. This is expected to be a temporary measure. > > I have to wonder: is disabling by default sufficient here? Sure, it's a > new feature, so once this change is merged and backported to 6.4.y it's > not regression for anyone that will do the jump from older kernels to > 6.4.y and run oldconfig. > > But how about those that did the jump already or will do so before the > fix is backported (it's possible that Arch Linux and openSUSE Tumblweed > do this; and there is a certain chance that Fedora already has > CONFIG_PER_VMA_LOCK enabled in their 6.4 configs, too)? This sounds to > me like many of those will have CONFIG_PER_VMA_LOCK enabled in their > configs now. And unless I'm missing something switching the default > won't turn it off next time they run make oldconfig -- or will it? So > for them the regression won't be fixed (unless they fiddle manually with > their configuration, but they shouldn't do so to fix a regression). > > Or is my logic mistaken somewhere? Your logic is correct I just tried Suren's patch with my local tree and it did not change a thing. If you have an existing .config this patch does nothing. Regards, Hans > >> [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > > Side note: that should be a proper Link: or Closes: tag as described in > Documentation/process/submitting-patches.rst or > Documentation/process/5.Posting.rst -- and it should be close to the > Reported-by: tag (checkpatch.pl should have mentioned that). > > E.g. like this: > >> [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com >> >> Reported-by: Jiri Slaby > Closes: > https://lore.kernel.org/lkml/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ >> Reported-by: Jacob Young > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217624 [1] >> Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") >> Signed-off-by: Suren Baghdasaryan > >> [...] > > Ciao, Thorsten >