From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D92BDC3DA42 for ; Wed, 17 Jul 2024 12:02:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BE76B0092; Wed, 17 Jul 2024 08:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C8C6B0096; Wed, 17 Jul 2024 08:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC246B0098; Wed, 17 Jul 2024 08:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0AE236B0092 for ; Wed, 17 Jul 2024 08:02:37 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 89F50A5973 for ; Wed, 17 Jul 2024 12:02:36 +0000 (UTC) X-FDA: 82349107512.16.3536C50 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id DF13240008 for ; Wed, 17 Jul 2024 12:02:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=khuYUIcp; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721217735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mCKRcoxTSP4PVJBrlW4Y8chPBSfToFO6AdzhEtT5Htg=; b=KaDF4a05ELJALvimCa0fPs0iVaXWLZBVS6WBQM+GDUCGGgq4DgDipbFD1ZShTnDI1EJUwi +VWC1IvkS77EsxghNxvY3WuRfwIl8kFGBXsBFjEKTvCEbR5A97kTlgGihQaqVvVQ2cIGhu DDJiBvkNXlDF/rntdeSWvRfls4FrXBU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=khuYUIcp; spf=pass (imf17.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721217735; a=rsa-sha256; cv=none; b=Fj18rwmNPPWN42cya4wKXOrH/tmzzr9YXPvfAkLQ4BLyFx9gQ+jFzIPDmgOI+AJO1cdx4e wo87sC1TxlTJRNMFBO1bf6CdOtBKzmYUk/zay2svQTD/Bml2PkiVJ7Kjxw65iiRUvOrVTv gRRAP/QJp5shiVUMgLKFdTrEV7jLLCQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 03C09CE1762; Wed, 17 Jul 2024 12:02:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D682C32782; Wed, 17 Jul 2024 12:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721217746; bh=oM3E3goVqw64c2eh3l0kIUzj/O0do9v5lib+X/nif1s=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=khuYUIcplwyWI5Bbl2oW6+exSQ1OQDSFHDacuVQsTYYB0JaLL84lDNX0K24YFsoHc CtSOPiRUOdsjIrBxU3iiwVHZN3G6AH8utEC9LJf3P6U6JGqYjZryTR5hkEObv3f39L PXkiRhiRQRcXmL7gsfrcAxWuyu63uUyinRrLZfYV7PfZqMUCvoQHP96SrpaQh7DX6Y 689cgJYV3O8KdJ5ra8kFou3FQls1ZED5UuD/CHESluuyuqaXaaWUvE7KAgECA+daqT 8U1rjrGtihBV5blj0amkTeWWYLWpadRA9cXACBXDviE83mnYOtTn+sh5gT6MjM4cVV zVMM8l9DXT3EA== Message-ID: Subject: Re: [PATCH v6 5/9] Documentation: add a new file documenting multigrain timestamps From: Jeff Layton To: Jan Kara Cc: Alexander Viro , Christian Brauner , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , Uros Bizjak , Kent Overstreet , Arnd Bergmann , Randy Dunlap , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Date: Wed, 17 Jul 2024 08:02:23 -0400 In-Reply-To: <20240717113132.dvzsczxjr67224bx@quack3> References: <20240715-mgtime-v6-0-48e5d34bd2ba@kernel.org> <20240715-mgtime-v6-5-48e5d34bd2ba@kernel.org> <20240717113132.dvzsczxjr67224bx@quack3> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3 (3.52.3-1.fc40app2) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DF13240008 X-Stat-Signature: her9cysc33x8x7hmbc9j7bs8ane8dbsh X-HE-Tag: 1721217753-258857 X-HE-Meta: U2FsdGVkX19TVr0gxTKWCOk3VDMRvCohXKBXIsFV6Z2p+hwTMbuzUqwAwBa5Bvseiu4ypTw8OxwI4NNVk+Kx4JhPwD2RxNu43msmYiUSImhEDErDFxtOpwNWcBzE6dBwY8zyj+H0YY9pGHrpmSZ+UOy7fxhOAs7VU5rURATsfeCaUczM69yBB461ZOIf2WDz+3HBJixOm9XKx7n82lz41wrEfY6GoPQ2MfkvXdWOUtvPyiMWFgR2Hxj4L7EMCHWfCRrvCIZ9B575tNjneRo7Vm2G8x4PXzi+HZrecZvRjBPwJ3CrdroxPCQdmOo7FbnjUpFydxqJ9AWhoBpbJAE/v1z9WurKQoSyloLJzwe2w59UAqJlJzvjKLnIgNyTDcda5P0MRLm1VPK/kZvICW1MuGoMSgHel0aXPvATzZ8uyczOR5WsKCRJ9QerQDFaUDI+5OTzFhN9F3c8DWVbYfLrcVrX9xEYhYMCVxQm5T5lT1JsoIQZK+alwCIR+jdbG1JInqwQ9xYgBSG3xHT/28mM8xlMJwXWCBLPsSj1+6E5dbe5ivW273e0jzvlGcy9lVkJzpbF61oNnBGobYYxSvbF2P/cA8EhtXJMeRIbZLTIWhPQ8GzuE1m8DDzkFTXQBthsJpBZYeU0GUCef+sDoYNaIphWTn6WABx3+ma/EE/7ya7u+nTXTyQeUS/8bUhgeMqIozaxtnqm20L/ZQdwV+cLO1LOiFJqh/Nc85KiVn73vZV+2xMSW/Sl24gJY3KT5Sw1vbFPYp8FfVRU+oBAXkWKhQG4ARNtsgL9TGF1OcJrMDxRp1iLf+/tF3YZOnf4DtTZRB4bcCwuCi1fm5ZxDAF9kd4FglSeQqbAP4Vus0bmhTOnN2lMnlJNLmbbeN/O0839JiHdMpms+pyE9LpYw+U8jb66jxnmCpYWxWu135hm/m2LmgElcf+6WTOYyJ40dqM4Jxn/aI9ORF5uF6FxXTg NHfXfdWN 7mZVZNPO5tyO5cQ8twK5LvQtKGrWn/DWUF0Q+qBgTZ3MkRRMmmo4VUHZWB9wwBBI/1dbMc+WVRbxwGl/pS3frgc7C2zOezfRCsQKirVK5sJY2hbQqFo5zCKqvNq0a14mVObM+pbnxU6g9zrb7/JhZA4+x0dTDtU0pFh+hwH5eAPgJ+0I6aKQh2jAdaSJa+bsMzOw8OiTNeE1F0iE5AN42cyMCJgHHbZmYnlFk8qoYagOPdhPHun/URTMGlI4zGyXX025hibqi8G/p5ahnmqSNiZ6lGD0TACdZuFAJH6fpA4mX0MAAvV6AKN1yKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2024-07-17 at 13:31 +0200, Jan Kara wrote: > On Mon 15-07-24 08:48:56, Jeff Layton wrote: > > Add a high-level document that describes how multigrain timestamps work= , > > rationale for them, and some info about implementation and tradeoffs. > >=20 > > Reviewed-by: Josef Bacik > > Signed-off-by: Jeff Layton >=20 > One comment below. With that fixed feel free to add: >=20 > Reviewed-by: Jan Kara >=20 > > +Implementation Notes > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > +Multigrain timestamps are intended for use by local filesystems that g= et > > +ctime values from the local clock. This is in contrast to network file= systems > > +and the like that just mirror timestamp values from a server. > > + > > +For most filesystems, it's sufficient to just set the FS_MGTIME flag i= n the > > +fstype->fs_flags in order to opt-in, providing the ctime is only ever = set via > > +inode_set_ctime_current(). If the filesystem has a ->getattr routine t= hat > > +doesn't call generic_fillattr, then you should have it call fill_mg_cm= time to > > +fill those values. >=20 > I think you should explicitely mention that ->setattr() implementation > needs to use setattr_copy() or otherwise mimic its behavior... >=20 > Honza I've added a sentence like you suggest to the patch in my tree. Thanks for all the reviews! --=20 Jeff Layton