From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54584C3DA59 for ; Fri, 19 Jul 2024 15:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4AF6B0083; Fri, 19 Jul 2024 11:47:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A741B6B0088; Fri, 19 Jul 2024 11:47:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ED216B008C; Fri, 19 Jul 2024 11:47:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 714F76B0083 for ; Fri, 19 Jul 2024 11:47:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DECEA1C1634 for ; Fri, 19 Jul 2024 15:47:07 +0000 (UTC) X-FDA: 82356930894.08.89474EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 99532180028 for ; Fri, 19 Jul 2024 15:47:05 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HB9Ab4yp; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721403992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qdg+XFgn2gowb/OLr2+FtH9LRvXkqxb4OmH6/xkelt8=; b=ZjiwBBhBTCRVDtr+SCEV5kCMHBuVED+Xy+YZNVAVH4eSTKo7ZtlA+5V1n+LxyGhAyRKPlL 8z/YcTPLxeEb+4fWe/+SzPatX/5RaIITg1Zo2n+DGfMO8WnhYkjijqlHmfJ6rrJaK2MUaH hecNiY8FomINzgrB2zXpZHebXcBvTRQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HB9Ab4yp; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721403992; a=rsa-sha256; cv=none; b=RJz4ee9w6ROUmXLHwWOQZrMRy2JolOg9ApT1oRYQjdthR7tJ90G0PsXiHBz3ngLYf09LY6 QhhauZ/1+dcrupjKwKaFTVfT2/jHE704zMLVdRXq9OjrHdgTpKCesngoov6q1aZ8JLFoBB SJe5uxqEZ/bjLeSmGupbK08jxr/MwtE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721404024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qdg+XFgn2gowb/OLr2+FtH9LRvXkqxb4OmH6/xkelt8=; b=HB9Ab4ypQpqeRaAjAXWa+pPLApvGgn81TGx/J2PPJhhFsOrO4FaiuLvMgo4vqt9+lbAaB7 2t5IpscPPBRSxWXwfvFHl2YtP1ArPBSKWho6rBIoBbYJEHI+tLKmP5Fyk9IKYTAmvr0N1C ztKaMXdJpg1eyIVSXSr5wd6FywAbeBc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-oPCd9mHJM6aWVESnKCReRQ-1; Fri, 19 Jul 2024 11:47:02 -0400 X-MC-Unique: oPCd9mHJM6aWVESnKCReRQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4279418eb2bso12517625e9.1 for ; Fri, 19 Jul 2024 08:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721404022; x=1722008822; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qdg+XFgn2gowb/OLr2+FtH9LRvXkqxb4OmH6/xkelt8=; b=G+3VigIM0EpD0nKivlIeQ9VzwbGdG4v3/wMdyUBuwn5rHlM2idTOJVvHfShFvguwfs t0yCMbCSIgxeGRs+tX30uKDCDKVvSvJm85KKPP5h2DP2yYiZ1Zhhg9PD0ukv98COkOc7 bDKDX5TTUCAIF+KblqwH7oE6DKZ7B+D84n4iVynp0BB9tHQk8H36BH0vhN1PPy8rd9rk dl1GjNuUaQYQIs3+f3UES6lgYefCh3Eq7yffebd7UhwGGg4dXLv+0EE7MhWKkXDmbA1P clpTQ6tRxWlBuOqAjE3GyH3lev0YlBUW+6dEAys2jN2nrxa3+f1Kksi7lEd3bTB2XLD/ XBNw== X-Forwarded-Encrypted: i=1; AJvYcCVHPpwfG1tt7qp5hMMWnYdmn3nLPrt/OOMe0Hrhidn16THaKvv63DRYy71YQUlp/r8HNhXaoDueWn4Rga6ivNxhH2k= X-Gm-Message-State: AOJu0YxB9g1xxIr81K82lJvcwD38ES4CEwG3qDzr79Z7MbU7xyi5inlb hYxNi5oLpqNv/wjwchY1+H8KHfusOrwaLu0r6q3yhqpqgSbEr6d2Ty+ElAgF801EUXzLWxOrflA 2ezyfnf8Fg0TJWKvWlv3OwSewCpLaBwZuXbT5X24AdBFhfd9y X-Received: by 2002:a05:600c:4f42:b0:425:649b:60e8 with SMTP id 5b1f17b1804b1-427c2ce4ec2mr59181265e9.18.1721404021853; Fri, 19 Jul 2024 08:47:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkk+7fVut5qcTcGBeestcx2OOs9WsAxgbfDNI+xjLXD9oXIYfigE2OZ+7D6CPvbkI1WcMoBQ== X-Received: by 2002:a05:600c:4f42:b0:425:649b:60e8 with SMTP id 5b1f17b1804b1-427c2ce4ec2mr59180725e9.18.1721404021321; Fri, 19 Jul 2024 08:47:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d692998csm28786805e9.32.2024.07.19.08.46.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 08:47:00 -0700 (PDT) Message-ID: Date: Fri, 19 Jul 2024 17:46:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Jonathan Cameron , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> <96850252-a49f-4d78-a94b-a9a25e3f2bd5@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: es7akecxkc4h9im391juw71yw9twtcha X-Rspam-User: X-Rspamd-Queue-Id: 99532180028 X-Rspamd-Server: rspam02 X-HE-Tag: 1721404025-316565 X-HE-Meta: U2FsdGVkX1/zmXZ6jchQwuHwy3KEmI5//3R0XlluVwz1MstXvjpWEGcMZ9LFW+oEOj0sg6Mp9i0obrymzyoY3qdI0O8J41CTwOBdNS6YT1cJIsYRsJ0pQlCp5nAEqGeAxtG4sYR+OPieJBNpiVncpWFtIs/kDkKQfz//RtQy22w91EceusRooWToQnhh39lIbZMTUBTubsEnKDwI/z/8MfckmqTM9vuPEFijHq+nMHsXMiMP/YbULGqi4Akz5ta6LOxj3Ld9xCLcaF5OQ+lMhnZoJTm+5GwGQhaabvYDK4BStFXp1aF2Wfibt7rRx5GMkuwAZMEHNlXtYTlZMUeANGXQXHONgFk41grXZsJse48qsN9noEF4khjvcao4tVJPtNYCs97cYZE0PlGmwieDbxaIdsGt9OH1to+Vqot8kgI4LX4QvFfm+JCvvUEn62qOQqVNGKOrW8NigswCghScnbIiF2K0w8r98a7CurPTQdQEc4udeZ0tw6q3Lprv1qSaRvMduA33fDhS3y6kzF8b3/y0Lvsy4u0QganL09RHpL48FVbIghMYyLfP8CUH5kht17EBTpc58Z8pjzdD4qXbtCMBW2FXhy7GmGiLYHzX+k7DhegyHHRyljF+8qp+thXiKgngwpsKzHjVuWYX5KD5aWwmDTTM/Q0Jf2zX39vZTfsfR01cOF7Oaaqk+XzVwLerN2sBwnPqE/0J98E1FRx2aooLCJ+D2LUTvlnkQt3nJwDxJS46dSXjhs2yLxChbzMywLEw/fTcAZfEpCTFOOksTevIdOZZaucKPEepWbd8/t+HPQh3YdGBCRY9ZjZWos0Hu5oUzywfcRRW1PYrrOCNtpb6nOB/H2l59imKltFnwFboGpmP+H7Lh2TJaEWF9p/XHlOREZvLnYSXq4duAO3gBr/Yl3BmSiUGAWy4eS+ULXItxY10vdY5vOakFVn9QTlR0CLx5pIgrdJgbVZjGpl kfVGhoZU k+/JdUNzkC0Bz+pt42X0+M0e/4CvrNtdjxJpTKgkpDwwF5hNL94vEH+aXHFmHrgSlHQM395IHtbtEfFl4BBEcGpsP0P6Y8aIzwe/AxBX+VqzMBxRVjKNi75Qgy2JHNnzbtY9Hyh5Z4ZXluiL0JbeGJMA+rtsTvdSOQ1RDXAOVt+SRgbNOTYsxykw6Gamo9kYoKWh1JqXXEOPuyuviRQJRxy67a2JicBdVI+Da6vyJoFHuOXFR3E08GRGV6p1kr4OH9KiInoRfeDhicBjZgrPCKmPVkRzNVWxUQWxsqKhuydZs9njxgDFo1Y6ggmPN16BSlsjD5PimAFaJfGz4eMUAA8WU0mORytexOvF9YTeZPmRMtO9l8nUAEeFdAVVtD1VeZnistKH/RS5n9mYUAQsU9YrHfS5ZFGZJdpQ4KBMRAAjbYf3KKrWfi1ib+Dr0J5qXSVU/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.07.24 17:34, Mike Rapoport wrote: > On Fri, Jul 19, 2024 at 05:07:35PM +0200, David Hildenbrand wrote: >>>>> - * Allocate node data. Try node-local memory and then any node. >>>>> - * Never allocate in DMA zone. >>>>> - */ >>>>> - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); >>>>> - if (!nd_pa) { >>>>> - pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", >>>>> - nd_size, nid); >>>>> - return; >>>>> - } >>>>> - nd = __va(nd_pa); >>>>> - >>>>> - /* report and initialize */ >>>>> - printk(KERN_INFO "NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, >>>>> - nd_pa, nd_pa + nd_size - 1); >>>>> - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); >>>>> - if (tnid != nid) >>>>> - printk(KERN_INFO " NODE_DATA(%d) on node %d\n", nid, tnid); >>>>> - >>>>> - node_data[nid] = nd; >>>>> - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); >>>>> - >>>>> - node_set_online(nid); >>>>> -} >>>>> - >>>>> /** >>>>> * numa_cleanup_meminfo - Cleanup a numa_meminfo >>>>> * @mi: numa_meminfo to clean up >>>>> @@ -571,6 +538,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) >>>>> continue; >>>>> alloc_node_data(nid); >>>>> + node_set_online(nid); >>>>> } >>>> >>>> I can spot that we only remove a single node_set_online() call from x86. >>>> >>>> What about all the other architectures? Will there be any change in behavior >>>> for them? Or do we simply set the nodes online later once more? >>> >>> On x86 node_set_online() was a part of alloc_node_data() and I moved it >>> outside so it's called right after alloc_node_data(). On other >>> architectures the allocation didn't include that call, so there should be >>> no difference there. >> >> But won't their arch code try setting the nodes online at a later stage? >> >> And I think, some architectures only set nodes online conditionally >> (see most other node_set_online() calls). >> >> Sorry if I'm confused here, but with now unconditional node_set_online(), won't >> we change the behavior of other architectures? > > The generic alloc_node_data() does not set the node online: > > +/* Allocate NODE_DATA for a node on the local memory */ > +void __init alloc_node_data(int nid) > +{ > + const size_t nd_size = roundup(sizeof(pg_data_t), PAGE_SIZE); > + u64 nd_pa; > + void *nd; > + int tnid; > + > + /* Allocate node data. Try node-local memory and then any node. */ > + nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); > + if (!nd_pa) > + panic("Cannot allocate %zu bytes for node %d data\n", > + nd_size, nid); > + nd = __va(nd_pa); > + > + /* report and initialize */ > + pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, > + nd_pa, nd_pa + nd_size - 1); > + tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); > + if (tnid != nid) > + pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); > + > + node_data[nid] = nd; > + memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > +} > > I might have missed some architecture except x86 that calls > node_set_online() in its alloc_node_data(), but the intention was to leave > that call outside the alloc and explicitly add it after the call to > alloc_node_data() if needed like in x86. I'm stupid, I didn't realize it is still only called from x86 :( Acked-by: David Hildenbrand -- Cheers, David / dhildenb