From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Sunny Patel <nueralspacetech@gmail.com>
Cc: akpm@linux-foundation.org, apopple@nvidia.com, byungchul@sk.com,
gourry@gourry.net, joshua.hahnjy@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
matthew.brost@intel.com, rakie.kim@sk.com, sj@kernel.org,
ying.huang@linux.alibaba.com, ziy@nvidia.com
Subject: Re: [PATCH] mm/migrate_device: Cleanup up PMD Checks and warnings
Date: Sun, 19 Apr 2026 10:12:25 +0200 [thread overview]
Message-ID: <c4355c68-4c23-404e-9368-7120f6467ad4@kernel.org> (raw)
In-Reply-To: <20260418171806.11615-1-nueralspacetech@gmail.com>
On 4/18/26 19:18, Sunny Patel wrote:
> On 4/17/26 01:52, SeongJae Park wrote:
>> On Thu, 16 Apr 2026 21:44:15 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:
>>
>> [...]
>>>
>>> is_huge_zero_pmd() checks pmd_present(), so we didn't have a bug before.
>>>
>>> We could also do:
>>>
>>> if (is_huge_zero_pmd(*pmdp)) {
>>> flush = true;
>>> } else if (!pmd_none(*pmdp)) {
>>> goto unlock_abort;
>>> }
>>
>> Then we could even further remove the braces and reduce one more line, nice!
>
> is_huge_zero_pmd() didn't check for pmd_present as of now as per the current implementation of it so additional check require for pmd_present().
I don't know what you mean. Here is the code in the tree:
static inline bool is_huge_zero_pmd(pmd_t pmd)
{
return pmd_present(pmd) && is_huge_zero_pfn(pmd_pfn(pmd));
}
--
Cheers,
David
next prev parent reply other threads:[~2026-04-19 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 14:13 [PATCH] mm/migrate_device: Cleanup up PMD Checks and warnings Sunny Patel
2026-04-16 19:44 ` David Hildenbrand (Arm)
2026-04-16 23:52 ` SeongJae Park
2026-04-17 8:55 ` David Hildenbrand (Arm)
2026-04-18 17:18 ` Sunny Patel
2026-04-19 8:12 ` David Hildenbrand (Arm) [this message]
2026-04-19 17:53 ` Sunny Patel
2026-04-17 7:21 ` Huang, Ying
2026-04-16 20:30 ` Zi Yan
2026-04-16 23:50 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4355c68-4c23-404e-9368-7120f6467ad4@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=nueralspacetech@gmail.com \
--cc=rakie.kim@sk.com \
--cc=sj@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox