From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BCDC5B543 for ; Wed, 4 Jun 2025 10:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660128D000E; Wed, 4 Jun 2025 06:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637EF8D0007; Wed, 4 Jun 2025 06:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54DD58D000E; Wed, 4 Jun 2025 06:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 30BD68D0007 for ; Wed, 4 Jun 2025 06:05:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1EC0C0E54 for ; Wed, 4 Jun 2025 10:05:42 +0000 (UTC) X-FDA: 83517286524.11.5A1FEE3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 6B828C0012 for ; Wed, 4 Jun 2025 10:05:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ilNFpA6w; spf=pass (imf22.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749031540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VMLhcnC9+JU6hatTCJVRZoN8Wtj4l/l+ETn1f3lqm+I=; b=UPbk5H0BMjLKBKs7nsirYrbsD552COwt57sz3uhzIIr30mg1CPgj9ez7/6E/lFbS/ywi8t ZBVvkSQ0jbhz8yMAam0TnjQxGsxtjOp9+FvrsAOjgq5vXtoKf74478RDBPj5CODCtZjcN3 sTiHQmhJSWG5+nZtz4TZTUk0T2dl2gw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ilNFpA6w; spf=pass (imf22.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749031540; a=rsa-sha256; cv=none; b=T0l0V7BAoTMMB4ZPHhuLBBxF3O/9s7qzG44bi4B8AbLsAJpuzc2tXUAJQ3tUijN09VABSl YJaLpXZFj72Zaek6QHko4Jw1OA/AltAwq3lLYJkVZfcLCi6kXNfrM8gwnNRKjZyjgV0i8R gCjfLdMATPoNJRK4jTbIO/c1T0hYbsk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749031539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VMLhcnC9+JU6hatTCJVRZoN8Wtj4l/l+ETn1f3lqm+I=; b=ilNFpA6wc3AkxzbMA+zU3ctHzULiIHOzS4SEN0c2CcbiINKenY8ucGCSugaTWNxyuP3113 8J7b0WWzlUvb8kH8D4zfAEwsINXROec5opq5PfJl7Ea60pJxSH/NdJrzwsDd8Us2Lzqwdx 81+0AxE8B33eotId6hwCy3ZX0VBxXSc= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-IvIZV6R8PmKeFTQKCvUCzg-1; Wed, 04 Jun 2025 06:05:38 -0400 X-MC-Unique: IvIZV6R8PmKeFTQKCvUCzg-1 X-Mimecast-MFC-AGG-ID: IvIZV6R8PmKeFTQKCvUCzg_1749031538 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-73bfc657aefso4846326b3a.1 for ; Wed, 04 Jun 2025 03:05:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749031538; x=1749636338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VMLhcnC9+JU6hatTCJVRZoN8Wtj4l/l+ETn1f3lqm+I=; b=mMFV+Hwa2iV4ht64POPtgOeSpirdc3f53QewjjQ+/CS5Ojoa7Eex+0qQQiyt/H/AyF BH1wV7pn03RQ1OSm7VS2heWjlaK66/Sn2FXtQAowhWFz+C+HyjixU0TS6Dnnsg0TWRDL /hNDxHNLbcscVTOCJknW1ShXvp0DoFFp3SeJpUFJWzPIDPHuoMsTOydxhnr4rTPrb6h2 /t//sTyumwi7LU5QBWJJ/zCwYVQrslAReOIJWMbRhxSeX2m2jnn3MPF6tW5BH5QmJ5/Y Tp9IhzEOc0sFUwS9YcxYo73yFn9r/RWkGjDlEt7DvPeC+y7+L3NhbWLjEXvW/3eXeh6+ rLEQ== X-Forwarded-Encrypted: i=1; AJvYcCUcSWadgFQILxvw56GqWTfQVIb5cAz8niwk5FLTfa7xQC8RIFN652LmXp9G/jo8sCgKhDhXS0pFiw==@kvack.org X-Gm-Message-State: AOJu0YyJCJNd55rXOSWLSMlzegJjjGz+7Lw8O+CgM5ViGaRie78HYP8K F7fBZxsiLjKMG9XQtk6tZ9TUYGkEv/W2k7jOycPAzsRUgmzsEcgj0ROQkJUUaft7/ACA166shFZ wZN1WnwDQrtlWStAWqlgDnhPi9zjxSoPAXbxM3jZWMpXk+5ZSwxDQ X-Gm-Gg: ASbGncufEHwnt8tTC2ZFn1WqXjRRHii1mtQJ3Y2xlEboQISevyOZuJypkn2FLQlgCWB nKF4XePAcJ6a+5wkMYO1mUYY4/Wt8rtvdnS5zKuA/9Lj7aeEwvvZr0pisBq0Y8cxvvz4477DNJv YosqLbgikAWOrO+NoBFyVTqiuWa0KyGBFJubWjVzCumAcuirGyAgSj6bsbgNTPPtGAnDb9FQN0t zk2Xk+eF6KPoe4I2bBQkMXDz3EQSn/yw/J7QCiJRRyoIQdWIaOCUOlj9lDLloVog5mpMEYbkcbY HWrmzgHAUMqsLF9WVMibOioCESzmrzkDpWxM9g8GQZFoWn9AceA= X-Received: by 2002:a05:6a00:99c:b0:73e:23be:11fc with SMTP id d2e1a72fcca58-7480b48a226mr3509416b3a.22.1749031537473; Wed, 04 Jun 2025 03:05:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZgFIeDTmpajCrDTaiqLjqZLgt6AKssR/SSnosipe7f4k0EhNhKGhtxyA9HSXTQicG/JvBEg== X-Received: by 2002:a05:6a00:99c:b0:73e:23be:11fc with SMTP id d2e1a72fcca58-7480b48a226mr3509343b3a.22.1749031536953; Wed, 04 Jun 2025 03:05:36 -0700 (PDT) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747affd55adsm10761776b3a.156.2025.06.04.03.05.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 03:05:36 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 20:05:15 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 16/16] KVM: selftests: guest_memfd mmap() test when mapping is allowed To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-17-tabba@google.com> <025ae4ea-822b-44a1-8f78-38afc0e4b07e@redhat.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6zEYoK2PzZNEnUlkjcgLnmIKfCcNg9ChGYhdOHg9vMc_1749031538 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8eambz96fa5qjzmft1ebnxbwgk3sx7pr X-Rspamd-Queue-Id: 6B828C0012 X-Rspamd-Server: rspam11 X-HE-Tag: 1749031540-669544 X-HE-Meta: U2FsdGVkX1/9NWK2rhdpX4EKO0p4URRnjWStiYLbb6bPLAuwdfDrlUieLl6em12pp5PcVlGPjM8qDOMngjnOV+0Eea7h8AGAis1sf5Iw693oor8XlC59akB0vVWatMCAVODNx7agnJ5L1UcLwykIRFd5WHuoL+yHN8IxgZzvYkIXh8fq0PlEn6d3pRRAdEJVgANAfUEYQuAiwXZ+PAxx2tWM0zMk6m5Q9ewDMvhZoy2QcfQdlRyX7KalddotxE3GhwfnorXc2Him4k52CIxekeIMPQiDbY+u48YGe2WdM+IDcdhzCwEfXd7GGVy/WUqhguhGhfjn1+O4pkQGjvgzwYKtvytweQcJRhRILV7i+EJdrTIyTO3qif1q77RstEU5ETPyxWask8i/hWkN2M1fqB7abhp2XwU01/sULrJ9za9dgvq2pq/U+MiUJLBeNaPe+DC82b6UCtsVg2cWqKogePCJVSMmEH/tt5XjxS8Bv8HMjLpvqKp+4mKbnv7nhAAd0/+RTEZKvJePVIffKBhX5iVnRWB6iajKmXS8BJqt8gh9j7ts9dJcqyBQlQFir6CQDOthlR0H6H7M5W14kH7gZ+QKrKqoC0lW5xUIV/JaU9UGNWgqBdEVdEB9uTWyUhaBbrbhLKWwrGZwKJa2La5NwlCNfxle09zJCunHhM+QqNaERks3yrGeDIewTTrhEXSqfsbWwpmcQzTmwlSaQWcl3Vx1bm89Xur+KHbJNSNM+vI/Kn/o0y3rX8cTFn8cU+oMLNQ1T4TRoMVNf13I1S6JSnC5ZDK1CInYDGrfKkj82r+U2SyT2Qsbt/GYDYk82pJGUQG80EH8Xs55fR3O2cihBVAcFikvOHzZ6w2iYbPFWp939vWuvxMaJ359wFWQX0fB9auEXZnLw2OuySw6qlMV4cfar4fWv3pTnFKdnS/+DdhNbKfJ0bBK1cfkhPKNgsP5h7l9ZGiWNCAmsRRA53k TI9KT6f5 GpYM7QtXZjxtxYgcMhFmwNKQmTnb28AuT6BH1RVO//G9CxqX4NPrZo19aioMNCEhBLGEnrKQImwLrMr9l/R7mlf1z6T1pbJayGJcF67olC+TXo4aWi9v2f0WXNjumk23Md/IEzfe12T3ynJBxa7AaNRBGUaahvfmVjYOVHywvJIrsccN7k7zjBV+sy8TE4l7zBng/+y8Xw3S9yU3XqCbNZYNVVKoK7M4L9jztBnSROqU3dVTALCEMaetnTFIQhmnJWHnExs20z4tB8zBumhWA4+09fFSy9pT/sRmDKHIxd6BJkbybMbGt3Ia8nXSKoD+XM6brYSz09ZfTuoqThQv/TG+Bd6HVNHwy068IEiozKO9QTnQIXLOFLVwl3OWmCK9zhyH0tVP3xi9rs+ZpbRZpwyhjT5BafmJfbxk6ZZkG2vNY4GRxivrG3LPL0XhHCi17zRdk6wAXqw/zEip0Uv2E08uuTHcSFFRco5wM94bzHp06d0POjRuwXmSaVcMRZl4XAcL7faLNtHr1eT2oKVoWV0osLRAxWmRcm9maca/ttDm7jyo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fuad, On 6/4/25 7:48 PM, Fuad Tabba wrote: > On Wed, 4 Jun 2025 at 10:20, Gavin Shan wrote: >> >> On 5/28/25 4:02 AM, Fuad Tabba wrote: >>> Expand the guest_memfd selftests to include testing mapping guest >>> memory for VM types that support it. >>> >>> Also, build the guest_memfd selftest for arm64. >>> >>> Co-developed-by: Ackerley Tng >>> Signed-off-by: Ackerley Tng >>> Signed-off-by: Fuad Tabba >>> --- >>> tools/testing/selftests/kvm/Makefile.kvm | 1 + >>> .../testing/selftests/kvm/guest_memfd_test.c | 162 +++++++++++++++--- >>> 2 files changed, 142 insertions(+), 21 deletions(-) >>> >> >> The test case fails on 64KB host, and the file size in test_create_guest_memfd_multiple() >> would be page_size and (2 * page_size). The fixed size 4096 and 8192 aren't aligned to 64KB. > > Yes, however, this patch didn't introduce or modify this test. I think > it's better to fix it in a separate patch independent of this series. > Yeah, it can be separate patch or a preparatory patch before PATCH[16/16] of this series because x86 hasn't 64KB page size. The currently fixed sizes (4096 and 8192) are aligned to page size on x86. and 'guest-memfd-test' is enabled on arm64 by this series. >> # ./guest_memfd_test >> Random seed: 0x6b8b4567 >> ==== Test Assertion Failure ==== >> guest_memfd_test.c:178: fd1 != -1 >> pid=7565 tid=7565 errno=22 - Invalid argument >> 1 0x000000000040252f: test_create_guest_memfd_multiple at guest_memfd_test.c:178 >> 2 (inlined by) test_with_type at guest_memfd_test.c:231 >> 3 0x00000000004020c7: main at guest_memfd_test.c:306 >> 4 0x0000ffff8cec733f: ?? ??:0 >> 5 0x0000ffff8cec7417: ?? ??:0 >> 6 0x00000000004021ef: _start at ??:? >> memfd creation should succeed >> >>> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm >>> index f62b0a5aba35..ccf95ed037c3 100644 >>> --- a/tools/testing/selftests/kvm/Makefile.kvm >>> +++ b/tools/testing/selftests/kvm/Makefile.kvm >>> @@ -163,6 +163,7 @@ TEST_GEN_PROGS_arm64 += access_tracking_perf_test >>> TEST_GEN_PROGS_arm64 += arch_timer >>> TEST_GEN_PROGS_arm64 += coalesced_io_test >>> TEST_GEN_PROGS_arm64 += dirty_log_perf_test >>> +TEST_GEN_PROGS_arm64 += guest_memfd_test >>> TEST_GEN_PROGS_arm64 += get-reg-list >>> TEST_GEN_PROGS_arm64 += memslot_modification_stress_test >>> TEST_GEN_PROGS_arm64 += memslot_perf_test >>> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c >>> index ce687f8d248f..3d6765bc1f28 100644 >>> --- a/tools/testing/selftests/kvm/guest_memfd_test.c >>> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c >>> @@ -34,12 +34,46 @@ static void test_file_read_write(int fd) >>> "pwrite on a guest_mem fd should fail"); >>> } >>> >>> -static void test_mmap(int fd, size_t page_size) >>> +static void test_mmap_allowed(int fd, size_t page_size, size_t total_size) >>> +{ >>> + const char val = 0xaa; >>> + char *mem; >>> + size_t i; >>> + int ret; >>> + >>> + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); >>> + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); >>> + >> >> If you agree, I think it would be nice to ensure guest-memfd doesn't support >> copy-on-write, more details are provided below. > > Good idea. I think we can do this without adding much more code. I'll > add a check in test_mmap_allowed(), since the idea is, even if mmap() > is supported, we still can't COW. I'll rename the functions to make > this a bit clearer (i.e., supported instead of allowed). > > Thank you for this and thank you for the reviews! > Sounds good to me :) > >>> + memset(mem, val, total_size); >>> + for (i = 0; i < total_size; i++) >>> + TEST_ASSERT_EQ(mem[i], val); >>> + >>> + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, >>> + page_size); >>> + TEST_ASSERT(!ret, "fallocate the first page should succeed"); >>> + >>> + for (i = 0; i < page_size; i++) >>> + TEST_ASSERT_EQ(mem[i], 0x00); >>> + for (; i < total_size; i++) >>> + TEST_ASSERT_EQ(mem[i], val); >>> + >>> + memset(mem, val, page_size); >>> + for (i = 0; i < total_size; i++) >>> + TEST_ASSERT_EQ(mem[i], val); >>> + >>> + ret = munmap(mem, total_size); >>> + TEST_ASSERT(!ret, "munmap should succeed"); >>> +} >>> + >>> +static void test_mmap_denied(int fd, size_t page_size, size_t total_size) >>> { >>> char *mem; >>> >>> mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); >>> TEST_ASSERT_EQ(mem, MAP_FAILED); >>> + >>> + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); >>> + TEST_ASSERT_EQ(mem, MAP_FAILED); >>> } >> >> Add one more argument to test_mmap_denied as the flags passed to mmap(). >> >> static void test_mmap_denied(int fd, size_t page_size, size_t total_size, int mmap_flags) >> { >> mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, mmap_flags, fd, 0); >> } >> >>> >>> static void test_file_size(int fd, size_t page_size, size_t total_size) >>> @@ -120,26 +154,19 @@ static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) >>> } >>> } >>> >>> -static void test_create_guest_memfd_invalid(struct kvm_vm *vm) >>> +static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, >>> + uint64_t guest_memfd_flags, >>> + size_t page_size) >>> { >>> - size_t page_size = getpagesize(); >>> - uint64_t flag; >>> size_t size; >>> int fd; >>> >>> for (size = 1; size < page_size; size++) { >>> - fd = __vm_create_guest_memfd(vm, size, 0); >>> - TEST_ASSERT(fd == -1 && errno == EINVAL, >>> + fd = __vm_create_guest_memfd(vm, size, guest_memfd_flags); >>> + TEST_ASSERT(fd < 0 && errno == EINVAL, >>> "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", >>> size); >>> } >>> - >>> - for (flag = BIT(0); flag; flag <<= 1) { >>> - fd = __vm_create_guest_memfd(vm, page_size, flag); >>> - TEST_ASSERT(fd == -1 && errno == EINVAL, >>> - "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>> - flag); >>> - } >>> } >>> >>> static void test_create_guest_memfd_multiple(struct kvm_vm *vm) >>> @@ -170,30 +197,123 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) >>> close(fd1); >>> } >>> >>> -int main(int argc, char *argv[]) >>> +#define GUEST_MEMFD_TEST_SLOT 10 >>> +#define GUEST_MEMFD_TEST_GPA 0x100000000 >>> + >>> +static bool check_vm_type(unsigned long vm_type) >>> { >>> - size_t page_size; >>> + /* >>> + * Not all architectures support KVM_CAP_VM_TYPES. However, those that >>> + * support guest_memfd have that support for the default VM type. >>> + */ >>> + if (vm_type == VM_TYPE_DEFAULT) >>> + return true; >>> + >>> + return kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type); >>> +} >>> + >>> +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, >>> + bool expect_mmap_allowed) >>> +{ >>> + struct kvm_vm *vm; >>> size_t total_size; >>> + size_t page_size; >>> int fd; >>> - struct kvm_vm *vm; >>> >>> - TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); >>> + if (!check_vm_type(vm_type)) >>> + return; >>> >>> page_size = getpagesize(); >>> total_size = page_size * 4; >>> >>> - vm = vm_create_barebones(); >>> + vm = vm_create_barebones_type(vm_type); >>> >>> - test_create_guest_memfd_invalid(vm); >>> test_create_guest_memfd_multiple(vm); >>> + test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); >>> >>> - fd = vm_create_guest_memfd(vm, total_size, 0); >>> + fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); >>> >>> test_file_read_write(fd); >>> - test_mmap(fd, page_size); >>> + >>> + if (expect_mmap_allowed) >>> + test_mmap_allowed(fd, page_size, total_size); >>> + else >>> + test_mmap_denied(fd, page_size, total_size); >>> + >> >> if (expect_mmap_allowed) { >> test_mmap_denied(fd, page_size, total_size, MAP_PRIVATE); >> test_mmap_allowed(fd, page_size, total_size); >> } else { >> test_mmap_denied(fd, page_size, total_size, MAP_SHARED); >> } >> >>> test_file_size(fd, page_size, total_size); >>> test_fallocate(fd, page_size, total_size); >>> test_invalid_punch_hole(fd, page_size, total_size); >>> >>> close(fd); >>> + kvm_vm_release(vm); >>> +} >>> + >>> +static void test_vm_type_gmem_flag_validity(unsigned long vm_type, >>> + uint64_t expected_valid_flags) >>> +{ >>> + size_t page_size = getpagesize(); >>> + struct kvm_vm *vm; >>> + uint64_t flag = 0; >>> + int fd; >>> + >>> + if (!check_vm_type(vm_type)) >>> + return; >>> + >>> + vm = vm_create_barebones_type(vm_type); >>> + >>> + for (flag = BIT(0); flag; flag <<= 1) { >>> + fd = __vm_create_guest_memfd(vm, page_size, flag); >>> + >>> + if (flag & expected_valid_flags) { >>> + TEST_ASSERT(fd >= 0, >>> + "guest_memfd() with flag '0x%lx' should be valid", >>> + flag); >>> + close(fd); >>> + } else { >>> + TEST_ASSERT(fd < 0 && errno == EINVAL, >>> + "guest_memfd() with flag '0x%lx' should fail with EINVAL", >>> + flag); >>> + } >>> + } >>> + >>> + kvm_vm_release(vm); >>> +} >>> + >>> +static void test_gmem_flag_validity(void) >>> +{ >>> + uint64_t non_coco_vm_valid_flags = 0; >>> + >>> + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) >>> + non_coco_vm_valid_flags = GUEST_MEMFD_FLAG_SUPPORT_SHARED; >>> + >>> + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, non_coco_vm_valid_flags); >>> + >>> +#ifdef __x86_64__ >>> + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, non_coco_vm_valid_flags); >>> + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, 0); >>> + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, 0); >>> + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, 0); >>> + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, 0); >>> +#endif >>> +} >>> + >>> +int main(int argc, char *argv[]) >>> +{ >>> + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); >>> + >>> + test_gmem_flag_validity(); >>> + >>> + test_with_type(VM_TYPE_DEFAULT, 0, false); >>> + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { >>> + test_with_type(VM_TYPE_DEFAULT, GUEST_MEMFD_FLAG_SUPPORT_SHARED, >>> + true); >>> + } >>> + >>> +#ifdef __x86_64__ >>> + test_with_type(KVM_X86_SW_PROTECTED_VM, 0, false); >>> + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { >>> + test_with_type(KVM_X86_SW_PROTECTED_VM, >>> + GUEST_MEMFD_FLAG_SUPPORT_SHARED, true); >>> + } >>> +#endif >>> } >> Thanks, Gavin