From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B8AC83030 for ; Thu, 3 Jul 2025 07:57:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00D258E0002; Thu, 3 Jul 2025 03:57:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F270B6B0136; Thu, 3 Jul 2025 03:57:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15E08E0002; Thu, 3 Jul 2025 03:57:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CECFE6B00FE for ; Thu, 3 Jul 2025 03:57:58 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72C4B14073F for ; Thu, 3 Jul 2025 07:57:58 +0000 (UTC) X-FDA: 83622199836.20.AAFC6A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 05F2BC0017 for ; Thu, 3 Jul 2025 07:57:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXJEFvOo; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751529476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N2hxjCzV37C1ZPSNIHjhxE6IGURLeOMxvrqqD9HZIsI=; b=Gd/WydzQ7oKu/HgYBAisBIy9cQ41p30DwSSwI3yfPfyqRdcFTkJWcL4UXOausK87a5VQNH 0YNBqjSxWhaMUl8CNQsgvMXC6Q7ti7d6JVtnqsWtecXf49X7Qpt+/t8/zLHiTLbJaJ/+LI 72IGZQ9tMosbEItxVnqKpAZLs60k0G0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PXJEFvOo; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751529476; a=rsa-sha256; cv=none; b=VsTKQqpsYjzbkhxl3NVHXczXhNsoojgGEuPIWe1vJkj92oWnM8tnuquQbvIFa6USnTJcBK 5+awGTUVb8j5iki27dAtWrch7xKUixEZI+CY6V0yzg5WWBtLsoaQdwqh3jG5kL4c6EgT6Z 0mxlREb6ue6y1hKgGTRKok4b8LPFekE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751529475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N2hxjCzV37C1ZPSNIHjhxE6IGURLeOMxvrqqD9HZIsI=; b=PXJEFvOoK/FAJrP70JsRyaz0i4jgepsNuo5CwzF61OThTW6jd/QTbBwFOTj6hHYnJ1HB5t SG79OvoeaEPDAK9Yjv0Sg6hz/ySkAyDVVdWoZS8KqrMx1EpuNTPnPjYSrtCDzDIi8pLnei CykPqa6VAgBMaNWI8lYYlW1mXjxhw6o= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-JmMRfEIvOpe1atcJnW785Q-1; Thu, 03 Jul 2025 03:57:53 -0400 X-MC-Unique: JmMRfEIvOpe1atcJnW785Q-1 X-Mimecast-MFC-AGG-ID: JmMRfEIvOpe1atcJnW785Q_1751529472 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ae0dffaa8aeso78102366b.0 for ; Thu, 03 Jul 2025 00:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751529472; x=1752134272; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N2hxjCzV37C1ZPSNIHjhxE6IGURLeOMxvrqqD9HZIsI=; b=fqpyvA62QUF000+S6nm5HRw5uOeYf0gczd4Z6MEKxE8JKRS9JaIM/6G4AE+HQESxyg zHWr02LH4v1pmDzp7r2/TMfwkXIpI0svi+F9WZzlP0CAvGQ+/upF17TnauFmsvL5N23w UGoCs3IeTJoDQQ4Q83b/Rj4BtxmdnVWLLQghgRkOC2WaQJnECaWf7s65Ff2GUCxg5Mp2 RyWFS8le7a9kL+DsNjsaDj7Tk7b/ViIb22a+uADLkGFvnB5bZ+C34BAv4OlbtilaM2vl 6hHbdjiUTrvL1JS5p2E249/0kRqHuN6io7ASeS3v/Ax2UdS8Lo3eP7US2PUGUBtbhvty QIuA== X-Forwarded-Encrypted: i=1; AJvYcCUZ6ESrj4J9+s4oV+Q/2ZjbJDBg9fuVDpS0yLd+nf2d0tbbAjQrD3qlZFfy+tf7QcWhCKUz9e/fyA==@kvack.org X-Gm-Message-State: AOJu0Yzj0NYuVnAbSGZmEGNLD4dUxBWAi6awKF8FfrBmE1hOwLeuVHfi JPVe42VVwnZNkesZ9/XySiNvIakU3bsnhF35s1aGNVaqko2zjnocUx3qtsrsTZAf8UJjxs9bgOn vH8e5XlzT5CG2kNsFDwK6uh6xTBBlfRM5PztdrOrUylILG5C/6R0pc91TBXFWWVs= X-Gm-Gg: ASbGncsJq9O7QHxtNvkAC/CYHbgoCcVEnsMZZDAftwDrZIu8QhMi6xpwi1LctIrH1qH J4NJBP4FVmt4WoEVFteSjXi+2mSZGdUTMjW8GpSU0G22x+P6IK9KK98Ms/5kcCuX+1NL/S/wz5J 8YL8zeeyvE4LO12xbAdUGw0C3bUL0OIlkNqFrtNkL8vRdRbWasYUK7ZTrxUW1LDIQAGH8ZHJ71x 2e18VPSQI4gKwQHJ9bcA/2EwOuUkzcxhWNHn1pD/8TIVrYTQJvG+ba7gjij8VOXKpSgIrTA/6Q9 ougpYb/YstPE1twyXLFAKgpQwYyU+58X4d0hUpnAztDX X-Received: by 2002:a17:906:6a27:b0:ad8:e448:6c64 with SMTP id a640c23a62f3a-ae3dd5f805cmr158432266b.24.1751529472098; Thu, 03 Jul 2025 00:57:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsjHybO00+lXYY+KwSlX776CpidilHAtUxgne1K2J0x5frv9CumRTdQIbfoJNsnCuHukcy7w== X-Received: by 2002:a17:906:6a27:b0:ad8:e448:6c64 with SMTP id a640c23a62f3a-ae3dd5f805cmr158428466b.24.1751529471464; Thu, 03 Jul 2025 00:57:51 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c831ca445sm10292220a12.54.2025.07.03.00.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 00:57:51 -0700 (PDT) Message-ID: Date: Thu, 3 Jul 2025 09:57:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm/memory_hotplug: fix hwpoisoned large folio handling in do_migrate_range To: Jinjiang Tu , Oscar Salvador Cc: akpm@linux-foundation.org, linmiaohe@huawei.com, mhocko@kernel.org, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250627125747.3094074-1-tujinjiang@huawei.com> <20250627125747.3094074-3-tujinjiang@huawei.com> <373d02c5-2b62-8543-b786-8fd591ad56eb@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <373d02c5-2b62-8543-b786-8fd591ad56eb@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8ERwlHefMiIvQQw4yNT8qr-bBNnw35K9o1vHhZCD-TE_1751529472 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 05F2BC0017 X-Stat-Signature: j9hijxcuz6dwbr8hkmdsj98r6xbrd9ma X-HE-Tag: 1751529475-972040 X-HE-Meta: U2FsdGVkX19QNo8a6ZMUvbwzXtv0NZHGfE117L241ByQmsiuWpywkbq2r6vZjq7sxppzM8eDs88ca7aFCwFY69nlE1zJGgOrr2CguOyey1K2GbrewC2Io05Kpu48O0YuB8kq/Ohd/qQrZ9hdw08ZXQm1DI0AN6K8FQKmAe55z947YiT4uL7DsrPhhXb0oxPSHoPU4iO8EZKYNmKg6TBl4IoY7MH/x22O0zrmP86oPwR9yEDZ00Hj0FBYj0P/xwXjCYZsYxCoSVEQA0FrInkq8Y4hOtCqIbxnaekmCBqkMKblrcFpTv8Q9A1WmCSUbJ66QYP/+Lj6iTDL4xrPuifTtHXblX6XMg2izsaXqtdCvXQ6MyJKIghlPP12Z3f5AaP8EsUX5+3JDuHdeN14d/wiWNfPWx8eLnXvZAxsnWllU5K4QpZ2nO7owm6UckvPCFrFGMK3/QlRUy2Ps4C9VquwN6CCVdd2+Ina4OTAR7fqlCFXub5kNQMRLUt8UG4Vmk6tVzHoV3R+ipW1aaEOz4WNZW8We16u6ZSTCafptKUdqwG2zaD+z9fP6LzTedI7zDvQhkvqVhAIIyEye8d/YrEH17lpy4g5FfEJrdESyE+z1j6WQXHOHsV97WIyopP3ESi+uHfmX+4TWu9m84rF+xWBedPvsgSEJ3kQ3fSPFo9nncNU+2+s+pey/afGKjFTrfOPYQqMNFkP8LVvFphGwFKTGzeQGCubPsOQ1YyD/js2WxpLW0dEiYJjbAAOrCTFWFUTAfOwJweRD/56ec4+b3vKICFrLdrUewbvZH55PwrN9cwptJxIivqtzvqmUjqjzUaE6hvmS2esGht/3SH+KrrUMIAAp/hr75RXI533oFysjJA26BU6+arLRJRQYR09Sg5a99g6bVDQdQLPMJqQiSojALfDZPhaoIN3RpYKrym0/1M4rx+nAh6krjoew15XTz48s8T+jRj6EYJf2HFefs8 WvT0DbEB Lt2Xq1N14Rl13h4YpUEE2o6oc3e3W9LJm2fYsOi+GHv5DXM32fhXzkTGoTrMCKJlMeSKeGEhZ86sn0cdhwy7nAo7Ie53achTnPl8TVaJdhIll9zGsxWsvnmN7x54u+6XCWmBeTNQv04h6JkmBwVHq86kPcAFJkKRRwZjjvBGyO4ZSwy1CpVrJD5CIAyPk4VkDduVYeY2IGKwxFkz0xbTiIAfRPx8rH7XyF2/vyi8jmLrHE8aQgjev2CqdDtW/NFG7ulNlwgusrROK+k48fEETifvFH3vqOp6XxByOIiSsYdpgDvAklaZK1yutIyuUka1wFPC3o0blExpdMtNDnBmcwfRKhLnjwK9WDe5fUns91LJytf9yvc/d2AfeB7p1320KphZ2iRRf/hS0DmurVUZIj2pu8/p/9hsQTPouYrYK2CzfakZQzrqlWm2PHirKdaxfjbs1jPfCB8tAMYC5rTV8p6Sfpd+MuSUMRp4z0ux/L0xvvugP2AZTGZESeoT7/cnueerjVpDtSyyt0uH/Uso6Q4TveBjE9Bl4U86oDr0Er0fcnkw+52amUUYydL8C1xLUAXhz1s5PbALaiIG6z0bXYHpLjwTMnu0pMl/ZoGe4I7JsUC/MQWyKj5RmNHkt7MtC9wc9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 09:46, Jinjiang Tu wrote: > > 在 2025/7/1 22:21, Oscar Salvador 写道: >> On Fri, Jun 27, 2025 at 08:57:47PM +0800, Jinjiang Tu wrote: >>> In do_migrate_range(), the hwpoisoned folio may be large folio, which >>> can't be handled by unmap_poisoned_folio(). >>> >>> I can reproduce this issue in qemu after adding delay in memory_failure() >>> >>> BUG: kernel NULL pointer dereference, address: 0000000000000000 >>> Workqueue: kacpi_hotplug acpi_hotplug_work_fn >>> RIP: 0010:try_to_unmap_one+0x16a/0xfc0 >>> >>> rmap_walk_anon+0xda/0x1f0 >>> try_to_unmap+0x78/0x80 >>> ? __pfx_try_to_unmap_one+0x10/0x10 >>> ? __pfx_folio_not_mapped+0x10/0x10 >>> ? __pfx_folio_lock_anon_vma_read+0x10/0x10 >>> unmap_poisoned_folio+0x60/0x140 >>> do_migrate_range+0x4d1/0x600 >>> ? slab_memory_callback+0x6a/0x190 >>> ? notifier_call_chain+0x56/0xb0 >>> offline_pages+0x3e6/0x460 >>> memory_subsys_offline+0x130/0x1f0 >>> device_offline+0xba/0x110 >>> acpi_bus_offline+0xb7/0x130 >>> acpi_scan_hot_remove+0x77/0x290 >>> acpi_device_hotplug+0x1e0/0x240 >>> acpi_hotplug_work_fn+0x1a/0x30 >>> process_one_work+0x186/0x340 >>> >>> In this case, just make offline_pages() fail. >>> >>> Besides, do_migrate_range() may be called between memory_failure set >>> hwposion flag and ioslate the folio from lru, so remove WARN_ON(). In other >>> places, unmap_poisoned_folio() is called when the folio is isolated, obey >>> it in do_migrate_range() too. >>> >>> Fixes: b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined") >>> Signed-off-by: Jinjiang Tu >> ... >>> @@ -2041,11 +2048,9 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, >>> >>> ret = scan_movable_pages(pfn, end_pfn, &pfn); >>> if (!ret) { >>> - /* >>> - * TODO: fatal migration failures should bail >>> - * out >>> - */ >>> - do_migrate_range(pfn, end_pfn); >>> + ret = do_migrate_range(pfn, end_pfn); >>> + if (ret) >>> + break; >> I am not really sure about this one. >> I get the reason you're adding it, but note that migrate_pages() can also return >> "fatal" errors and we don't propagate that. >> >> The moto has always been to migrate as much as possible, and this changes this >> behaviour. >> > If we just skip to next pfn, offline_pages() will deadloop meaningless > util received signal. Yeah, that's also not good, > It seems there is no document to guarantee memory offline have to > migrate as much as possible. We should try offlining as good as possible. But if there is something we just cannot possibly migrate, there is no sense in retrying. Now, could we run into this case here because we are racing with other code, and actually retrying again could make it work? Remind me again: how exactly do we arrive at this point of having a large folio that is hwpoisoned but still mapped? In memory_failure(), we do on a large folio 1) folio_set_has_hwpoisoned 2) try_to_split_thp_page 3) if splitting fails, kill_procs_now So given that, couldn't we just retry the migration until the race is over and we are good? -- Cheers, David / dhildenb