From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22461C02196 for ; Tue, 4 Feb 2025 14:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D48E6B0082; Tue, 4 Feb 2025 09:23:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4823A6B0083; Tue, 4 Feb 2025 09:23:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 323056B0085; Tue, 4 Feb 2025 09:23:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 13BB76B0082 for ; Tue, 4 Feb 2025 09:23:56 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D49D160A62 for ; Tue, 4 Feb 2025 14:23:55 +0000 (UTC) X-FDA: 83082481230.25.AA2E690 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf13.hostedemail.com (Postfix) with ESMTP id 5A5F720005 for ; Tue, 4 Feb 2025 14:23:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QVvLs+3s; spf=pass (imf13.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.216.66 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738679033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QyhfawIW6BL9ao0Gk2vDilOwFrFbnNBUuoOSGGmZbwg=; b=8DoPaYHqlKqBEYsx8KmpVKRmzVBG+rN1gNYJQU1wvfDL0vFF2cCvXOAtCeFV6yGxtl89vj IERYvw3EHAt8u/gViUL7nP/NloT88Cr+Xe15lXkw70TVDet0mT2V2ENMpLZ+AwV1gUlLm4 YyAuPIshb+Hs2VmTpoIu87t+CFI3eBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738679033; a=rsa-sha256; cv=none; b=7yfaHBZ59lw5YYwsJBNNuISu+fcC+sQYrL/CNMULasx9cTp+amox3oLfw3chKL8OVB78r1 W6w+WXmNOY18M+rVUdvOlSRfr5v4vw1ZnkAUaeuaGK1BX7W1T7xM+5gTo1/1a8rmzIn6H7 pk9B7feyrzbmArDjQnX+CG+5zrvJI3I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QVvLs+3s; spf=pass (imf13.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.216.66 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-2f9bd7c480eso1590181a91.1 for ; Tue, 04 Feb 2025 06:23:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738679032; x=1739283832; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QyhfawIW6BL9ao0Gk2vDilOwFrFbnNBUuoOSGGmZbwg=; b=QVvLs+3szSA5m+i7WAb29m6b8p3oDzSs++T6If8Nh1nuexjd+0LFGDH8sSQoDBlSuK 12gcLXGPD9pEuhaSdOSevUKQz5QJutbne2e526zptMFK/hNq4P2hRi/AmzdjDvXKkyW1 C+MRCoGGfGvMkFkqJtP+x46CcT+qbl2zY7YC3iPoUYetTX3U3N032v3rVBkkOrY+54+O cSFeiZLc04UEv/pbqm/JQ4fQjwkEQ23nhiNDgJMqIbnYnNu7ccRYpiVsAn9MQwg6PE6Z VRpeZf7Ipk+k08JEiriNfs8Rwq4EwujvO/jWuJ/q1XCuSlApFpeJn0FBzjk8h8fClyLS rqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738679032; x=1739283832; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QyhfawIW6BL9ao0Gk2vDilOwFrFbnNBUuoOSGGmZbwg=; b=qD8+4ADNBsQVssJx+jqiPusG7dg7iyIv1MbxNEJzkHiigUFDaMSOr9uv+QOPZXn05X g+iqwznHbzLGhcJBHrlW8jRAMWLqwuO1VEkggQ/1UYk6XAKU+yYLgujV0jscqb9hQhci l0fSAlfd7LO7oe4nb7Z2BrIlhRdnHwDgjdhy0RucSLVAw92UaeO0hJtwplnRdFkSLUXU UGlP87JCExsjP8O+QR+gfNMfY6jeFV1wKv/Y9ev2UJzMYGNq1JgLr3/LtRZiMnBcFxXl hNf7ONRabeLvvXyUESvvmMojf3ZnJH12iASj9J33ZV4xULEVgZ1XE5EZ27NIy/Mm8/Eo o33A== X-Forwarded-Encrypted: i=1; AJvYcCVY7bFKbO62YAxJAkBLhJyLpYciRYvMURJltlOHHLqrvzdwHYFDG6lp9XA5ROSoP44MmNwaLQt12w==@kvack.org X-Gm-Message-State: AOJu0Yx5We3A6IYNMSNNJMam4KZN5F7dQAIfXO2cVaAjz3bsqregAkBB soL9Lemb8crPzlpA5xjIp1hmv0YmsOo4c3QZiiDzKTiJT1AB6QDI X-Gm-Gg: ASbGncv4Myq56SwosZwlukpqK6VJ3nuld+RTIoSIOnWaGQSCDykmPcP3Z89ravWtPhB 84JTLUI0jMTam7tAD3eFEnRUqaLFqzBhVZ/O9K7j/BhGq/tICJlPhYpQ9D0IyukKCskHvEeTKE/ dav1ggCoF275sxbsTRalakdxn2+O4qDX0vzQk8TJnjQ2SZtpyKl3X3I0z91BT7XCRVJ6Oz8xIlq GOqPEnPoVPU4UhjPbPox7nqxCLxn3U7Eommsz5nXUGTL6XJTg1Q219caWp9dN6eOyUnmPBgBkzN lMC0tRyz1YsvKyd4mKdFIMUS+b53nVtqUJoUIuKS96ZAt1Bzvj3Ow03kDfMRtugQ7Q/jtonT2gL 0LOM= X-Google-Smtp-Source: AGHT+IF0T9oZQc1Tw7DdE7b1zk1AYdK5JS5KIXLtSzoJadaSG6bKYNHl/8toZwcR/pyHhtDXi9GUPQ== X-Received: by 2002:a17:90a:1189:b0:2f9:c56b:6ec8 with SMTP id 98e67ed59e1d1-2f9c56b6fb0mr3538171a91.10.1738679032080; Tue, 04 Feb 2025 06:23:52 -0800 (PST) Received: from ?IPV6:2409:8a55:301b:e120:3936:dcf4:dc64:c1b9? ([2409:8a55:301b:e120:3936:dcf4:dc64:c1b9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f83bc97d95sm14927006a91.8.2025.02.04.06.23.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 06:23:51 -0800 (PST) Message-ID: Date: Tue, 4 Feb 2025 22:23:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v8 3/5] page_pool: fix IOMMU crash when driver has already unbound To: Christoph Hellwig , Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, zhangkun09@huawei.com, liuyonglong@huawei.com, fanghaiqing@huawei.com, Robin Murphy , Alexander Duyck , IOMMU , Andrew Morton , Eric Dumazet , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20250127025734.3406167-1-linyunsheng@huawei.com> <20250127025734.3406167-4-linyunsheng@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ucmz4gc8js4bsbcssb61h9azo9du1qau X-Rspamd-Queue-Id: 5A5F720005 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738679033-840615 X-HE-Meta: U2FsdGVkX19LxmPa2qBbSF8bnTVSMvlqvPlxKSYiTohw/evKhkIlBZATm1HbgPE606Ggl6slgXZx/bOcSeU1vTsTYEfP/Sn7I/86XgNAYegD3cAGAGtjPlx6BauK1lw40bHcpRnSJdAs/92d3dhQrXUDF4lVJCb0i0kK6wJK/JOB6fbskM1AgORpC3qVPUWD+x7NqVpto9iJQ+LpGn1INZ1loPeZqAN6UEl0bpDXwZsBwMlyI+oVy4jgpX8xaVQIWjtNvtzmmp2UgIK5NL11RiwAW6jDMKMN6kknHtU3c+CZcj+git72fxj9u1VqeW/VS6xQGczqS/bgEeDkaV2Bx8QqOJu6KZNsFhItJpUEpm4JglAftNdui4m6/ud7sjVDwWVH8QrZR6ue6NeVJIVBvy15wGDs5QpXyEASt/euzMhUG3TXB4c1xT09CoP3vjeYAB9j7MaTHqVSLd57fiq91Na8UfOkGopS3PyHb2JI69+wHDi1NMs3PSj01eYE68U5YGWZWY4FkVtDv5za7WUKCT6N8JzOkqEs0k2uexW+qgsYG1WGpF73Yoz7SsgRdmKwcuAqLYIf+yMBIMJXzK2yB6sryZ4FROqG0oF2ZTgxcOas8xDunf5S7Z27DHApH8WaUrs/XLJsy975HnCrX/dHh9/PdlqEKkKYjdXTtR/53BxOd6NpHZxliodx/hnQ6YXmvJg+YItGuGxzyFES0dLfRLLT/EWtJfQAVRy82hvYWN2pBP4jd1CacUzaswHdHI3sfetfbgqkgBXmOSJ/e04h4L3DrJ0nFV/f9MUzg5lMkULEKmSlDFJ1PR6tzrtQEBc/iKHN5YWRMXzB3UtfDrGc2R6u68rMky0upn5cSb+Ap2U8fLBLVatB2Y97HAz0uof/OnSHBTC92Opa7metQTSXoUYYlbW2+Lw1Lp+AwvYPH18JB1UKF0rzdG0LblZGkNAjFPqoMQm/fObqauvV+EJ FkzgTOo7 UmENpCNqVpqHJStjgZgiZz9AaeEPiOJF2z8UESQCLTCbsoGWp74a5mehqxxN3dzPNj/0tx6YBGXYKok8G7+As06svGfzk3CXjxShhE242nb7y9YbfNjn6sJDZUEA7tfJ9P0jauTedDUa3KRQjoLnsmxAVMQNagBElMkA1KX4TWS4Z6AxgNhBIB25Kq234cl6YnHyuKn1Bk/FDEfIexFwcr7CYkX58e1hk01kaFkNh9hRxVYnp0uLWb+fEVvm8IBC3ZqUT9lMpZOIrR9PNpqJPFyUyeeWnB+/ylcPdNj/gZN+alONA1PxCOrpnS0n6C254iTic72efnVgL17MkwNkbpXr5de2uJ8+IwOaxb0WcERGagAJIhxzxMusCB8JdqxWyUPgM5mt4nxVK0hDxKaEdgtuq5VQ4J8yGkKFZ94vxKKdJV83M7ubJh+ELZ1e6BMqrenvOgoNPnOsdjaGdIrT4ORRIILzG0jNWPgzsSYzUZ9FXhozPi3QM0atHIZxqkuHRkA/Hhp0CL86WpscGo83LNqpjmVFp/Cmh52G/unQZmSRMHxhk+M2AgkvP70+aGQRNimVm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/28/2025 2:12 PM, Christoph Hellwig wrote: > On Mon, Jan 27, 2025 at 10:57:32AM +0800, Yunsheng Lin wrote: >> Note, the devmem patchset seems to make the bug harder to fix, >> and may make backporting harder too. As there is no actual user >> for the devmem and the fixing for devmem is unclear for now, >> this patch does not consider fixing the case for devmem yet. > > Is there another outstanding patchet? Or do you mean the existing > devmem code already merged? If that isn't actually used it should > be removed, but otherwise you need to fix it. The last time I checked, only the code for networking stack supporting the devmem had been merged. The first driver suppporting seems to be bnxt, which seems to be under review: https://lore.kernel.org/all/20241022162359.2713094-1-ap420073@gmail.com/ As my understanding, this should work for the devmem too if the devmem provide a ops to do the per-netmem dma unmapping It would be good that devmem people can have a look at it and see if this fix works for the specific page_pool mp provider.